Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

fix: preserve generated partner attachments

XuanDua988f8877810
diff --git a/deeptutor/services/partners/runtime.py b/deeptutor/services/partners/runtime.py
index cba000723..10bc415ad 100644
--- a/deeptutor/services/partners/runtime.py
+++ b/deeptutor/services/partners/runtime.py
@@ -53,6 +53,7 @@ from deeptutor.services.partners.scope import partner_scope
from deeptutor.services.partners.sessions import PartnerSessionStore, conversation_scope
from deeptutor.services.partners.workspace import ensure_partner_workspace, read_soul
from deeptutor.services.partners.workspace_binding import partner_content_context
+from deeptutor.services.session.artifact_attachments import artifact_attachments
logger = logging.getLogger(__name__)
@@ -322,7 +323,7 @@ class PartnerRunner:
delivery_meta.update(command.metadata)
return command.content
- final, turn_events = await self._run_turn(
+ final, turn_events, generated_attachments = await self._run_turn(
msg,
store=store,
on_event=on_event,
@@ -365,6 +366,7 @@ class PartnerRunner:
}
or None,
events=turn_events or None,
+ attachments=generated_attachments or None,
)
return final
@@ -376,12 +378,12 @@ class PartnerRunner:
on_event: EventCallback | None = None,
delivery_meta: dict[str, Any] | None = None,
options: PartnerTurnOptions | None = None,
- ) -> tuple[str, list[dict[str, Any]]]:
+ ) -> tuple[str, list[dict[str, Any]], list[dict[str, Any]]]:
ensure_partner_workspace(self.partner_id)
primary = getattr(self.config, "llm_selection", None) or None
backup = getattr(self.config, "backup_llm_selection", None) or None
- final_text, errors, events = await self._execute_turn(
+ final_text, errors, events, generated_attachments = await self._execute_turn(
msg,
store=store,
selection=primary,
@@ -397,7 +399,7 @@ class PartnerRunner:
)
if delivery_meta is not None:
delivery_meta.pop("_streamed", None)
- final_text, errors, events = await self._execute_turn(
+ final_text, errors, events, generated_attachments = await self._execute_turn(
msg,
store=store,
selection=backup,
@@ -408,7 +410,7 @@ class PartnerRunner:
if not final_text and errors:
final_text = f"Sorry, the turn failed: {errors[-1]}"
- return final_text, events
+ return final_text, events, generated_attachments
async def _execute_turn(
self,
@@ -419,7 +421,7 @@ class PartnerRunner:
on_event: EventCallback | None = None,
delivery_meta: dict[str, Any] | None = None,
options: PartnerTurnOptions | None = None,
- ) -> tuple[str, list[str], list[dict[str, Any]]]:
+ ) -> tuple[str, list[str], list[dict[str, Any]], list[dict[str, Any]]]:
"""Run one chat turn with *selection* active; returns (final, errors, events).
``events`` is the turn's trace (every StreamEvent except done/session,
@@ -453,6 +455,8 @@ class PartnerRunner:
answer_visible_parts: list[str] = []
errors: list[str] = []
turn_events: list[dict[str, Any]] = []
+ generated_attachments: list[dict[str, Any]] = []
+ seen_artifact_urls: set[str] = set()
wants_stream = False
context: UnifiedContext | None = None
@@ -530,6 +534,16 @@ class PartnerRunner:
):
turn_events.append(event.to_dict())
+ # Persist generated workspace items alongside the
+ # partner reply. The Web UI needs their opaque URLs
+ # to turn a model-written relative Markdown path into
+ # an actual download action after a refresh.
+ for attachment in artifact_attachments(event):
+ url = str(attachment.get("url") or "")
+ if url and url not in seen_artifact_urls:
+ seen_artifact_urls.add(url)
+ generated_attachments.append(attachment)
+
if event.type == StreamEventType.CONTENT:
call_id = str(meta.get("call_id") or "")
round_buffers.setdefault(call_id, []).append(event.content or "")
@@ -643,7 +657,7 @@ class PartnerRunner:
delivery_meta["_streamed"] = True
delivery_meta["_stream_id"] = f"{turn_id}:{call_id}"
- return final_text, errors, turn_events
+ return final_text, errors, turn_events, generated_attachments
# ── context assembly ──────────────────────────────────────────
diff --git a/deeptutor/services/path_service.py b/deeptutor/services/path_service.py
index 6d342b392..9da60822e 100644
--- a/deeptutor/services/path_service.py
+++ b/deeptutor/services/path_service.py
@@ -159,7 +159,11 @@ class PathService:
if not candidate.is_file():
return None
- if candidate.suffix.lower() in self._PRIVATE_SUFFIXES:
+ # Markdown is a valid generated artifact (for example, an exec tool
+ # may write a report.md). Keep the private-suffix guard for settings,
+ # source, and runtime files, but let the explicit public-output
+ # allowlist below decide whether a .md artifact is readable.
+ if candidate.suffix.lower() in self._PRIVATE_SUFFIXES - {".md"}:
return None
parts = relative.parts
diff --git a/tests/api/test_output_files.py b/tests/api/test_output_files.py
index bdca51fbd..524e148c4 100644
--- a/tests/api/test_output_files.py
+++ b/tests/api/test_output_files.py
@@ -159,6 +159,18 @@ def test_workspace_output_chat_kinds_are_public(tmp_path: Path, kind: str) -> No
assert service.resolve_public_output_path(output) == output
+def test_workspace_markdown_output_is_public(tmp_path: Path) -> None:
+ workspace_root = tmp_path / "workspace"
+ service = PathService(workspace_root=workspace_root)
+ output = _write_output(
+ workspace_root,
+ "workspace/outputs/chat/session-1/turn-1/exec/report.md",
+ b"# generated report",
+ )
+
+ assert service.resolve_public_output_path(output) == output
+
+
def test_arbitrary_workspace_output_file_is_not_public(tmp_path: Path) -> None:
workspace_root = tmp_path / "workspace"
service = PathService(workspace_root=workspace_root)
diff --git a/tests/services/partners/test_partner_runtime.py b/tests/services/partners/test_partner_runtime.py
index a8aea610b..7ad23d019 100644
--- a/tests/services/partners/test_partner_runtime.py
+++ b/tests/services/partners/test_partner_runtime.py
@@ -137,6 +137,49 @@ class TestTurnExecution:
{"role": "assistant", "content": "The answer is 4."},
]
+ @pytest.mark.asyncio
+ async def test_persists_presented_workspace_item_as_generated_attachment(
+ self, partners_root, fake_orchestrator
+ ):
+ workspace_item = {
+ "workspace_id": "ws_test",
+ "workspace_item_id": "wsi_test",
+ "relative_path": "outputs/chat/turn/report.md",
+ "filename": "report.md",
+ "url": "/files/workspace-items/ws_test/wsi_test",
+ "mime_type": "text/markdown",
+ "size_bytes": 42,
+ "generated": True,
+ }
+ fake_orchestrator.script = [
+ event(
+ StreamEventType.TOOL_RESULT,
+ metadata={"tool_metadata": {"workspace_items": [workspace_item]}},
+ ),
+ *finish("[Download](outputs/chat/turn/report.md)"),
+ ]
+
+ await _runner(partners_root).process_message(_msg())
+
+ assistant = _shared_store().messages("telegram:42")[1]
+ assert assistant["attachments"] == [
+ {
+ "type": "document",
+ "filename": "report.md",
+ "mime_type": "text/markdown",
+ "url": "/files/workspace-items/ws_test/wsi_test",
+ "size_bytes": 42,
+ "generated": True,
+ "origin": "workspace",
+ "workspace_id": "ws_test",
+ "workspace_item_id": "wsi_test",
+ "relative_path": "outputs/chat/turn/report.md",
+ "sha256": "",
+ "title": "",
+ "caption": "",
+ }
+ ]
+
@pytest.mark.asyncio
async def test_a_group_conversation_records_where_it_happened(
self, partners_root, fake_orchestrator
diff --git a/web/components/partners/PartnerChat.tsx b/web/components/partners/PartnerChat.tsx
index 83352ada7..be2c34435 100644
--- a/web/components/partners/PartnerChat.tsx
+++ b/web/components/partners/PartnerChat.tsx
@@ -31,7 +31,9 @@ import { createPartnerDraftPublisher } from "@/lib/partner-chat-draft";
import { ReconnectingWebSocket } from "@/lib/reconnecting-websocket";
import type { ExportableMessage } from "@/lib/chat-export";
import type { StreamEvent } from "@/features/chat/model/protocol";
+import type { MessageAttachment } from "@/features/chat/ChatStateAdapter";
import { docIconFor, formatBytes, isSvgFilename } from "@/lib/doc-attachments";
+import { InlineFileCardProvider } from "@/components/common/InlineFileCard";
import {
isRetractionMarker,
recomputeAnswerContent,
@@ -75,6 +77,15 @@ interface PartnerMessageAttachment {
mimeType?: string;
size?: number;
previewUrl?: string;
+ url?: string;
+ generated?: boolean;
+ origin?: "workspace";
+ workspaceId?: string;
+ workspaceItemId?: string;
+ relativePath?: string;
+ sha256?: string;
+ title?: string;
+ caption?: string;
}
// Commands the web client handles itself (they change client state — the
@@ -120,12 +131,51 @@ function normalizeHistoryAttachments(
type: String(obj.type || "file"),
filename,
mimeType: String(obj.mime_type || obj.mimeType || ""),
- size: typeof sizeRaw === "number" ? sizeRaw : undefined,
+ size:
+ typeof obj.size_bytes === "number"
+ ? obj.size_bytes
+ : typeof sizeRaw === "number"
+ ? sizeRaw
+ : undefined,
+ url: typeof obj.url === "string" ? obj.url : undefined,
+ generated: Boolean(obj.generated),
+ origin: obj.origin === "workspace" ? "workspace" : undefined,
+ workspaceId:
+ typeof obj.workspace_id === "string" ? obj.workspace_id : undefined,
+ workspaceItemId:
+ typeof obj.workspace_item_id === "string"
+ ? obj.workspace_item_id
+ : undefined,
+ relativePath:
+ typeof obj.relative_path === "string" ? obj.relative_path : undefined,
+ sha256: typeof obj.sha256 === "string" ? obj.sha256 : undefined,
+ title: typeof obj.title === "string" ? obj.title : undefined,
+ caption: typeof obj.caption === "string" ? obj.caption : undefined,
};
})
.filter((item): item is PartnerMessageAttachment => item !== null);
}
+function workspaceAttachments(
+ attachments?: PartnerMessageAttachment[],
+): MessageAttachment[] {
+ return (attachments ?? []).map((attachment) => ({
+ type: attachment.type,
+ filename: attachment.filename,
+ url: attachment.url,
+ mime_type: attachment.mimeType,
+ generated: attachment.generated,
+ size_bytes: attachment.size,
+ origin: attachment.origin,
+ workspace_id: attachment.workspaceId,
+ workspace_item_id: attachment.workspaceItemId,
+ relative_path: attachment.relativePath,
+ sha256: attachment.sha256,
+ title: attachment.title,
+ caption: attachment.caption,
+ }));
+}
+
function normalizeHistoryMessages(history: PartnerHistoryMessage[]): ChatMsg[] {
return history
.filter((message) => message.role === "user" || message.role === "assistant")
@@ -301,6 +351,18 @@ export default function PartnerChat({
const loadedTotalRef = useRef(0);
const oldestIndexRef = useRef(0);
const refreshInFlightRef = useRef(false);
+ const downloadGeneratedAttachment = useCallback(
+ (attachment: MessageAttachment) => {
+ if (!attachment.url) return;
+ const link = document.createElement("a");
+ link.href = attachment.url;
+ link.download = attachment.filename || "download";
+ document.body.appendChild(link);
+ link.click();
+ link.remove();
+ },
+ [],
+ );
useEffect(() => onBusyChange?.(streaming), [onBusyChange, streaming]);
useEffect(() => () => onBusyChange?.(false), [onBusyChange]);
// Attach to an in-flight turn only AFTER history has loaded, so the replay's
@@ -1169,7 +1231,13 @@ export default function PartnerChat({
{msg.content}
</p>
) : (
- <AssistantResponse content={msg.content} />
+ <InlineFileCardProvider
+ attachments={workspaceAttachments(msg.attachments)}
+ events={msg.events}
+ onOpen={downloadGeneratedAttachment}
+ >
+ <AssistantResponse content={msg.content} />
+ </InlineFileCardProvider>
)}
</div>
</div>
@@ -1195,7 +1263,13 @@ export default function PartnerChat({
headerClassName="min-h-[26px]"
/>
{draft.content ? (
- <AssistantResponse content={draft.content} />
+ <InlineFileCardProvider
+ attachments={[]}
+ events={draft.events}
+ onOpen={downloadGeneratedAttachment}
+ >
+ <AssistantResponse content={draft.content} />
+ </InlineFileCardProvider>
) : null}
</div>
</div>
@@ -1223,7 +1297,13 @@ export default function PartnerChat({
headerClassName="min-h-[26px]"
/>
{externalDraft.content ? (
- <AssistantResponse content={externalDraft.content} />
+ <InlineFileCardProvider
+ attachments={[]}
+ events={externalDraft.events}
+ onOpen={downloadGeneratedAttachment}
+ >
+ <AssistantResponse content={externalDraft.content} />
+ </InlineFileCardProvider>
) : null}
</div>
</div>