Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

fix(mastery): defer failed profile notice until response finish

yepyhunb081d97f647e
diff --git a/deeptutor/capabilities/mastery/loop.py b/deeptutor/capabilities/mastery/loop.py
index b49991d4e..eebcaeabe 100644
--- a/deeptutor/capabilities/mastery/loop.py
+++ b/deeptutor/capabilities/mastery/loop.py
@@ -427,6 +427,11 @@ class MasteryLoopCapability:
state = context.extension("mastery")
notice = ""
if state.get("profile_write_pending"):
+ if not final_text.strip() and not state.get("card_posted"):
+ # This hook also runs after every tool batch. An optional
+ # storage notice cannot end work still in progress; append it
+ # only to a real final answer or an accepted question card.
+ return None
# Optional memory failure must not deadlock otherwise valid tutoring.
# The native status corrects any unsupported persistence promise;
# it does not classify or discard the learner-facing explanation.
diff --git a/tests/capabilities/test_mastery_profile_continuity.py b/tests/capabilities/test_mastery_profile_continuity.py
index 6d4cf76be..3b8a4cb11 100644
--- a/tests/capabilities/test_mastery_profile_continuity.py
+++ b/tests/capabilities/test_mastery_profile_continuity.py
@@ -122,3 +122,27 @@ def test_unsaved_notice_preserves_card_finish_postcondition():
visible = MasteryLoopCapability().final_text_override(context, "")
assert "not saved" in visible
assert context.extension("mastery")["card_posted"] is False
+
+
[email protected]("quiz_requested", [False, True])
+def test_unsaved_profile_notice_does_not_finish_an_active_tool_round(quiz_requested):
+ from deeptutor.capabilities.mastery.loop import MasteryLoopCapability
+ from deeptutor.core.context import UnifiedContext
+
+ context = UnifiedContext(metadata={"mastery_mode": True})
+ capability = MasteryLoopCapability()
+ state = context.extension("mastery")
+ state.update(profile_write_pending=True, quiz_requested=quiz_requested)
+ assert capability.final_text_override(context, "") is None
+ assert state["profile_write_pending"] is True
+ assert "profile_receipt" not in state
+ if quiz_requested:
+ state["profile_repair_requested"] = True
+ assert "no question card" in capability.finish_instruction(context, "Done.")
+ state["card_posted"] = True
+ final = capability.final_text_override(context, "")
+ else:
+ final = capability.final_text_override(context, "Useful explanation.")
+ assert final.endswith("Useful explanation.")
+ assert "was not saved" in final
+ assert state["profile_receipt"] == {"status": "not_saved"}