DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.
Python ai-agentsai-tutorclawbotcli-tooldeepresearchinteractive-learninglearningmulti-agent-systemsrag
fix(math-animator): stop truncation retries at the output ceiling (#1914)
Bingxi Zhao (Frank)ce48fc2d4c2f
diff --git a/deeptutor/agents/math_animator/agents/code_generator_agent.py b/deeptutor/agents/math_animator/agents/code_generator_agent.pyindex 1899fd17b..f22ba4871 100644--- a/deeptutor/agents/math_animator/agents/code_generator_agent.py+++ b/deeptutor/agents/math_animator/agents/code_generator_agent.py@@ -229,10 +229,17 @@ class CodeGeneratorAgent(BaseAgent):)if structured_attempt >= max_retries:break+ # Once the budget cannot grow, another truncated call repeats+ # the same failure instead of repairing it (#1914).+ if (+ outcome.truncated+ and escalated_max_tokens(base_max_tokens, truncations) <= max_tokens+ ):+ breakawait asyncio.sleep(min(0.25 * (2**structured_attempt), 2.0))raise GeneratedCodeOutputError(- f"Math animator {stage} returned no usable code after {attempts} attempts. "+ f"Math animator {stage} returned no usable code after {structured_attempt + 1} attempts. "f"Last attempt: {last_failure}") from last_errordiff --git a/tests/agents/math_animator/test_code_generator_agent.py b/tests/agents/math_animator/test_code_generator_agent.pyindex 6e11434e0..27ea72f20 100644--- a/tests/agents/math_animator/test_code_generator_agent.py+++ b/tests/agents/math_animator/test_code_generator_agent.py@@ -61,8 +61,10 @@ async def test_code_generation_retries_empty_or_reasoning_only_output(@pytest.mark.asyncio[email protected]("retries", [1, 4])async def test_code_generation_fails_clearly_after_structured_retries(monkeypatch: pytest.MonkeyPatch,+ retries: int,) -> None:async def fake_sleep(_delay: float) -> None:return None@@ -71,20 +73,25 @@ async def test_code_generation_fails_clearly_after_structured_retries("deeptutor.agents.math_animator.agents.code_generator_agent.asyncio.sleep",fake_sleep,)- agent = _agent(monkeypatch, ["", "{}"])+ responses = ["{}"] * (retries + 1)+ agent = _agent(monkeypatch, responses)+ monkeypatch.setattr(agent, "get_max_retries", lambda: retries)- with pytest.raises(GeneratedCodeOutputError, match="after 2 attempts"):+ with pytest.raises(GeneratedCodeOutputError, match=f"after {retries + 1} attempts"):await agent.generate(user_input="Animate a proof",output_mode="video",analysis=ConceptAnalysis(),design=SceneDesign(),)+ assert responses == []@pytest.mark.asyncio[email protected]("retries", [2, 8])async def test_truncated_generation_grows_the_budget_and_asks_for_less_reasoning(monkeypatch: pytest.MonkeyPatch,+ retries: int,) -> None:"""A reasoning model that hits the cap must not be asked the same thing again.@@ -101,7 +108,7 @@ async def test_truncated_generation_grows_the_budget_and_asks_for_less_reasoningfake_sleep,)agent = _agent(monkeypatch, [])- monkeypatch.setattr(agent, "get_max_retries", lambda: 2)+ monkeypatch.setattr(agent, "get_max_retries", lambda: retries)monkeypatch.setattr(agent, "get_max_tokens", lambda: 8000)calls: list[dict[str, object]] = []@@ -134,6 +141,7 @@ async def test_truncated_generation_grows_the_budget_and_asks_for_less_reasoningassert "token limit" not in str(calls[0]["user_prompt"])# The failure names the cause instead of "no usable code after 3 attempts".message = str(raised.value)+ assert "after 3 attempts" in message # #1914: report calls made, not the retry limit.assert "cut off at the 16000-token output cap" in messageassert "chain-of-thought" in messageassert "reasoning_tokens=7800" in message