Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

fix: recognize referenced task model in readiness

FriedorixNietzschecf5d112534b4
diff --git a/deeptutor/services/config/readiness.py b/deeptutor/services/config/readiness.py
index 0127bca6f..8340604fa 100644
--- a/deeptutor/services/config/readiness.py
+++ b/deeptutor/services/config/readiness.py
@@ -237,6 +237,30 @@ def catalog_service_rows(
required = name in required_services
service = services.get(name) if isinstance(services.get(name), dict) else {}
profiles = service.get("profiles") if isinstance(service.get("profiles"), list) else []
+
+ # Task models may reference a configured chat model instead of owning
+ # a task-specific profile. Reuse the task runtime's canonical check so
+ # readiness agrees with the configuration that will actually run.
+ if name == "task" and service.get("mode") == "reference":
+ from deeptutor.services.model_selection.tasks import task_service_configured
+
+ if task_service_configured(catalog):
+ rows.append(
+ readiness_row(
+ "catalog.task",
+ "catalog",
+ _SERVICE_LABELS[name],
+ "enabled_verified",
+ "configuration_verified",
+ enabled=True,
+ available=True,
+ configured=True,
+ verified=True,
+ required=required,
+ )
+ )
+ continue
+
active_profile_id = service.get("active_profile_id")
if not active_profile_id:
rows.append(
diff --git a/tests/services/config/test_readiness.py b/tests/services/config/test_readiness.py
index b97b49d86..34cb9d901 100644
--- a/tests/services/config/test_readiness.py
+++ b/tests/services/config/test_readiness.py
@@ -58,6 +58,49 @@ def test_catalog_readiness_is_value_free_and_detects_stale_selection() -> None:
assert "secret-model-name" not in serialized
+def test_task_reference_mode_is_ready_and_enables_reason_tool() -> None:
+ catalog = _empty_catalog()
+ catalog["services"]["llm"] = {
+ "active_profile_id": "llm-profile",
+ "active_model_id": "llm-model",
+ "profiles": [
+ {
+ "id": "llm-profile",
+ "models": [
+ {
+ "id": "llm-model",
+ "model": "test-model",
+ }
+ ],
+ }
+ ],
+ }
+ catalog["services"]["task"].update(
+ {
+ "mode": "reference",
+ "selection": {
+ "profile_id": "llm-profile",
+ "model_id": "llm-model",
+ },
+ }
+ )
+
+ rows = catalog_service_rows(catalog)
+
+ task = next(row for row in rows if row["id"] == "catalog.task")
+ assert task["state"] == "enabled_verified"
+ assert task["detail_code"] == "configuration_verified"
+ assert task["configured"] is True
+ assert task["verified"] is True
+
+ dependency_rows = {row["id"]: row for row in rows}
+ reason = next(
+ row for row in tool_rows(["reason"], dependency_rows) if row["id"] == "tool.reason"
+ )
+ assert reason["state"] == "enabled_verified"
+ assert reason["detail_code"] == "tool_ready"
+
+
def test_selected_remote_parser_must_be_installed_ready_and_reachable() -> None:
entries = [
{"id": "tika", "name": "Tika", "available": True},