Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

fix(co-writer): retain drafts when migration storage is full

dajiaohuangd6064c4fb125
diff --git a/web/features/co-writer/storage/drafts.ts b/web/features/co-writer/storage/drafts.ts
index 22bf65342..1232e0682 100644
--- a/web/features/co-writer/storage/drafts.ts
+++ b/web/features/co-writer/storage/drafts.ts
@@ -62,6 +62,15 @@ export function loadDraft(
const legacyContent = storage.getItem(legacyKey);
if (legacyContent === null) return null;
const migrated = saveDraft(storage, docId, legacyContent, 0);
+ if (!migrated) {
+ return {
+ version: DRAFT_STORAGE_VERSION,
+ docId,
+ content: legacyContent,
+ revision: 0,
+ updatedAt: Date.now(),
+ };
+ }
storage.removeItem(legacyKey);
return migrated;
} catch {
diff --git a/web/tests/co-writer-editor-state.test.ts b/web/tests/co-writer-editor-state.test.ts
index c7bd43d50..0586f7663 100644
--- a/web/tests/co-writer-editor-state.test.ts
+++ b/web/tests/co-writer-editor-state.test.ts
@@ -123,3 +123,23 @@ test("draft storage failures are nonfatal", () => {
assert.equal(saveDraft(broken, "doc", "text", 1), null);
assert.equal(clearDraft(broken, "doc"), false);
});
+
+test("failed legacy migration preserves the unsaved text for loading and retry", () => {
+ const storage = new MemoryStorage();
+ const legacyKey = `${LEGACY_DRAFT_STORAGE_PREFIX}doc/a`;
+ storage.setItem(legacyKey, "unsaved draft text");
+ const write = storage.setItem.bind(storage);
+ storage.setItem = () => {
+ throw new DOMException("Storage is full", "QuotaExceededError");
+ };
+
+ assert.equal(loadDraft(storage, "doc/a")?.content, "unsaved draft text");
+ assert.equal(storage.getItem(legacyKey), "unsaved draft text");
+ assert.equal(storage.getItem(`${DRAFT_STORAGE_PREFIX}doc%2Fa`), null);
+ assert.equal(loadDraft(storage, "doc/a")?.content, "unsaved draft text");
+
+ storage.setItem = write;
+ assert.equal(loadDraft(storage, "doc/a")?.content, "unsaved draft text");
+ assert.equal(storage.getItem(legacyKey), null);
+ assert.notEqual(storage.getItem(`${DRAFT_STORAGE_PREFIX}doc%2Fa`), null);
+});