Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

fix(codebuddy): omit SDK exception bodies from warning logs

Bingxi Zhao (Frank)d967457e6978
diff --git a/deeptutor/services/llm/provider_core/codebuddy_provider.py b/deeptutor/services/llm/provider_core/codebuddy_provider.py
index 0036b7d24..adc2e71fb 100644
--- a/deeptutor/services/llm/provider_core/codebuddy_provider.py
+++ b/deeptutor/services/llm/provider_core/codebuddy_provider.py
@@ -33,14 +33,6 @@ _MCP_TOOL_PREFIX = f"mcp__{_MCP_SERVER_NAME}__"
logger = logging.getLogger(__name__)
-def _short_exception(exc: BaseException) -> str:
- """Type plus a short reason — never prompt bodies or credentials."""
- reason = str(exc).strip()
- if len(reason) > 200:
- reason = reason[:200] + "..."
- return reason or "<no message>"
-
-
@dataclass
class _SessionTurn:
prompt: str
@@ -562,10 +554,9 @@ async def _consume_messages(
await interrupt()
except Exception as exc:
logger.warning(
- "CodeBuddy interrupt after tool calls failed (%s: %s); "
+ "CodeBuddy interrupt after tool calls failed (%s); "
"background generation may keep running",
type(exc).__name__,
- _short_exception(exc),
)
else:
await _drain_interrupted_response(messages)
@@ -590,10 +581,9 @@ async def _drain_interrupted_response(messages: Any) -> None:
return
except Exception as exc:
logger.warning(
- "CodeBuddy interrupted response drain failed (%s: %s); "
+ "CodeBuddy interrupted response drain failed (%s); "
"stale SDK messages may surface in the next turn",
type(exc).__name__,
- _short_exception(exc),
)
diff --git a/tests/services/llm/test_codebuddy_provider.py b/tests/services/llm/test_codebuddy_provider.py
index 6ac78a210..c34ff235e 100644
--- a/tests/services/llm/test_codebuddy_provider.py
+++ b/tests/services/llm/test_codebuddy_provider.py
@@ -435,7 +435,7 @@ async def test_codebuddy_interrupt_failure_after_tool_calls_logs_warning(
async def interrupt(self):
self.interrupt_calls += 1
- raise RuntimeError("interrupt pipe closed")
+ raise RuntimeError("Authorization: Bearer fake-token; prompt=private-user-body")
async def disconnect(self):
pass
@@ -484,6 +484,9 @@ async def test_codebuddy_interrupt_failure_after_tool_calls_logs_warning(
assert any(
"interrupt" in r.getMessage().lower() and "RuntimeError" in r.getMessage() for r in warnings
), [r.getMessage() for r in warnings]
+ assert "fake-token" not in caplog.text
+ assert "private-user-body" not in caplog.text
+ assert all(record.exc_info is None for record in warnings)
session = provider._sessions["chat-interrupt-fail"]
assert session.client.interrupt_calls == 1
await provider.aclose()
@@ -554,3 +557,20 @@ def test_codebuddy_ignores_deeptutor_no_key_placeholder() -> None:
async def _append_async(items: list[str], text: str) -> None:
items.append(text)
+
+
+async def test_interrupted_drain_logs_error_type_without_exception_body(caplog):
+ from deeptutor.services.llm.provider_core.codebuddy_provider import _drain_interrupted_response
+
+ async def broken_stream():
+ yield {"type": "intermediate"}
+ raise RuntimeError("Authorization: Bearer fake-token; prompt=private-user-body")
+
+ with caplog.at_level(logging.WARNING):
+ await _drain_interrupted_response(broken_stream())
+
+ assert "drain failed (RuntimeError)" in caplog.text
+ assert "fake-token" not in caplog.text
+ assert "private-user-body" not in caplog.text
+ assert all(record.exc_info is None for record in caplog.records)