Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

fix: complete Polish language integration

ChinskiKaczynskif446ac6715a1
diff --git a/deeptutor/services/config/launch_settings.py b/deeptutor/services/config/launch_settings.py
index 1c5febd2b..9b82a2cb9 100644
--- a/deeptutor/services/config/launch_settings.py
+++ b/deeptutor/services/config/launch_settings.py
@@ -62,6 +62,8 @@ def _normalize_language(value: Any) -> str | None:
return "de"
if language == "ukrainian" or base in {"uk", "ua"}:
return "uk"
+ if language in {"polish", "polski"} or base == "pl":
+ return "pl"
return None
diff --git a/deeptutor/services/config/settings_spec.py b/deeptutor/services/config/settings_spec.py
index 9271b2559..0cf9ad99b 100644
--- a/deeptutor/services/config/settings_spec.py
+++ b/deeptutor/services/config/settings_spec.py
@@ -131,6 +131,7 @@ _LANGUAGE_CHOICES: tuple[tuple[str, str, str], ...] = (
("fr", "Français", "Interface and replies in French."),
("de", "Deutsch", "Interface and replies in German."),
("uk", "Українська", "Interface and replies in Ukrainian."),
+ ("pl", "Polski", "Interface and replies in Polish."),
)
_RESPONSE_LANGUAGE_CHOICES: tuple[tuple[str, str, str], ...] = (
diff --git a/deeptutor/services/settings/interface_settings.py b/deeptutor/services/settings/interface_settings.py
index 95e7cc312..2448d568c 100644
--- a/deeptutor/services/settings/interface_settings.py
+++ b/deeptutor/services/settings/interface_settings.py
@@ -19,7 +19,7 @@ from deeptutor.response_languages import SUPPORTED_RESPONSE_LANGUAGES
from deeptutor.services.path_service import get_path_service
from deeptutor.tools.builtin import USER_TOGGLEABLE_TOOL_NAMES
-UiLanguage = Literal["en", "zh", "fr", "de", "uk"]
+UiLanguage = Literal["en", "zh", "fr", "de", "uk", "pl"]
DEFAULT_UI_SETTINGS: dict[str, Any] = {
# "snow" is the pure-white neutral theme, shown as "Default" in the UI.
@@ -86,6 +86,7 @@ def _normalize_language(language: Any, default: str = "en") -> str:
- fr/french -> fr
- de/german/deutsch -> de
- uk/ukrainian/ua -> uk
+ - pl/polish/polski -> pl
An unknown code falls back to ``default`` rather than raising, so this is
also the gate that decides which languages exist at all: a locale shipped
@@ -107,6 +108,8 @@ def _normalize_language(language: Any, default: str = "en") -> str:
return "de"
if s == "ukrainian" or base in {"uk", "ua"}:
return "uk"
+ if s in {"polish", "polski"} or base == "pl":
+ return "pl"
# Fall back to default
if isinstance(default, str):
diff --git a/tests/api/test_settings_router.py b/tests/api/test_settings_router.py
index b107cccc3..47de74287 100644
--- a/tests/api/test_settings_router.py
+++ b/tests/api/test_settings_router.py
@@ -76,7 +76,7 @@ async def test_ui_languages_are_persisted_independently(
@pytest.mark.asyncio
[email protected]("language", ["fr", "uk"])
[email protected]("language", ["fr", "uk", "pl"])
async def test_ui_settings_persist_supported_languages_independently(
monkeypatch: pytest.MonkeyPatch, tmp_path, language: str
) -> None:
diff --git a/tests/i18n/test_polish_locale.py b/tests/i18n/test_polish_locale.py
new file mode 100644
index 000000000..7c35633cc
--- /dev/null
+++ b/tests/i18n/test_polish_locale.py
@@ -0,0 +1,94 @@
+"""Polish UI locale integration tests."""
+
+from __future__ import annotations
+
+import json
+import pathlib
+import re
+
+import pytest
+
+from deeptutor.services.config.launch_settings import (
+ _normalize_language as _launch_language,
+)
+from deeptutor.services.config.settings_spec import _LANGUAGE_CHOICES
+from deeptutor.services.prompt.language import language_directive, language_label
+from deeptutor.services.settings.interface_settings import _normalize_language
+
+
+WEB = pathlib.Path(__file__).resolve().parents[2] / "web"
+
+
+def _catalog(locale: str) -> dict[str, str]:
+ return json.loads(
+ (WEB / f"locales/{locale}/app.json").read_text(encoding="utf-8")
+ )
+
+
+ "raw",
+ [
+ "pl",
+ "PL",
+ " pl ",
+ "polish",
+ "polski",
+ "pl-PL",
+ "pl_PL",
+ ],
+)
+def test_normalizer_accepts_polish_spellings(raw: str) -> None:
+ assert _normalize_language(raw) == "pl"
+
+
+def test_launch_settings_accept_polish() -> None:
+ assert _launch_language("pl-PL") == "pl"
+ assert _launch_language("polish") == "pl"
+ assert _launch_language("polski") == "pl"
+
+
+def test_settings_offers_polish() -> None:
+ assert "pl" in {code for code, _label, _desc in _LANGUAGE_CHOICES}
+
+
+def test_language_directive_names_polish() -> None:
+ assert language_label("pl") == "Polski"
+ assert "Polski" in language_directive("pl")
+
+
+def test_web_locale_covers_every_english_key() -> None:
+ en = _catalog("en")
+ pl = _catalog("pl")
+
+ assert set(en) <= set(pl)
+
+ extras = set(pl) - set(en)
+ assert all(key.endswith(("_few", "_many")) for key in extras)
+
+
+def test_web_locale_keeps_interpolation_placeholders() -> None:
+ en = _catalog("en")
+ pl = _catalog("pl")
+
+ pattern = re.compile(r"\{\{[^}]+\}\}")
+
+ mismatches = [
+ key
+ for key in set(en) & set(pl)
+ if set(pattern.findall(en[key])) != set(pattern.findall(pl[key]))
+ ]
+
+ assert mismatches == []
+
+
+def test_every_locale_can_name_polish() -> None:
+ for locale in ("en", "zh", "fr", "de", "uk", "pl"):
+ assert "language.polish" in _catalog(locale)
+
+
+def test_frontend_registers_polish() -> None:
+ languages = (WEB / "i18n/languages.ts").read_text(encoding="utf-8")
+ assert '{ code: "pl", labelKey: "language.polish" }' in languages
+
+ init = (WEB / "i18n/init.ts").read_text(encoding="utf-8")
+ assert "@/locales/pl/app.json" in init
diff --git a/tests/services/config/test_launch_settings.py b/tests/services/config/test_launch_settings.py
index 0f0a71e4e..2edbd9b32 100644
--- a/tests/services/config/test_launch_settings.py
+++ b/tests/services/config/test_launch_settings.py
@@ -52,6 +52,9 @@ def test_launch_settings_reads_ports_from_system_json_and_ignores_env_json(
("ukrainian", "uk"),
("uk_UA", "uk"),
("uk-UA", "uk"),
+ ("polish", "pl"),
+ ("polski", "pl"),
+ ("pl-PL", "pl"),
],
)
def test_launch_settings_reads_supported_languages_from_interface_json(
diff --git a/web/lib/datetime.ts b/web/lib/datetime.ts
index ce010b086..58f790903 100644
--- a/web/lib/datetime.ts
+++ b/web/lib/datetime.ts
@@ -7,6 +7,7 @@ export function getLocale(lang: Language): string {
if (lang === "fr") return "fr-FR";
if (lang === "de") return "de-DE";
if (lang === "uk") return "uk-UA";
+ if (lang === "pl") return "pl-PL";
return "en-US";
}
diff --git a/web/locales/pl/app.json b/web/locales/pl/app.json
index e91c12195..d19cacb2a 100644
--- a/web/locales/pl/app.json
+++ b/web/locales/pl/app.json
@@ -285,7 +285,7 @@
"System Status": "Status systemu",
"Home": "Strona główna",
"History": "Historia",
- "What would you like to learn?": "Co chciałbyś się dowiedzieć?",
+ "What would you like to learn?": "Czego chciałbyś się dowiedzieć?",
"Good morning.": "Dzień dobry.",
"Morning — let's learn something.": "Dzień dobry — nauczmy się czegoś.",
"Good afternoon.": "Dzień dobry.",
diff --git a/web/tests/account-role.test.ts b/web/tests/account-role.test.ts
index fffccddc7..942bedcd6 100644
--- a/web/tests/account-role.test.ts
+++ b/web/tests/account-role.test.ts
@@ -11,7 +11,7 @@ test("all account roles retain distinct display labels", () => {
assert.equal(accountRoleLabelKey("student"), "Student");
assert.equal(accountRoleLabelKey("user"), "User");
- for (const language of ["en", "zh", "de", "fr", "uk"]) {
+ for (const language of ["en", "zh", "de", "fr", "uk", "pl"]) {
const labels = JSON.parse(
readFileSync(path.resolve(process.cwd(), `locales/${language}/app.json`), "utf8"),
) as Record<string, string>;
diff --git a/web/tests/language-preferences.test.ts b/web/tests/language-preferences.test.ts
index ef8637aaf..5de569e54 100644
--- a/web/tests/language-preferences.test.ts
+++ b/web/tests/language-preferences.test.ts
@@ -7,12 +7,15 @@ import { resolveResponseLanguage } from "../context/app-shell-storage";
import { APP_LANGUAGES, isAppLanguage, normalizeLanguage } from "../i18n/languages";
test("the locale registry accepts every supported language", () => {
- assert.deepEqual(APP_LANGUAGES.map(({ code }) => code), ["en", "zh", "fr", "de", "uk"]);
+ assert.deepEqual(APP_LANGUAGES.map(({ code }) => code), ["en", "zh", "fr", "de", "uk", "pl"]);
for (const { code } of APP_LANGUAGES) assert.equal(isAppLanguage(code), true);
assert.equal(isAppLanguage("xx"), false);
assert.equal(normalizeLanguage("uk-UA"), "uk");
assert.equal(normalizeLanguage("fr-FR"), "fr");
assert.equal(normalizeLanguage("de-AT"), "de");
+ assert.equal(normalizeLanguage("pl-PL"), "pl");
+ assert.equal(normalizeLanguage("Polish"), "pl");
+ assert.equal(normalizeLanguage("Polski"), "pl");
});
test("response language remains independent from the interface language", () => {