Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

test: reproduce incomplete capability reported as completed

yepyhunf8fa061759b2
diff --git a/tests/runtime/test_orchestrator.py b/tests/runtime/test_orchestrator.py
index 2b88740eb..d04a3d12d 100644
--- a/tests/runtime/test_orchestrator.py
+++ b/tests/runtime/test_orchestrator.py
@@ -164,6 +164,52 @@ class TestOrchestratorRouting:
class TestOrchestratorErrorHandling:
+ @pytest.mark.asyncio
+ async def test_final_result_supersedes_intermediate_incomplete_result(self):
+ class RecoveredCapability:
+ async def run(self, _context, bus):
+ await bus.result({"completed": False}, source="chat")
+ await bus.tool_result("lookup", "retry succeeded", source="chat")
+ await bus.result({"completed": True}, source="chat")
+
+ orch = _make_orchestrator({"chat": RecoveredCapability()})
+ events = [e async for e in orch.handle(UnifiedContext(user_message="practice"))]
+ done = next(e for e in events if e.type == StreamEventType.DONE)
+ assert done.metadata["status"] == "completed"
+
+ @pytest.mark.asyncio
+ @pytest.mark.parametrize("completed", [False, True, None])
+ async def test_explicit_incomplete_result_controls_terminal_status(self, completed):
+ class ResultCapability:
+ async def run(self, _context, bus):
+ payload = {"response": "The requested operation was not delivered."}
+ if completed is not None:
+ payload["completed"] = completed
+ await bus.result(payload, source="chat")
+
+ orch = _make_orchestrator({"chat": ResultCapability()})
+ events = [e async for e in orch.handle(UnifiedContext(user_message="practice"))]
+ done = next(e for e in events if e.type == StreamEventType.DONE)
+ if completed is False:
+ assert done.metadata["status"] == "failed"
+ assert done.metadata["error_code"] == "capability_incomplete"
+ assert done.metadata["retryable"] is True
+ error = next(e for e in events if e.type == StreamEventType.ERROR)
+ assert error.metadata["turn_terminal"] is True
+ from deeptutor.services.session._turn_runtime_shared import (
+ _resolve_turn_failure_metadata,
+ _resolve_turn_outcome,
+ )
+ persisted = [
+ {"type": e.type.value, "content": e.content, "metadata": e.metadata}
+ for e in events if e is not done
+ ]
+ assert _resolve_turn_outcome(persisted, done)[0] == "failed"
+ assert _resolve_turn_failure_metadata(persisted) == ("capability_incomplete", True)
+ else:
+ assert done.metadata["status"] == "completed"
+ assert not any(e.type == StreamEventType.ERROR for e in events)
+
@pytest.mark.asyncio
async def test_capability_exception_yields_error_event(self) -> None:
fail_cap = _FailingCapability()