Skip to content

A Swiss Army knife for developers.

Addressed some warnings

Etienne Baudoux3525942a46dd
diff --git a/src/app/dev/DevToys.Api/Tool/GUI/Components/IUIButton.cs b/src/app/dev/DevToys.Api/Tool/GUI/Components/IUIButton.cs
index 1f0b52694..04e48c509 100644
--- a/src/app/dev/DevToys.Api/Tool/GUI/Components/IUIButton.cs
+++ b/src/app/dev/DevToys.Api/Tool/GUI/Components/IUIButton.cs
@@ -126,6 +126,9 @@ internal sealed class UIButton : UIElement, IUIButton
public event EventHandler? IconGlyphChanged;
}
+/// <summary>
+/// Provides a set of extension methods for various UI components.
+/// </summary>
public static partial class GUI
{
/// <summary>
diff --git a/src/app/dev/DevToys.Blazor/Components/Menu/NavBar/NavBar.razor.cs b/src/app/dev/DevToys.Blazor/Components/Menu/NavBar/NavBar.razor.cs
index ffd232736..2757f6683 100644
--- a/src/app/dev/DevToys.Blazor/Components/Menu/NavBar/NavBar.razor.cs
+++ b/src/app/dev/DevToys.Blazor/Components/Menu/NavBar/NavBar.razor.cs
@@ -232,6 +232,7 @@ public partial class NavBar<TElement, TSearchElement>
private Task OnBuildingContextMenuAsync(ListBoxItemBuildingContextMenuEventArgs args)
{
+ Guard.IsNotNull(args.ItemValue);
Guard.IsAssignableToType<TElement>(args.ItemValue);
return OnBuildingContextMenu.InvokeAsync(args);
}
diff --git a/src/app/dev/DevToys.Blazor/Components/UIElements/UIImageViewerPresenter.razor.cs b/src/app/dev/DevToys.Blazor/Components/UIElements/UIImageViewerPresenter.razor.cs
index 769eda943..941b86678 100644
--- a/src/app/dev/DevToys.Blazor/Components/UIElements/UIImageViewerPresenter.razor.cs
+++ b/src/app/dev/DevToys.Blazor/Components/UIElements/UIImageViewerPresenter.razor.cs
@@ -256,7 +256,7 @@ public partial class UIImageViewerPresenter : MefComponentBase
IsImageDisplayed = false;
// Swallow
}
- catch (Exception ex)
+ catch (Exception)
{
IsImageDisplayed = false;
// TODO: Log this. Also, maybe display a message to the user that the image cannot be displayed?
diff --git a/src/app/dev/DevToys.Blazor/Core/Services/FontService.cs b/src/app/dev/DevToys.Blazor/Core/Services/FontService.cs
index 89e682c4f..e139da3e6 100644
--- a/src/app/dev/DevToys.Blazor/Core/Services/FontService.cs
+++ b/src/app/dev/DevToys.Blazor/Core/Services/FontService.cs
@@ -9,8 +9,10 @@ public sealed partial class FontService
private readonly ILogger _logger;
private readonly IJSRuntime _jsRuntime;
+#pragma warning disable IDE0044 // Add readonly modifier
[ImportMany]
private IEnumerable<Lazy<IResourceAssemblyIdentifier, ResourceAssemblyIdentifierMetadata>> _resourceAssemblyIdentifiers = default!;
+#pragma warning restore IDE0044 // Add readonly modifier
public FontService(IMefProvider mefProvider, IJSRuntime jsRuntime)
{
diff --git a/src/app/dev/DevToys.Blazor/Pages/SubPages/ToolGroup.razor.cs b/src/app/dev/DevToys.Blazor/Pages/SubPages/ToolGroup.razor.cs
index 734082fc3..fdcbf5975 100644
--- a/src/app/dev/DevToys.Blazor/Pages/SubPages/ToolGroup.razor.cs
+++ b/src/app/dev/DevToys.Blazor/Pages/SubPages/ToolGroup.razor.cs
@@ -76,8 +76,10 @@ public partial class ToolGroup : MefComponentBase, IFocusable
CommandLineLauncherService.LaunchTool(item.InternalComponentName);
}
+#pragma warning disable CA1822 // Mark members as static
private void OnSuggestToolIdeaClick()
{
OSHelper.OpenFileInShell("https://github.com/veler/DevToys/issues/new/choose");
}
+#pragma warning restore CA1822 // Mark members as static
}