Skip to content

A Swiss Army knife for developers.

Cleanup

Etienne Baudoux37d5e182d1e4
diff --git a/src/app/dev/DevToys.Api/Tool/GUI/PredefinedCommonToolGroupNames.cs b/src/app/dev/DevToys.Api/Tool/GUI/PredefinedCommonToolGroupNames.cs
index e70a64000..885afef53 100644
--- a/src/app/dev/DevToys.Api/Tool/GUI/PredefinedCommonToolGroupNames.cs
+++ b/src/app/dev/DevToys.Api/Tool/GUI/PredefinedCommonToolGroupNames.cs
@@ -3,4 +3,5 @@
public static class PredefinedCommonToolGroupNames
{
public const string EncodersDecoders = "Encoders / Decoders";
+ public const string Converters = "Converters";
}
diff --git a/src/app/dev/DevToys.Core/Settings/ISettingsStorage.cs b/src/app/dev/DevToys.Core/Settings/ISettingsStorage.cs
index c69018a46..939cfbeb8 100644
--- a/src/app/dev/DevToys.Core/Settings/ISettingsStorage.cs
+++ b/src/app/dev/DevToys.Core/Settings/ISettingsStorage.cs
@@ -1,4 +1,6 @@
-namespace DevToys.Core.Settings;
+using System.Diagnostics.CodeAnalysis;
+
+namespace DevToys.Core.Settings;
/// <summary>
/// Provides a platform-specific way to store and read app settings.
@@ -13,7 +15,7 @@ public interface ISettingsStorage
/// <summary>
/// Reads an app setting.
/// </summary>
- bool TryReadSetting(string settingName, out object? value);
+ bool TryReadSetting(string settingName, [MaybeNullWhen(false)] out object? value);
/// <summary>
/// Deletes the given setting.
diff --git a/src/app/dev/DevToys.Tools/Tools/Converters/ConvertersGroup.cs b/src/app/dev/DevToys.Tools/Tools/Converters/ConvertersGroup.cs
index f60660c29..d14fa7ed5 100644
--- a/src/app/dev/DevToys.Tools/Tools/Converters/ConvertersGroup.cs
+++ b/src/app/dev/DevToys.Tools/Tools/Converters/ConvertersGroup.cs
@@ -1,7 +1,7 @@
namespace DevToys.Tools.Tools.Converters;
[Export(typeof(GuiToolGroup))]
-[Name("Converters")]
+[Name(PredefinedCommonToolGroupNames.Converters)]
internal class ConvertersGroup : GuiToolGroup
{
[ImportingConstructor]
diff --git a/src/app/dev/DevToys.Tools/Tools/Converters/JsonYaml/JsonYamlConverterGuiTool.cs b/src/app/dev/DevToys.Tools/Tools/Converters/JsonYaml/JsonYamlConverterGuiTool.cs
index fe42f5bdd..8bb3478ba 100644
--- a/src/app/dev/DevToys.Tools/Tools/Converters/JsonYaml/JsonYamlConverterGuiTool.cs
+++ b/src/app/dev/DevToys.Tools/Tools/Converters/JsonYaml/JsonYamlConverterGuiTool.cs
@@ -9,7 +9,7 @@ namespace DevToys.Tools.Tools.Converters.JsonYaml;
[ToolDisplayInformation(
IconFontName = "DevToys-Tools-Icons",
IconGlyph = '\u0109',
- GroupName = "Converters",
+ GroupName = PredefinedCommonToolGroupNames.Converters,
ResourceManagerAssemblyIdentifier = nameof(DevToysToolsResourceManagerAssemblyIdentifier),
ResourceManagerBaseName = "DevToys.Tools.Tools.Converters.JsonYaml.JsonYamlConverter",
ShortDisplayTitleResourceName = nameof(JsonYamlConverter.ShortDisplayTitle),
diff --git a/src/app/dev/DevToys.Tools/Tools/EncodersDecoders/GZip/GZipEncoderDecoderGuiTool.cs b/src/app/dev/DevToys.Tools/Tools/EncodersDecoders/GZip/GZipEncoderDecoderGuiTool.cs
index a4b527300..7dc91333d 100644
--- a/src/app/dev/DevToys.Tools/Tools/EncodersDecoders/GZip/GZipEncoderDecoderGuiTool.cs
+++ b/src/app/dev/DevToys.Tools/Tools/EncodersDecoders/GZip/GZipEncoderDecoderGuiTool.cs
@@ -1,7 +1,5 @@
using System.IO.Compression;
using DevToys.Tools.Helpers;
-using DevToys.Tools.Models;
-using DevToys.Tools.Tools.EncodersDecoders.Base64Text;
using Microsoft.Extensions.Logging;
namespace DevToys.Tools.Tools.EncodersDecoders.GZip;
diff --git a/src/app/dev/DevToys.Tools/Tools/EncodersDecoders/Url/UrlEncoderDecoderGuiTool.cs b/src/app/dev/DevToys.Tools/Tools/EncodersDecoders/Url/UrlEncoderDecoderGuiTool.cs
index 02c419a30..661645fcc 100644
--- a/src/app/dev/DevToys.Tools/Tools/EncodersDecoders/Url/UrlEncoderDecoderGuiTool.cs
+++ b/src/app/dev/DevToys.Tools/Tools/EncodersDecoders/Url/UrlEncoderDecoderGuiTool.cs
@@ -1,5 +1,4 @@
-using DevToys.Api;
-using DevToys.Tools.Helpers;
+using DevToys.Tools.Helpers;
using DevToys.Tools.Models;
using Microsoft.Extensions.Logging;
diff --git a/src/app/tests/DevToys.UnitTests/Mocks/Tools/MockDataTypeDetector.cs b/src/app/tests/DevToys.UnitTests/Mocks/Tools/MockDataTypeDetector.cs
index 4fe40b444..1cbc2c7c7 100644
--- a/src/app/tests/DevToys.UnitTests/Mocks/Tools/MockDataTypeDetector.cs
+++ b/src/app/tests/DevToys.UnitTests/Mocks/Tools/MockDataTypeDetector.cs
@@ -1,5 +1,4 @@
using System.ComponentModel.Composition;
-using System.Text.Json;
using System.Threading;
using System.Threading.Tasks;
using DevToys.Tools.Helpers;
diff --git a/src/app/tests/DevToys.UnitTests/Tools/Converters/JsonYamlConverterCommandLineToolTests.cs b/src/app/tests/DevToys.UnitTests/Tools/Converters/JsonYamlConverterCommandLineToolTests.cs
index ea6f07ddd..43a60ed8b 100644
--- a/src/app/tests/DevToys.UnitTests/Tools/Converters/JsonYamlConverterCommandLineToolTests.cs
+++ b/src/app/tests/DevToys.UnitTests/Tools/Converters/JsonYamlConverterCommandLineToolTests.cs
@@ -1,10 +1,8 @@
-using System.Globalization;
-using System.IO;
+using System.IO;
using System.Threading.Tasks;
using DevToys.CLI;
using DevToys.Tools.Models;
using DevToys.Tools.Tools.Converters.JsonYaml;
-using Microsoft.AspNetCore.Components.Forms;
using Microsoft.Extensions.Logging;
namespace DevToys.UnitTests.Tools.Converters;
diff --git a/src/build/AppVersion/VersionString.cs b/src/build/AppVersion/VersionString.cs
index 6013af510..a9e3b50f1 100644
--- a/src/build/AppVersion/VersionString.cs
+++ b/src/build/AppVersion/VersionString.cs
@@ -1,4 +1,5 @@
using System;
+using System.Diagnostics.CodeAnalysis;
using System.Text.RegularExpressions;
internal sealed class VersionString
@@ -34,7 +35,7 @@ internal sealed class VersionString
return match.Success;
}
- public static bool TryParse(string input, out VersionString? version)
+ public static bool TryParse(string input, [MaybeNullWhen(false)] out VersionString? version)
{
var temp = new VersionString();
version = null;