Skip to content

A Swiss Army knife for developers.

Fixed bug in Pin tool to Start where false negative would trigger

Etienne Baudoux3d90b15a85cd
diff --git a/src/dev/impl/DevToys/Api/Core/IUriActivationProtocolService.cs b/src/dev/impl/DevToys/Api/Core/IUriActivationProtocolService.cs
index d4b09168c..5e8255353 100644
--- a/src/dev/impl/DevToys/Api/Core/IUriActivationProtocolService.cs
+++ b/src/dev/impl/DevToys/Api/Core/IUriActivationProtocolService.cs
@@ -20,7 +20,8 @@ namespace DevToys.Api.Core
/// Creates a tile on the Windows start menu that points to a given tool.
/// </summary>
/// <param name="toolProvider">The tool to pin</param>
- /// <returns>Returns <code>True</code> if it succeeded.</returns>
+ /// <returns>Returns <code>False</code> if the method internally failed.
+ /// It will still return <code>True</code> if the user refuse to proceed when being prompt for pinning.</returns>
Task<bool> PinToolToStart(MatchedToolProvider toolProvider);
}
}
diff --git a/src/dev/impl/DevToys/Core/UriActivationProtocolService.cs b/src/dev/impl/DevToys/Core/UriActivationProtocolService.cs
index 292264672..c37873d0a 100644
--- a/src/dev/impl/DevToys/Core/UriActivationProtocolService.cs
+++ b/src/dev/impl/DevToys/Core/UriActivationProtocolService.cs
@@ -132,14 +132,15 @@ namespace DevToys.Core
tile.VisualElements.Square44x44Logo = new Uri($"ms-appdata:///local/{toolProvider.Metadata.ProtocolName}/{square44IconName}.png");
tile.VisualElements.Square71x71Logo = new Uri($"ms-appdata:///local/{toolProvider.Metadata.ProtocolName}/{smallTileIconName}.png");
- return await tile.RequestCreateForSelectionAsync(Window.Current.Bounds);
+ await tile.RequestCreateForSelectionAsync(Window.Current.Bounds);
}
catch (Exception ex)
{
Logger.LogFault("Pin to start", ex);
+ return false;
}
- return false;
+ return true;
}
private string GenerateLaunchArguments(string? toolProtocol)