Skip to content

A Swiss Army knife for developers.

JSON Formatter was not sorting array values. (#610)

Etienne Baudoux78ad3ec50e30
diff --git a/src/dev/impl/DevToys/Helpers/JsonYaml/JsonHelper.cs b/src/dev/impl/DevToys/Helpers/JsonYaml/JsonHelper.cs
index 2458e87b1..d4de4ebc3 100644
--- a/src/dev/impl/DevToys/Helpers/JsonYaml/JsonHelper.cs
+++ b/src/dev/impl/DevToys/Helpers/JsonYaml/JsonHelper.cs
@@ -213,6 +213,16 @@ namespace DevToys.Helpers.JsonYaml
{
SortJsonPropertiesAlphabetically(obj);
}
+ else if (property.Value is JArray array)
+ {
+ foreach (JToken? arrayItem in array)
+ {
+ if (arrayItem is JObject arrayObj)
+ {
+ SortJsonPropertiesAlphabetically(arrayObj);
+ }
+ }
+ }
}
}
}
diff --git a/src/tests/DevToys.Tests/Helpers/JsonHelperTests.cs b/src/tests/DevToys.Tests/Helpers/JsonHelperTests.cs
index 1ec66633c..cfb119300 100644
--- a/src/tests/DevToys.Tests/Helpers/JsonHelperTests.cs
+++ b/src/tests/DevToys.Tests/Helpers/JsonHelperTests.cs
@@ -73,7 +73,9 @@ namespace DevToys.Tests.Helpers
}
[DataTestMethod]
- [DataRow("{\"Email\":\"[email protected]\",\"Website\":\"http://samplewebsite.com\",\"Name\":\"John Smith\",\"Phone\":\"(50)345872\"}", "{\"Email\":\"[email protected]\",\"Name\":\"John Smith\",\"Phone\":\"(50)345872\",\"Website\":\"http://samplewebsite.com\"}")]
+ [DataRow(
+ "{\"a\": \"asdf\", \"c\" : 545, \"b\": 33, \"array\": [{\"a\": \"asdf\", \"c\" : 545, \"b\": 33, \"array\": []}]}",
+ "{\"a\":\"asdf\",\"array\":[{\"a\":\"asdf\",\"array\":[],\"b\":33,\"c\":545}],\"b\":33,\"c\":545}")]
public void FormatSortPropertiesAlphabetically(string input, string expectedResult)
{
Assert.AreEqual(expectedResult, JsonHelper.Format(input, Indentation.Minified, sortProperties: true));