Skip to content

A Swiss Army knife for developers.

[Base64 Image] Click on save or view while no input made the app crashing (#529)

Etienne Baudoux829307b36a59
diff --git a/src/dev/impl/DevToys/UI/Controls/ImagePreview.xaml b/src/dev/impl/DevToys/UI/Controls/ImagePreview.xaml
index f6ff4c092..6f0ad4c6e 100644
--- a/src/dev/impl/DevToys/UI/Controls/ImagePreview.xaml
+++ b/src/dev/impl/DevToys/UI/Controls/ImagePreview.xaml
@@ -1,15 +1,17 @@
<UserControl
x:Class="DevToys.UI.Controls.ImagePreview"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
- xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
+ xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
- xmlns:controls="using:Microsoft.UI.Xaml.Controls"
+ xmlns:converters="using:DevToys.UI.Converters"
mc:Ignorable="d"
d:DesignHeight="300"
d:DesignWidth="400"
SizeChanged="UserControl_SizeChanged">
<UserControl.Resources>
+ <converters:NullToVisibilityConverter x:Key="NonNullToVisibilityConverter" IsInverted="True"/>
+
<Style x:Key="CardStyle" TargetType="Grid">
<Setter Property="BorderBrush" Value="{ThemeResource ExpanderHeaderBorderBrush}" />
<Setter Property="BorderThickness" Value="{ThemeResource ExpanderHeaderBorderThickness}" />
@@ -49,6 +51,7 @@
AutomationProperties.LabeledBy="{Binding ElementName=HeaderTextBlock}">
<Button
AutomationProperties.Name="View"
+ Visibility="{x:Bind Source, Mode=OneWay, Converter={StaticResource NonNullToVisibilityConverter}}"
Click="ViewButton_Click">
<StackPanel Orientation="Horizontal" Spacing="4">
<FontIcon Glyph="&#xF3FB;"/>
@@ -58,12 +61,14 @@
<Button
ToolTipService.ToolTip="{Binding Instance.Common.Copy, Mode=OneTime, Source={StaticResource LanguageManager}}"
AutomationProperties.Name="{Binding Instance.Common.Copy, Mode=OneTime, Source={StaticResource LanguageManager}}"
+ Visibility="{x:Bind Source, Mode=OneWay, Converter={StaticResource NonNullToVisibilityConverter}}"
Click="CopyButton_Click">
<FontIcon Glyph="&#xF32B;"/>
</Button>
<Button
ToolTipService.ToolTip="{Binding Instance.Common.SaveAs, Mode=OneTime, Source={StaticResource LanguageManager}}"
AutomationProperties.Name="{Binding Instance.Common.SaveAs, Mode=OneTime, Source={StaticResource LanguageManager}}"
+ Visibility="{x:Bind Source, Mode=OneWay, Converter={StaticResource NonNullToVisibilityConverter}}"
Click="SaveAsButton_Click">
<FontIcon Glyph="&#xF67F;"/>
</Button>