Skip to content

A Swiss Army knife for developers.

Bugfix for OpenClipboard Failed Exception (#335)

R. de Veenfbe687977496
diff --git a/src/dev/impl/DevToys/UI/Controls/CustomTextBox.xaml.cs b/src/dev/impl/DevToys/UI/Controls/CustomTextBox.xaml.cs
index 3042303b2..0884bec28 100644
--- a/src/dev/impl/DevToys/UI/Controls/CustomTextBox.xaml.cs
+++ b/src/dev/impl/DevToys/UI/Controls/CustomTextBox.xaml.cs
@@ -143,8 +143,15 @@ namespace DevToys.UI.Controls
private void ExecuteCutCommand()
{
- RichEditBox.TextDocument.Selection.Cut();
- Clipboard.Flush();
+ try
+ {
+ RichEditBox.TextDocument.Selection.Cut();
+ Clipboard.Flush();
+ }
+ catch (Exception ex)
+ {
+ Logger.LogFault("Failed to cut from custom text box", ex);
+ }
}
#endregion
@@ -160,8 +167,15 @@ namespace DevToys.UI.Controls
private void ExecuteCopyCommand()
{
- RichEditBox.TextDocument.Selection.Copy();
- Clipboard.Flush();
+ try
+ {
+ RichEditBox.TextDocument.Selection.Copy();
+ Clipboard.Flush();
+ }
+ catch (Exception ex)
+ {
+ Logger.LogFault("Failed to copy from custom text box", ex);
+ }
}
#endregion
@@ -441,19 +455,33 @@ namespace DevToys.UI.Controls
private void CopyTextBoxSelectionToClipboard()
{
- var dataPackage = new DataPackage { RequestedOperation = DataPackageOperation.Copy };
- dataPackage.SetText(TextBox.SelectedText);
- Clipboard.SetContentWithOptions(dataPackage, new ClipboardContentOptions() { IsAllowedInHistory = true, IsRoamable = true });
- Clipboard.Flush(); // This method allows the content to remain available after the application shuts down.
+ try
+ {
+ var dataPackage = new DataPackage { RequestedOperation = DataPackageOperation.Copy };
+ dataPackage.SetText(TextBox.SelectedText);
+ Clipboard.SetContentWithOptions(dataPackage, new ClipboardContentOptions() { IsAllowedInHistory = true, IsRoamable = true });
+ Clipboard.Flush(); // This method allows the content to remain available after the application shuts down.
+ }
+ catch (Exception ex)
+ {
+ Logger.LogFault("Failed to copy from custom text box", ex);
+ }
}
private void CopyRichEditBoxSelectionToClipboard()
{
- RichEditBox.Document.Selection.GetText(TextGetOptions.UseCrlf, out string? text);
- var dataPackage = new DataPackage { RequestedOperation = DataPackageOperation.Copy };
- dataPackage.SetText(text);
- Clipboard.SetContentWithOptions(dataPackage, new ClipboardContentOptions() { IsAllowedInHistory = true, IsRoamable = true });
- Clipboard.Flush(); // This method allows the content to remain available after the application shuts down.
+ try
+ {
+ RichEditBox.Document.Selection.GetText(TextGetOptions.UseCrlf, out string? text);
+ var dataPackage = new DataPackage { RequestedOperation = DataPackageOperation.Copy };
+ dataPackage.SetText(text);
+ Clipboard.SetContentWithOptions(dataPackage, new ClipboardContentOptions() { IsAllowedInHistory = true, IsRoamable = true });
+ Clipboard.Flush(); // This method allows the content to remain available after the application shuts down.
+ }
+ catch (Exception ex)
+ {
+ Logger.LogFault("Failed to copy from custom text box", ex);
+ }
}
private void OnLoaded(object sender, RoutedEventArgs e)
diff --git a/src/dev/impl/DevToys/ViewModels/Tools/Settings/SettingsToolViewModel.cs b/src/dev/impl/DevToys/ViewModels/Tools/Settings/SettingsToolViewModel.cs
index 168bf9dff..997ca4913 100644
--- a/src/dev/impl/DevToys/ViewModels/Tools/Settings/SettingsToolViewModel.cs
+++ b/src/dev/impl/DevToys/ViewModels/Tools/Settings/SettingsToolViewModel.cs
@@ -139,14 +139,21 @@ namespace DevToys.ViewModels.Settings
private void ExecuteCopyVersionCommand()
{
- var data = new DataPackage
+ try
{
- RequestedOperation = DataPackageOperation.Copy
- };
- data.SetText(Version);
-
- Clipboard.SetContentWithOptions(data, new ClipboardContentOptions() { IsAllowedInHistory = true, IsRoamable = true });
- Clipboard.Flush();
+ var data = new DataPackage
+ {
+ RequestedOperation = DataPackageOperation.Copy
+ };
+ data.SetText(Version);
+
+ Clipboard.SetContentWithOptions(data, new ClipboardContentOptions() { IsAllowedInHistory = true, IsRoamable = true });
+ Clipboard.Flush();
+ }
+ catch (Exception ex)
+ {
+ Logger.LogFault($"Failed to copy data from copy version command, version: ${Version}", ex);
+ }
}
#endregion
diff --git a/src/dev/impl/DevToys/Views/Tools/Graphic/ColorBlindnessSimulator/ImagePreview.xaml.cs b/src/dev/impl/DevToys/Views/Tools/Graphic/ColorBlindnessSimulator/ImagePreview.xaml.cs
index 2557674fb..644288868 100644
--- a/src/dev/impl/DevToys/Views/Tools/Graphic/ColorBlindnessSimulator/ImagePreview.xaml.cs
+++ b/src/dev/impl/DevToys/Views/Tools/Graphic/ColorBlindnessSimulator/ImagePreview.xaml.cs
@@ -98,10 +98,18 @@ namespace DevToys.Views.Tools.ColorBlindnessSimulator
private async void CopyButton_Click(object sender, RoutedEventArgs e)
{
- var dataPackage = new DataPackage { RequestedOperation = DataPackageOperation.Copy };
- dataPackage.SetBitmap(RandomAccessStreamReference.CreateFromFile(await StorageFile.GetFileFromPathAsync(Source!.OriginalString)));
- Clipboard.SetContentWithOptions(dataPackage, new ClipboardContentOptions() { IsAllowedInHistory = true, IsRoamable = true });
- Clipboard.Flush(); // This method allows the content to remain available after the application shuts down.
+ try
+ {
+ var dataPackage = new DataPackage { RequestedOperation = DataPackageOperation.Copy };
+ dataPackage.SetBitmap(RandomAccessStreamReference.CreateFromFile(await StorageFile.GetFileFromPathAsync(Source!.OriginalString)));
+
+ Clipboard.SetContentWithOptions(dataPackage, new ClipboardContentOptions() { IsAllowedInHistory = true, IsRoamable = true });
+ Clipboard.Flush(); // This method allows the content to remain available after the application shuts down.
+ }
+ catch (Exception ex)
+ {
+ Core.Logger.LogFault("Failed to copy from image preview", ex);
+ }
}
private async void SaveAsButton_Click(object sender, RoutedEventArgs e)