Skip to content

Dodaios is an open-source agent OS for your desktop: it runs your coding agents, browser and apps by voice or chat, on your own machine. Formerly Personal Jarvis.

feat(appshot): no gold border before an appshot, the flash is the signal

rubenluetke10-beep2b27b5d4f374
diff --git a/docs/appshots.md b/docs/appshots.md
index cc5e7c3e77..9f5b534754 100644
--- a/docs/appshots.md
+++ b/docs/appshots.md
@@ -37,8 +37,9 @@ the shutter and shows up as the last appshot.
Appshots capture through the Screen Context engine
([screen-context.md](screen-context.md)), so everything there applies
unchanged: the app denylist, redaction of password fields and sensitive
-patterns, the capture indicator before the shutter, and no image ever written
-to disk. **Allow appshots** on the Appshots page is `[screen_context].enabled`
+patterns, and no image ever written to disk. The one difference: an appshot
+shows no gold border before the shutter — the flash over the captured window
+is the visible signal (maintainer directive 2026-09-29). **Allow appshots** on the Appshots page is `[screen_context].enabled`
— one switch for every screen look.
The shutter effect's thumbnail is cut from the frame in memory and piped only
diff --git a/docs/screen-context.md b/docs/screen-context.md
index 595fbc3b39..5666860404 100644
--- a/docs/screen-context.md
+++ b/docs/screen-context.md
@@ -17,6 +17,10 @@ platform through the same adapter seam.
> deliver it to a running voice call or the next message. See
> [appshots.md](appshots.md). The Settings card described in Wave 4 moved
> onto the Appshots page as **Allow appshots**.
+> Since then the shared service shows no pre-shutter border: the appshot
+> flash right after the grab is the on-screen signal (maintainer directive
+> 2026-09-29), so the "indicator precedes the shutter" rule below applies
+> only to services built without a shutter hook.
When the user says something that unambiguously asks Jarvis to *look* — "can you
see this?", "what does that say?", "look at the error" — Jarvis takes **one**
diff --git a/jarvis/cu/indicator/controller.py b/jarvis/cu/indicator/controller.py
index 41ebef2343..fba9ea7031 100644
--- a/jarvis/cu/indicator/controller.py
+++ b/jarvis/cu/indicator/controller.py
@@ -243,6 +243,7 @@ class CUIndicatorController:
await self._quit_sidecar()
async def _quit_sidecar(self) -> None:
+ capture_guard.unregister_hook()
if self._proc is None:
return
await asyncio.to_thread(
@@ -276,6 +277,9 @@ class CUIndicatorController:
await asyncio.to_thread(self._spawn_sidecar)
if self._proc is None:
return False
+ # Without a border there was no guard yet: a later capture must
+ # blank the resting thumbnail before its grab on every OS.
+ capture_guard.register_hook(self._suppress_for_grab)
shown = await asyncio.to_thread(
self._send_and_wait,
protocol.CMD_SNAP,
diff --git a/jarvis/screen_context/service.py b/jarvis/screen_context/service.py
index eeb9570b11..4f1b1a3af3 100644
--- a/jarvis/screen_context/service.py
+++ b/jarvis/screen_context/service.py
@@ -272,6 +272,11 @@ class ScreenContextService:
loop, before redaction. It exists for the appshot effect, which must
start at the true shutter moment; the hook stays in-process and must
schedule anything slow itself. Its failures never affect the capture.
+
+ A service with a shutter hook shows no pre-shutter border: the appshot
+ flash over the captured window is the visible signal instead
+ (maintainer directive 2026-09-29 — the gold frame before every appshot
+ read as an ugly glitch).
"""
self._shutter_hook = hook
@@ -475,8 +480,10 @@ class ScreenContextService:
# Announce BEFORE the shutter so the indicator is up while there is
# still something to indicate.
event_trace_id = trace_id or uuid4()
- announced = await self._announce(target, trace_id=event_trace_id)
- if not announced:
+ # The appshot flash replaces the border (see ``set_shutter_hook``).
+ border = self._shutter_hook is None
+ announced = await self._announce(target, trace_id=event_trace_id) if border else False
+ if border and not announced:
degradations.append(
Degradation(
code=DegradationCode.INDICATOR_UNAVAILABLE,
@@ -486,7 +493,7 @@ class ScreenContextService:
),
)
)
- else:
+ elif announced:
# Give the composited border a perceptible pre-shutter moment. The
# renderer ACK proves it was processed; this short dwell makes the
# privacy signal human-visible rather than a one-frame flicker.
@@ -622,7 +629,8 @@ class ScreenContextService:
handle_id=handle_id,
)
finally:
- await self._dismiss_indicator(trace_id=event_trace_id)
+ if border:
+ await self._dismiss_indicator(trace_id=event_trace_id)
async def _grab(self, target: CaptureTarget) -> tuple[tuple[int, int], bytes]:
"""Grab the target; rescue a window capture that came back empty.
diff --git a/tests/unit/screen_context/test_blank_window_capture.py b/tests/unit/screen_context/test_blank_window_capture.py
index e2b696d740..b7f341cc6f 100644
--- a/tests/unit/screen_context/test_blank_window_capture.py
+++ b/tests/unit/screen_context/test_blank_window_capture.py
@@ -82,3 +82,21 @@ async def test_a_window_with_content_is_used_as_captured() -> None:
assert outcome.status == "captured"
assert len(capturer.grabs) == 1
+
+
+async def test_an_appshot_service_shows_no_border_and_claims_no_missing_signal() -> None:
+ from .test_service import RecordingBus
+
+ bus = RecordingBus()
+ shutters: list = []
+ service = make_service(capturer=BlankWindowCapturer(), bus=bus)
+ service.set_shutter_hook(lambda *args: shutters.append(args))
+
+ outcome = await service.capture(verdict=WINDOW)
+
+ assert outcome.status == "captured"
+ assert len(shutters) == 1, "the flash is the visible signal"
+ names = [type(event).__name__ for event in bus.events]
+ assert "ScreenCaptureAnnounced" not in names, "no gold border before an appshot"
+ assert "ScreenCaptureIndicatorDismissed" not in names
+ assert all(d.code.value != "indicator_unavailable" for d in outcome.context.degradations)