Dodaios is an open-source agent OS for your desktop: it runs your coding agents, browser and apps by voice or chat, on your own machine. Formerly Personal Jarvis.
Python agent-orchestrationai-agentai-coding-assistantclaude-codecoding-agentcomputer-usedesktop-applocal-firstmcppersonal-jarvisvoice-assistantvoice-coding
fix(vision): lead screenshot turns with the router model, not chat primary
rubenluetke10-beep2c1a5dd29a2f
diff --git a/jarvis/brain/manager.py b/jarvis/brain/manager.pyindex e483a2ceb5..504de372a9 100644--- a/jarvis/brain/manager.py+++ b/jarvis/brain/manager.py@@ -3405,36 +3405,49 @@ class BrainManager:def _lead_vision_chain(self, chain: list[tuple[str, str | None]]) -> list[tuple[str, str | None]]:- """On an image turn, put a live vision FAST model first.+ """On an image turn, put the router vision FAST model first.Live 2026-08-31 17:06: a realtime screenshot delegated through``prefer_tool_model`` led with Vertex ``gemini-3.7-flash`` (the Tool- Model). Five providers then failed — Gemini schema, OpenRouter 402,- Claude 401, Gemini schema again, OpenAI 429 retries — and grok-4.6- answered after 20 s. The router already has a fast vision model- (grok-4.20 non-reasoning). A look turn must not walk the Tool-Model- chain first.+ Model). Five providers then failed and grok-4.6 answered after 20 s.++ Live 2026-08-31 19:38: the first cut ranked by ``_active_name``+ (chat primary ``openrouter``). OpenRouter 402'd in 0.3 s, then+ Vertex ``gemini-3-flash-preview`` sat 20.5 s. Grok never ran. The+ router already names the look model (``[brain.router]``). Rank by+ that config, not the chat primary — AP-21: never hardcode a+ provider name, never treat a broke primary as a vision ranking+ signal."""if not chain:return chain- active = self._active_name+ router = getattr(getattr(self._config, "brain", None), "router", None)+ router_provider = (+ getattr(router, "provider", None) if router is not None else None+ )vision: list[tuple[str, str | None]] = []rest: list[tuple[str, str | None]] = []seen: set[str] = set()- for provider, model in chain:- if provider in seen:- continue++ def _consider(provider: str, model: str | None) -> None:+ if provider in seen or provider in self._dead_providers:+ returnseen.add(provider)pick_model = self._vision_look_model(provider) or modelif self._provider_advertises_vision(provider, pick_model):vision.append((provider, pick_model))else:rest.append((provider, model))++ # Router first (from config), then the rest of the chain. The chat+ # primary is not a ranking signal — it may be a billed-out slot.+ if isinstance(router_provider, str) and router_provider:+ _consider(router_provider, None)+ for provider, model in chain:+ _consider(provider, model)if not vision:return chain- preferred = [item for item in vision if item[0] == active]- others = [item for item in vision if item[0] != active]- led = preferred + others + rest+ led = vision + restlog.info("screen-turn vision lead: %s(%s) — %d vision-capable, %d others",led[0][0],diff --git a/tests/unit/brain/test_vision_lead_chain.py b/tests/unit/brain/test_vision_lead_chain.pyindex 4d1d10a0b9..8a00c68930 100644--- a/tests/unit/brain/test_vision_lead_chain.py+++ b/tests/unit/brain/test_vision_lead_chain.py@@ -64,6 +64,37 @@ def test_image_turn_leads_with_the_router_vision_model() -> None:assert led[0] == ("grok", "grok-4.20-0309-non-reasoning")+def test_chat_primary_does_not_outrank_the_router() -> None:+ """Live 2026-08-31 19:38: primary=openrouter, router=grok.++ Ranking by ``_active_name`` put OpenRouter first (402, no credits),+ then Vertex sat 20.5 s. The router vision model must still lead.+ """+ m = _mgr(active="openrouter")+ chain = [+ ("openrouter", "google/gemini-3.5-flash"),+ ("vertex", "gemini-3.7-flash"),+ ("grok", "grok-4.6"),+ ]+ led = m._lead_vision_chain(chain)+ assert led[0] == ("grok", "grok-4.20-0309-non-reasoning")+ assert led[1][0] != "grok"+++def test_dead_providers_are_dropped_from_the_look_chain() -> None:+ m = _mgr(active="openrouter")+ m._dead_providers.add("openrouter")+ led = m._lead_vision_chain(+ [+ ("openrouter", "google/gemini-3.5-flash"),+ ("vertex", "gemini-3.7-flash"),+ ("grok", "grok-4.6"),+ ]+ )+ assert led[0] == ("grok", "grok-4.20-0309-non-reasoning")+ assert all(item[0] != "openrouter" for item in led)++def test_blind_providers_stay_in_the_tail() -> None:m = _mgr(active="codex")led = m._lead_vision_chain([("codex", "gpt-5.5"), ("grok", "grok-4.6")])