Skip to content

Dodaios is an open-source agent OS for your desktop: it runs your coding agents, browser and apps by voice or chat, on your own machine. Formerly Personal Jarvis.

fix(ci): keep German-looking logins in the avatar wall from tripping the language gate (#935)

Ruben Lütke2ccb593ee178
diff --git a/scripts/ci/update_contributors.py b/scripts/ci/update_contributors.py
index 4ed5126938..4af6d48b2c 100644
--- a/scripts/ci/update_contributors.py
+++ b/scripts/ci/update_contributors.py
@@ -52,6 +52,9 @@ EXCLUDED_LOGINS = frozenset({"claude"})
PER_ROW = 10
AVATAR_PX = 48
+#: Inline marker that scripts/ci/check_no_new_german.py skips.
+LANGUAGE_GATE_ESCAPE = "i18n-allow"
+
def fetch_contributors() -> list[dict]:
"""Every human contributor, most commits first."""
@@ -103,7 +106,12 @@ def render(people: list[dict]) -> str:
f'width="{AVATAR_PX}" height="{AVATAR_PX}" alt="{p["login"]}"></a>'
for p in people
]
- rows = [" ".join(cells[i : i + PER_ROW]) for i in range(0, len(cells), PER_ROW)]
+ # GitHub logins are names, not prose: a login made of German words must not
+ # trip the output-language gate, so every row carries its escape marker.
+ rows = [
+ " ".join(cells[i : i + PER_ROW]) + f" <!-- {LANGUAGE_GATE_ESCAPE} -->"
+ for i in range(0, len(cells), PER_ROW)
+ ]
return "\n".join(rows)
diff --git a/tests/unit/ci/test_update_contributors_language_gate.py b/tests/unit/ci/test_update_contributors_language_gate.py
new file mode 100644
index 0000000000..59c9892a8f
--- /dev/null
+++ b/tests/unit/ci/test_update_contributors_language_gate.py
@@ -0,0 +1,45 @@
+"""The contributor avatar wall must never trip the output-language gate."""
+
+from __future__ import annotations
+
+import importlib.util
+from pathlib import Path
+
+REPO_ROOT = Path(__file__).resolve().parents[3]
+
+
+def _load(name: str, path: Path):
+ spec = importlib.util.spec_from_file_location(name, path)
+ assert spec is not None and spec.loader is not None
+ module = importlib.util.module_from_spec(spec)
+ spec.loader.exec_module(module)
+ return module
+
+
+update_contributors = _load(
+ "update_contributors_under_test", REPO_ROOT / "scripts" / "ci" / "update_contributors.py"
+)
+check_no_new_german = _load(
+ "check_no_new_german_under_test", REPO_ROOT / "scripts" / "ci" / "check_no_new_german.py"
+)
+
+
+def _person(login: str) -> dict:
+ return {"login": login, "avatar_url": f"https://avatars.example/{login}?v=4"}
+
+
+def test_german_looking_login_passes_the_language_gate() -> None:
+ # A real contributor login that reads as German.
+ logins = ["dannyward630", "ANO3457", "Idee-Wird-App", "Uddoo"] # i18n-allow
+ block = update_contributors.render([_person(login) for login in logins])
+
+ added = [("README.md", n, line) for n, line in enumerate(block.splitlines(), start=1)]
+ assert check_no_new_german.find_violations(added, []) == []
+
+
+def test_every_row_carries_the_escape_marker() -> None:
+ people = [_person(f"user{i}") for i in range(update_contributors.PER_ROW * 2 + 1)]
+ rows = update_contributors.render(people).splitlines()
+
+ assert len(rows) == 3
+ assert all(row.endswith("<!-- i18n-allow -->") for row in rows)