Dodaios is an open-source agent OS for your desktop: it runs your coding agents, browser and apps by voice or chat, on your own machine. Formerly Personal Jarvis.
Python agent-orchestrationai-agentai-coding-assistantclaude-codecoding-agentcomputer-usedesktop-applocal-firstmcppersonal-jarvisvoice-assistantvoice-coding
fix(marketplace): keep unverified Shopify connector as draft
rubenluetke10-beep336221543e56
diff --git a/docs/marketplace/plugin-auth-audit.md b/docs/marketplace/plugin-auth-audit.mdindex 1f89352282..c98ff3ef32 100644--- a/docs/marketplace/plugin-auth-audit.md+++ b/docs/marketplace/plugin-auth-audit.md@@ -16,7 +16,7 @@ The real runtime was exercised on Windows. Linux/macOS behavior and clean instal“Not verified” and “Not run” are BLOCKED stages, never implied successes. Each blocker names its owner and next action. The machine-readable artifact records all seven stages: UI, browser, callback, connected, smoke, reconnect and restart. Restart is unverified for all 46 plugins.-Shopify (added 2026-09-21, after the RUB-94 observation) has one observed UI attempt: the card renders and Connect was clicked, but the initial DCR configuration failed before any browser page opened. Its row records the corrected browser-primary configuration and the pending publisher/app journey. The historical counts above still describe the 2026-09-12 observation.+Shopify (added 2026-09-21, after the RUB-94 observation) has one observed UI attempt: the card rendered and Connect was clicked, but the initial DCR configuration failed before any browser page opened. It is temporarily absent from the shipped seed catalog because no publisher-shared OAuth app or completed browser journey exists. The connector manifest remains in source, and its blocked observation is archived in [shopify-pending-e2e.json](shopify-pending-e2e.json). Restore the built-in only after provisioning the shared app and recording a clean PASS for UI, browser, callback, connected state, a real read-only action, reconnect and restart. The historical counts above still describe the 2026-09-12 observation.| Plugin | Add works | Browser auth | Callback | Connected state | Real smoke test | Reconnect | OS/provider limitations | Result | Remaining blocker ||---|---|---|---|---|---|---|---|---|---|@@ -77,7 +77,7 @@ Shopify (added 2026-09-21, after the RUB-94 observation) has one observed UI att- Meta supports OAuth. The current connector's token-paste path does not meet the browser standard. The remaining publisher work is a confidential HTTPS callback/broker and required app review. The [archived official OAuth client implementation](https://raw.githubusercontent.com/facebookarchive/php-graph-sdk/5.x/src/Facebook/Authentication/OAuth2Client.php) demonstrates OAuth token exchange; it is historical evidence, not current approval of this project's app. Current Meta documentation could not be retrieved during investigation (HTTP 429), so unsupported-provider claims are not justified.- Notion, Linear and Cloudflare reached official consent pages. Workspace/cloud-resource grants remain pending account-holder approval. Their pre-existing connections were preserved.- Higgsfield initially returned `invalid_scope`. The scope-selection fix uses protected-resource scopes instead of the issuer-wide scope set. A new real UI Connect run reached the official [Higgsfield sign-in page](https://higgsfield.ai/de/auth/sign-in), inspected in the browser DOM, with `openid email offline_access`; the earlier error did not recur. This verifies the repaired sign-in entry, not successful authorization or a usable plugin. Account sign-in remains BLOCKED.-- Shopify connects through the official hosted MCP at `https://setup.shopify.com/mcp`. Shopify publishes OAuth discovery but NO Dynamic Client Registration endpoint, so the plugin uses Authorization Code + PKCE loopback against the publisher-shared app (loopback redirect, RFC 8707 resource indicator, comma-joined scopes) — the same shape as the other PKCE-loopback plugins. The remaining publisher work is registering that shared app with the loopback redirect URI and the four read scopes, then completing a store-owner sign-in. An expert can meanwhile connect with their own Shopify app client through the dialog's advanced option. See [Shopify authentication](https://shopify.dev/docs/apps/build/authentication-authorization) and the [Storefront MCP](https://shopify.dev/docs/apps/build/storefront-mcp) family.+- Shopify connects through the official hosted MCP at `https://setup.shopify.com/mcp`. Shopify publishes OAuth discovery but NO Dynamic Client Registration endpoint, so the plugin uses Authorization Code + PKCE loopback against the publisher-shared app (loopback redirect, RFC 8707 resource indicator, comma-joined scopes) — the same shape as the other PKCE-loopback plugins. The remaining publisher work is registering that shared app with the loopback redirect URI and the four read scopes, then completing a store-owner sign-in. The connector manifest remains in source for future qualification; Shopify is not offered in the default catalog. See [Shopify authentication](https://shopify.dev/docs/apps/build/authentication-authorization) and the [Storefront MCP](https://shopify.dev/docs/apps/build/storefront-mcp) family.## Release and maintenance gatediff --git a/docs/marketplace/plugin-e2e-audit.json b/docs/marketplace/plugin-e2e-audit.jsonindex cecafac376..11788b7c85 100644--- a/docs/marketplace/plugin-e2e-audit.json+++ b/docs/marketplace/plugin-e2e-audit.json@@ -2275,55 +2275,6 @@"next_action": "Run the no-login connection and real telemetry read on a supported Linux AMD host, then verify lifecycle.","evidence": "Plugins\nSkills\nPlugins\nMCPs\nPlugins\nAMD GPU Status\n\nUnsupported on this device\n· Home & Devices\n\nConnect\n\nAMD GPU telemetry is unavailable on this operating system. This connector requires a compatible Linux AMD host with AMD SMI.\n\nRead AMD GPU utilization, temperature and driver data through AMD SMI\n\nStatus\nUnsupported on this device\nSign-in\nLocal device\nConnection\nStays connected\n—\n0 files\namd_gpu\nLoading…"}- },- {- "plugin_id": "shopify",- "result": "BLOCKED",- "config_fingerprint": "1d590b64b18618a2e164f2fd1718edc3e125c1baad9fa3b0d0bf5fdff4ed6324",- "initial_state": "connect_attempt",- "evidence": {- "ui": {- "status": "PASS",- "detail": "Shopify card renders in the Plugins dialog (47th entry) with its logo; Connect attempted 2026-09-21 and failed with the generic dialog (see blocker).",- "reference": "docs/marketplace/plugin-auth-audit.md#audit-matrix"- },- "browser": {- "status": "BLOCKED",- "detail": "Browser completion was not verified in this audit. The first configuration (hosted MCP with Dynamic Client Registration) was wrong: Shopify publishes no DCR registration_endpoint, so the flow failed before any browser page opened. The entry now uses Authorization Code + PKCE loopback against the publisher-shared app; the shared app registration and the store-owner sign-in are both still pending.",- "reference": "docs/marketplace/plugin-auth-audit.md#audit-matrix"- },- "callback": {- "status": "BLOCKED",- "detail": "Callback completion was not verified in this audit. No authorization code has been issued yet; the shared app registration and the store-owner sign-in are still pending.",- "reference": "docs/marketplace/plugin-auth-audit.md#audit-matrix"- },- "connected": {- "status": "BLOCKED",- "detail": "Connected completion was not verified in this audit. No grant exists yet; the shared app registration and the store-owner sign-in are still pending.",- "reference": "docs/marketplace/plugin-auth-audit.md#audit-matrix"- },- "smoke": {- "status": "BLOCKED",- "detail": "Smoke completion was not verified in this audit. No live read-only Shopify action has been attested with a real grant.",- "reference": "docs/marketplace/plugin-auth-audit.md#audit-matrix"- },- "reconnect": {- "status": "BLOCKED",- "detail": "Reconnect completion was not verified in this audit. No grant exists yet; the shared app registration and the store-owner sign-in are still pending.",- "reference": "docs/marketplace/plugin-auth-audit.md#audit-matrix"- },- "restart": {- "status": "BLOCKED",- "detail": "Restart completion was not verified in this audit. No grant exists yet; the shared app registration and the store-owner sign-in are still pending.",- "reference": "docs/marketplace/plugin-auth-audit.md#audit-matrix"- }- },- "blocker": {- "reason": "No publisher-shared Shopify OAuth app is provisioned yet, so the browser flow reports its honest pending state; no store-owner sign-in has been completed either.",- "owner": "Project publisher",- "next_action": "Register the official shared Shopify app (redirect http://127.0.0.1:3130/oauth/callback, read scopes for products, orders, customers and discounts), provision publisher_shopify_oauth_client_id/secret, then repeat the full clean browser journey with a real read-only action.",- "evidence": "Connect on the Shopify card returned the generic failure dialog on 2026-09-21; live metadata shows setup.shopify.com serves OAuth discovery but no DCR registration endpoint."- }}]}diff --git a/docs/marketplace/shopify-pending-e2e.json b/docs/marketplace/shopify-pending-e2e.jsonnew file mode 100644index 0000000000..8d4dcf7e6d--- /dev/null+++ b/docs/marketplace/shopify-pending-e2e.json@@ -0,0 +1,54 @@+{+ "schema_version": 1,+ "plugins": [+ {+ "plugin_id": "shopify",+ "result": "BLOCKED",+ "config_fingerprint": "1d590b64b18618a2e164f2fd1718edc3e125c1baad9fa3b0d0bf5fdff4ed6324",+ "initial_state": "connect_attempt",+ "evidence": {+ "ui": {+ "status": "PASS",+ "detail": "Shopify card renders in the Plugins dialog (47th entry) with its logo; Connect attempted 2026-09-21 and failed with the generic dialog (see blocker).",+ "reference": "docs/marketplace/plugin-auth-audit.md#audit-matrix"+ },+ "browser": {+ "status": "BLOCKED",+ "detail": "Browser completion was not verified in this audit. The first configuration (hosted MCP with Dynamic Client Registration) was wrong: Shopify publishes no DCR registration_endpoint, so the flow failed before any browser page opened. The entry now uses Authorization Code + PKCE loopback against the publisher-shared app; the shared app registration and the store-owner sign-in are both still pending.",+ "reference": "docs/marketplace/plugin-auth-audit.md#audit-matrix"+ },+ "callback": {+ "status": "BLOCKED",+ "detail": "Callback completion was not verified in this audit. No authorization code has been issued yet; the shared app registration and the store-owner sign-in are still pending.",+ "reference": "docs/marketplace/plugin-auth-audit.md#audit-matrix"+ },+ "connected": {+ "status": "BLOCKED",+ "detail": "Connected completion was not verified in this audit. No grant exists yet; the shared app registration and the store-owner sign-in are still pending.",+ "reference": "docs/marketplace/plugin-auth-audit.md#audit-matrix"+ },+ "smoke": {+ "status": "BLOCKED",+ "detail": "Smoke completion was not verified in this audit. No live read-only Shopify action has been attested with a real grant.",+ "reference": "docs/marketplace/plugin-auth-audit.md#audit-matrix"+ },+ "reconnect": {+ "status": "BLOCKED",+ "detail": "Reconnect completion was not verified in this audit. No grant exists yet; the shared app registration and the store-owner sign-in are still pending.",+ "reference": "docs/marketplace/plugin-auth-audit.md#audit-matrix"+ },+ "restart": {+ "status": "BLOCKED",+ "detail": "Restart completion was not verified in this audit. No grant exists yet; the shared app registration and the store-owner sign-in are still pending.",+ "reference": "docs/marketplace/plugin-auth-audit.md#audit-matrix"+ }+ },+ "blocker": {+ "reason": "No publisher-shared Shopify OAuth app is provisioned yet, so the browser flow reports its honest pending state; no store-owner sign-in has been completed either.",+ "owner": "Project publisher",+ "next_action": "Register the official shared Shopify app (redirect http://127.0.0.1:3130/oauth/callback, read scopes for products, orders, customers and discounts), provision publisher_shopify_oauth_client_id/secret, then repeat the full clean browser journey with a real read-only action.",+ "evidence": "Connect on the Shopify card returned the generic failure dialog on 2026-09-21; live metadata shows setup.shopify.com serves OAuth discovery but no DCR registration endpoint."+ }+ }+ ]+}diff --git a/jarvis/marketplace/plugins/shopify/mcp.json b/jarvis/marketplace/drafts/shopify/mcp.template.jsonsimilarity index 100%rename from jarvis/marketplace/plugins/shopify/mcp.jsonrename to jarvis/marketplace/drafts/shopify/mcp.template.jsondiff --git a/jarvis/marketplace/plugins/shopify/plugin.json b/jarvis/marketplace/drafts/shopify/plugin.jsonsimilarity index 100%rename from jarvis/marketplace/plugins/shopify/plugin.jsonrename to jarvis/marketplace/drafts/shopify/plugin.jsondiff --git a/jarvis/marketplace/usage_cards/shopify.md b/jarvis/marketplace/drafts/shopify/usage_card.mdsimilarity index 100%rename from jarvis/marketplace/usage_cards/shopify.mdrename to jarvis/marketplace/drafts/shopify/usage_card.mddiff --git a/jarvis/marketplace/seed_catalog.json b/jarvis/marketplace/seed_catalog.jsonindex e68cabb92f..4a4a6fc0c5 100644--- a/jarvis/marketplace/seed_catalog.json+++ b/jarvis/marketplace/seed_catalog.json@@ -1527,41 +1527,6 @@"env_template": {}},"post_install_hint_md": "Requires AMD SMI on a compatible AMD host. The connect button checks actual device data before enabling. Native Windows and macOS telemetry are unavailable; the base app remains usable without AMD tooling."- },- {- "id": "shopify",- "display_name": "Shopify",- "description": "Products, orders, customers and discounts through the official Shopify MCP server",- "category": "Knowledge & Reading",- "logo_slug": "shopify",- "logo_color": "95BF47",- "featured": false,- "longevity": "self_renewing",- "oauth_client_family": "shopify",- "auth": {- "mode": "oauth_pkce_loopback",- "authorization_url": "https://setup.shopify.com/oauth/authorize",- "token_url": "https://setup.shopify.com/oauth/token",- "client_id": "REPLACE_WITH_JARVIS_SHOPIFY_CLIENT_ID",- "callback_port": 3130,- "callback_path": "/oauth/callback",- "scopes": [- "read_products",- "read_orders",- "read_customers",- "read_discounts"- ],- "scope_separator": "comma",- "refresh_supported": true,- "resource": "https://setup.shopify.com/mcp"- },- "mcp_server": {- "transport": "http",- "url": "https://setup.shopify.com/mcp",- "auth_header_template": "Authorization: Bearer $plugin_shopify_access_token",- "risk_tier": "ask"- },- "post_install_hint_md": "Connect signs you in at Shopify in the browser with read access to products, orders, customers and discounts. If the shared sign-in is not provisioned yet, register your own Shopify app and enter its client ID through the dialog's expert option instead."}]}diff --git a/jarvis/skills/builtin/__init__.py b/jarvis/skills/builtin/__init__.pyindex a5c9482b86..0ddafda639 100644--- a/jarvis/skills/builtin/__init__.py+++ b/jarvis/skills/builtin/__init__.py@@ -50,7 +50,6 @@ _PLUGIN_PAIRED_SKILLS: tuple[str, ...] = ("plugin-spotify","plugin-youtube_music","plugin-higgsfield",- "plugin-shopify",)BUILTIN_SKILL_NAMES: tuple[str, ...] = (diff --git a/jarvis/skills/builtin/plugin-shopify/SKILL.md b/jarvis/skills/drafts/plugin-shopify/SKILL.mdsimilarity index 100%rename from jarvis/skills/builtin/plugin-shopify/SKILL.mdrename to jarvis/skills/drafts/plugin-shopify/SKILL.mddiff --git a/tests/fixtures/skill_routing/golden.yaml b/tests/fixtures/skill_routing/golden.yamlindex 74acb13f28..f685c158c8 100644--- a/tests/fixtures/skill_routing/golden.yaml+++ b/tests/fixtures/skill_routing/golden.yaml@@ -460,27 +460,6 @@ skills:- text: "was ist higgsfield eigentlich fuer ein dienst"reason: definitional question about the product, not a request to act- plugin-shopify:- positives:- - text: "zeig mir meine shopify bestellungen"- channel: trigger- lang: de- min_band: narrow- source: authored- - text: "show my shopify orders"- channel: trigger- lang: en- min_band: narrow- source: authored- - text: "such in shopify nach dem produkt"- channel: trigger- lang: de- min_band: narrow- source: authored- hard_negatives:- - text: "was ist shopify eigentlich fuer ein dienst"- reason: definitional question about the product, not a request to act-plugin-cal_com:positives:- text: "wann ist mein naechster termin bei cal com"diff --git a/tests/unit/marketplace/test_catalog_seed.py b/tests/unit/marketplace/test_catalog_seed.pyindex 420cd87525..28343b1ece 100644--- a/tests/unit/marketplace/test_catalog_seed.py+++ b/tests/unit/marketplace/test_catalog_seed.py@@ -10,6 +10,7 @@ the package.from __future__ import annotationsimport json+from pathlib import Pathimport pytest@@ -354,15 +355,17 @@ def test_cloudflare_is_dcr_one_click_with_http_mcp() -> None:assert spec.mcp_server["url"] == "https://observability.mcp.cloudflare.com/mcp"-def test_discord_is_bot_pat_channel_no_mcp() -> None:+def test_discord_uses_browser_identity_with_bot_token_fallback() -> None:# AD-3 (2026-06-09): connecting Discord enables the in-repo bidirectional# channel (like Telegram), not a competing mcp-discord server that would# open a second Discord gateway over the same bot token.spec = _seed().by_id("discord")assert spec is not Noneassert spec.display_name == "Discord"- assert spec.auth.mode == "pat_paste"- assert spec.auth.auth_scheme == "bot"+ assert spec.auth.mode == "oauth_pkce_loopback"+ assert spec.fallback_auth is not None+ assert spec.fallback_auth.mode == "pat_paste"+ assert spec.fallback_auth.auth_scheme == "bot"assert spec.mcp_server is None@@ -433,20 +436,31 @@ def test_higgsfield_is_dcr_one_click_with_http_mcp() -> None:assert spec.native_tool is None-def test_shopify_is_pkce_loopback_with_resource_and_http_mcp() -> None:+def test_unlisted_shopify_manifest_keeps_its_pkce_configuration() -> None:# 2026-09-21: Shopify publishes no DCR registration_endpoint, so the# first (DCR) attempt failed at connect with "provider request failed".# The plugin uses Authorization Code + PKCE loopback against the# publisher-shared app, with the RFC 8707 resource indicator the MCP# server requires.- spec = _seed().by_id("shopify")- assert spec is not None+ from jarvis.marketplace.catalog import PluginSpec++ assert _seed().by_id("shopify") is None+ manifest_path = (+ Path(__file__).resolve().parents[3]+ / "jarvis/marketplace/drafts/shopify/plugin.json"+ )+ manifest = json.loads(manifest_path.read_text(encoding="utf-8"))+ spec = PluginSpec.model_validate({+ "id": manifest["name"],+ "description": manifest["description"],+ **manifest["extensions"]["io.github.personaljarvis"],+ })assert spec.display_name == "Shopify"assert spec.category == "Knowledge & Reading"assert spec.oauth_client_family == "shopify"assert spec.auth.mode == "oauth_pkce_loopback"assert spec.auth.authorization_url == "https://setup.shopify.com/oauth/authorize"- assert spec.auth.token_url == "https://setup.shopify.com/oauth/token"+ assert spec.auth.token_url == "https://setup.shopify.com/oauth/token" # noqa: S105 - URL, not a credentialassert spec.auth.callback_port == 3130assert spec.auth.scopes == ["read_products",diff --git a/tests/unit/marketplace/test_connect_placeholder_guard.py b/tests/unit/marketplace/test_connect_placeholder_guard.pyindex aaee6f81a3..401934bf72 100644--- a/tests/unit/marketplace/test_connect_placeholder_guard.py+++ b/tests/unit/marketplace/test_connect_placeholder_guard.py@@ -58,6 +58,11 @@ class _StubPkceHandler:async def test_connect_start_rejects_placeholder_client(monkeypatch):spec = _pkce_spec("REPLACE_WITH_JARVIS_GOOGLE_CLIENT_ID")monkeypatch.setattr(mr, "load_catalog", lambda: _Catalog([spec]))+ # Model a fresh downloader even when this test host has a publisher client.+ monkeypatch.setattr(+ "jarvis.marketplace.connect_helpers.resolve_pkce_client",+ lambda _pid, cid, csec: (cid, csec),+ )with pytest.raises(HTTPException) as exc_info:await mr.connect_start(spec.id, BackgroundTasks())assert exc_info.value.status_code == 409diff --git a/tests/unit/marketplace/test_pkce_resource.py b/tests/unit/marketplace/test_pkce_resource.pyindex e87b54d7bd..daaf7ac202 100644--- a/tests/unit/marketplace/test_pkce_resource.py+++ b/tests/unit/marketplace/test_pkce_resource.py@@ -1,5 +1,8 @@"""PKCE-loopback authorize/token params for provider-specific extensions."""+import json+from pathlib import Path+import httpximport pytest@@ -84,11 +87,22 @@ def test_shopify_authorize_params_carry_resource_and_comma_scopes():"""Regression: Shopify publishes no DCR registration_endpoint, so theplugin must go through PKCE loopback with the RFC 8707 resourceindicator and comma-joined read scopes — never back to DCR."""- from jarvis.marketplace.auth.oauth_pkce_loopback import PkceLoopbackHandler- from jarvis.marketplace.connect_helpers import build_handler_from_catalog-- handler = build_handler_from_catalog("shopify")- assert isinstance(handler, PkceLoopbackHandler)+ manifest_path = (+ Path(__file__).resolve().parents[3]+ / "jarvis/marketplace/drafts/shopify/plugin.json"+ )+ manifest = json.loads(manifest_path.read_text(encoding="utf-8"))+ auth = manifest["extensions"]["io.github.personaljarvis"]["auth"]+ handler = PkceLoopbackHandler(PkceLoopbackConfig(+ plugin_id="shopify",+ authorization_url=auth["authorization_url"],+ token_url=auth["token_url"],+ client_id="cid",+ callback_port=auth["callback_port"],+ scopes=auth["scopes"],+ scope_separator=auth["scope_separator"],+ resource=auth["resource"],+ ))params = handler._authorize_params( # noqa: SLF001redirect_uri="http://127.0.0.1:3130/oauth/callback",state="s",