Skip to content

Dodaios is an open-source agent OS for your desktop: it runs your coding agents, browser and apps by voice or chat, on your own machine. Formerly Personal Jarvis.

fix: preserve model-less local provider discovery (#838)

Danny Ward3aefaf59b36d
diff --git a/dodaios/brain/manager.py b/dodaios/brain/manager.py
index 756477b9de..aef68320c6 100644
--- a/dodaios/brain/manager.py
+++ b/dodaios/brain/manager.py
@@ -10220,6 +10220,11 @@ class BrainManager:
if fast:
chain.append((active, fast))
+ # Model-less local providers own model discovery. Keep the selected
+ # provider on the chain so its plugin can choose an installed model.
+ if not fast and not deep and active in ("ollama", "local-openai"):
+ chain.append((active, None))
+
# 2. Explicit tier fallbacks from jarvis.toml. These must run before
# generic cross-provider probing so runtime matches healthcheck order.
available = set(self._registry.available())
diff --git a/tests/integration/test_fallback_chain.py b/tests/integration/test_fallback_chain.py
index 7b1f535e4e..58b0f6f0cd 100644
--- a/tests/integration/test_fallback_chain.py
+++ b/tests/integration/test_fallback_chain.py
@@ -192,6 +192,42 @@ async def test_router_picks_fast_for_simple_intent():
assert chain[1][1] == "opus-model"
[email protected]("provider", ["ollama", "local-openai"])
+async def test_selected_local_provider_discovers_model_without_cloud_keys(
+ monkeypatch: pytest.MonkeyPatch, provider: str
+) -> None:
+ """An empty local model pin delegates discovery to the selected plugin."""
+ config = JarvisConfig()
+ config.brain.primary = provider
+ config.brain.deep_brain = ""
+ config.brain.providers[provider] = BrainProviderConfig(model="", deep_model="")
+ config.voice.mode = "pipeline"
+
+ manager = BrainManager(config=config, bus=EventBus(), tools={})
+ manager._registry._loaded = True
+ available = [provider, "claude-api", "gemini", "openrouter", "openai", "grok", "nvidia"]
+ monkeypatch.setattr(manager._registry, "available", lambda: available)
+ manager._dead_providers = set(available) - {provider}
+ manager._configured_fallbacks = []
+ monkeypatch.setattr(manager, "_active_can_call_tools", lambda: True)
+
+ attempted: list[tuple[str, str | None]] = []
+ brain = FakeBrain(text_response="four")
+
+ def get_brain(name: str, model: str | None) -> FakeBrain:
+ attempted.append((name, model))
+ return brain
+
+ monkeypatch.setattr(manager, "_get_brain", get_brain)
+
+ reply = await manager.generate("What is two plus two?", use_history=False)
+
+ assert reply == "four"
+ assert attempted == [(provider, None)]
+ assert manager._last_turn_all_failed is False
+
+
class _MissingKeyBrain:
"""Brain stub that fails like a real provider with no API key.