Skip to content

Dodaios is an open-source agent OS for your desktop: it runs your coding agents, browser and apps by voice or chat, on your own machine. Formerly Personal Jarvis.

docs(errors): say why fourteen handlers stay quiet

Harald53ea78eef705
diff --git a/jarvis/grok_build_auth.py b/jarvis/grok_build_auth.py
index 48d0ec9e6a..e98e07d6c1 100644
--- a/jarvis/grok_build_auth.py
+++ b/jarvis/grok_build_auth.py
@@ -88,10 +88,14 @@ def _read_json(path: Path) -> dict[str, Any] | None:
try:
raw = path.read_text(encoding="utf-8")
except (OSError, ValueError):
+ # No file, no permission, undecodable bytes: all mean the same thing to
+ # every caller — this login does not exist. Nothing to report.
return None
try:
data = json.loads(raw)
except (ValueError, json.JSONDecodeError):
+ # A half-written auth.json reads as "not logged in"; the CLI rewrites
+ # it on the next login and the status card already says so.
return None
return data if isinstance(data, dict) else None
@@ -138,6 +142,8 @@ def _email_from_id_token(token: str | None) -> str | None:
try:
payload = json.loads(base64.urlsafe_b64decode(payload_b64))
except (binascii.Error, ValueError, json.JSONDecodeError):
+ # The token is opaque third-party data and the email is a nicety: an
+ # unreadable payload costs the account label, never the connection.
return None
email = payload.get("email") if isinstance(payload, dict) else None
return email if isinstance(email, str) and email else None
@@ -183,6 +189,8 @@ def _latest_login_mtime(home: Path) -> float | None:
if path.is_file() and path.stat().st_size > 0:
return path.stat().st_mtime
except OSError:
+ # An unreadable home means "no login seen here" — the caller compares
+ # timestamps and treats None as "nothing to copy".
return None
return None
@@ -217,6 +225,8 @@ def prepare_worker_home(
try:
previous = float(marker.read_text(encoding="utf-8").strip())
except (OSError, ValueError):
+ # A missing or garbled marker means the isolated home was never
+ # seeded; the copy below then runs, which is the safe direction.
previous = None
if previous != mtime:
for name in _LOGIN_FILES:
@@ -320,6 +330,8 @@ class GrokBuildAuthService:
creationflags=NO_WINDOW_CREATIONFLAGS,
)
except (OSError, subprocess.SubprocessError):
+ # The version probe is decoration on the status card. A missing or
+ # broken binary is reported by the connection check itself.
version = None
else:
out = (proc.stdout or proc.stderr or "").strip()
@@ -398,6 +410,8 @@ class GrokBuildAuthService:
try:
(self._home_dir() / "auth.json").unlink(missing_ok=True)
except OSError as exc:
+ # Not silent: the reason travels back to the caller, which puts it
+ # on the card the user is looking at.
return False, str(exc)
try:
prepare_worker_home(src_home=self._home_dir())
diff --git a/jarvis/missions/workers/grok_build_direct_worker.py b/jarvis/missions/workers/grok_build_direct_worker.py
index abe88e0eea..3bc113ab39 100644
--- a/jarvis/missions/workers/grok_build_direct_worker.py
+++ b/jarvis/missions/workers/grok_build_direct_worker.py
@@ -373,6 +373,8 @@ class GrokBuildDirectWorker:
limit=_STREAM_READLINE_LIMIT,
)
except FileNotFoundError as exc:
+ # Not silent: the missing binary is handed back as the run's own
+ # error result, which is what the caller reports to the user.
yield ClaudeResult(
subtype="error_during_execution",
is_error=True,
@@ -418,6 +420,9 @@ class GrokBuildDirectWorker:
try:
raw = await asyncio.wait_for(proc.stdout.readline(), timeout=read_cap)
except TimeoutError:
+ # Expected control flow, not a failure: once output has started
+ # a quiet gap is the agent thinking. A timeout BEFORE the first
+ # line is the real fault and does get a message, below.
if got_first_line:
continue
timed_out = True
@@ -448,6 +453,8 @@ class GrokBuildDirectWorker:
try:
obj = json.loads(line)
except json.JSONDecodeError:
+ # The CLI interleaves plain human lines with its JSON stream;
+ # a non-JSON line is normal output, not an error to report.
continue
if not isinstance(obj, dict):
continue
diff --git a/jarvis/plugins/brain/gemini.py b/jarvis/plugins/brain/gemini.py
index b7ec7ba096..30ea5c809d 100644
--- a/jarvis/plugins/brain/gemini.py
+++ b/jarvis/plugins/brain/gemini.py
@@ -142,6 +142,9 @@ def _thinking_config_for(
try:
return _genai_types.ThinkingConfig(thinking_budget=value)
except (TypeError, AttributeError, ValueError):
+ # An installed SDK that does not know this field is a capability
+ # answer, not a fault: None means "no thinking config", and the
+ # request goes out without one (AP-21).
return None
# A positive or dynamic constructor budget is an explicit cap — keep
@@ -159,6 +162,8 @@ def _thinking_config_for(
try:
return _genai_types.ThinkingConfig(thinking_level=level), "level"
except (TypeError, AttributeError, ValueError):
+ # Same capability probe as above, one field newer. Falling through
+ # tries the older budget shape, which is the point of the ladder.
pass
if wants_off:
@@ -1218,6 +1223,9 @@ class GeminiBrain:
thinking_budget=0
)
except (TypeError, AttributeError, ValueError):
+ # Last rung of the same ladder, on the retry
+ # path: no usable config means the request is
+ # sent without one rather than failing here.
fallback = None
if fallback is not None:
config_dict["thinking_config"] = fallback
diff --git a/jarvis/skills/eval_harness.py b/jarvis/skills/eval_harness.py
index 835a75b5af..cdcbadbbed 100644
--- a/jarvis/skills/eval_harness.py
+++ b/jarvis/skills/eval_harness.py
@@ -284,6 +284,9 @@ def _is_block_tier(skill: Any) -> bool:
try:
return frontmatter.risk_policy.default_tier == "block"
except Exception: # noqa: BLE001
+ # A skill whose frontmatter cannot answer is not a blocked skill. This
+ # is the offline eval harness, so a report that reads "not blocked" is
+ # the honest answer and the run keeps scoring the rest of the corpus.
return False
@@ -385,6 +388,8 @@ def _decide(registry: Any, text: str, lang: str = "auto") -> tuple[Any, str]:
try:
skill = registry.get(decision.top.skill_name)
except Exception: # noqa: BLE001
+ # A name the registry will not resolve simply has no guard ladder to
+ # evaluate; the match itself is still reported to the caller.
return decision, ""
decision, skill = _prefer_music_service(registry, decision, skill, text)
ladder = evaluate_guards(
diff --git a/jarvis/ui/web/server.py b/jarvis/ui/web/server.py
index 9d5d31a334..f54011bfcc 100644
--- a/jarvis/ui/web/server.py
+++ b/jarvis/ui/web/server.py
@@ -1351,6 +1351,10 @@ class WebServer:
and grok_build_status.mode == "subscription"
)
except Exception: # noqa: BLE001
+ # A probe that cannot answer means "not connected" on this
+ # overview row, which is the safe reading and one the user can
+ # see. The Agents tab runs the same check and reports the real
+ # cause there; this row must never take the whole page down.
grok_build_connected = False
grok_build_ready = (
grok_build_provider_ready(grok_build_status)