Dodaios is an open-source agent OS for your desktop: it runs your coding agents, browser and apps by voice or chat, on your own machine. Formerly Personal Jarvis.
Python agent-orchestrationai-agentai-coding-assistantclaude-codecoding-agentcomputer-usedesktop-applocal-firstmcppersonal-jarvisvoice-assistantvoice-coding
fix(ci): a green nightly passes the strict gate, and the alert names the gate's reason (#658)
Ruben Lütke5a72fce13feb
diff --git a/.github/workflows/nightly-alert.yml b/.github/workflows/nightly-alert.ymlindex 8ff3e450db..eba810c07b 100644--- a/.github/workflows/nightly-alert.yml+++ b/.github/workflows/nightly-alert.yml@@ -110,8 +110,20 @@ jobs:echoecho "Failed jobs:"echo- gh api "repos/$GITHUB_REPOSITORY/actions/runs/$RUN_ID/jobs?per_page=100&filter=latest" \- --paginate --jq '.jobs[] | select(.conclusion == "failure" and .name != "CI gate") | "- [\(.name)](\(.html_url))"'+ jobs_url="repos/$GITHUB_REPOSITORY/actions/runs/$RUN_ID/jobs?per_page=100&filter=latest"+ failed="$(gh api "$jobs_url" --paginate --jq '.jobs[]+ | select(.name != "CI gate" and (.conclusion == "failure" or .conclusion == "cancelled" or .conclusion == "timed_out"))+ | "- [\(.name)](\(.html_url)) (\(.conclusion))"')"+ if [ -n "$failed" ]; then+ echo "$failed"+ else+ # Every job passed and the gate still refused the run (a job it+ # requires skipped or missing): name what the gate named.+ gate="$(gh api "$jobs_url" --paginate --jq '.jobs[] | select(.name == "CI gate") | "\(.id) \(.html_url)"' | head -n 1)"+ reason="$(gh api "repos/$GITHUB_REPOSITORY/actions/jobs/${gate%% *}/logs" 2>/dev/null \+ | grep -o 'CI gate failed: .*' | head -n 1 || true)"+ echo "- [CI gate](${gate#* }): no job failed, the gate refused the run (${reason:-see its summary})."+ fiechoif [ "$label" = "macos-main" ]; then# Sweeps run one after another, newest first in the list: thediff --git a/scripts/ci/required_results.py b/scripts/ci/required_results.pyindex e6c51f6da9..5b457b7d36 100644--- a/scripts/ci/required_results.py+++ b/scripts/ci/required_results.py@@ -24,9 +24,13 @@ import osimport sysfrom typing import Any-# Jobs that only exist on some events: pull-request-only checks and manual-# soak runs. A strict run may skip these and nothing else.-STRICT_SKIP_OK = frozenset({"pr-policy", "dependency-review", "soak", "release-qualification"})+# Jobs that only exist on some events: pull-request-only checks, manual soak+# runs, and the merge queue's macOS impact selection (the nightly and release+# runs take the whole macOS suite in `tests-macos` instead). A strict run may+# skip these and nothing else; one detection selected still has to run.+STRICT_SKIP_OK = frozenset(+ {"pr-policy", "dependency-review", "soak", "release-qualification", "tests-macos-impact"}+)LANE_JOBS = {"python": {"python-fast", "tests-linux", "tests-windows", "test-report"},diff --git a/tests/unit/ci/test_pipeline_audit.py b/tests/unit/ci/test_pipeline_audit.pyindex 0a177ee90b..ca15a9a364 100644--- a/tests/unit/ci/test_pipeline_audit.py+++ b/tests/unit/ci/test_pipeline_audit.py@@ -190,6 +190,35 @@ def test_unaffected_lanes_can_still_skip():assert required_results.evaluate(needs, pipeline=True)["ok"]+def test_a_green_nightly_passes_the_strict_gate():+ # The nightly of 2026-10-13 had every job green and still failed the+ # gate: strict mode refused the skipped merge-queue-only macOS job.+ gate_needs = workflows()["ci.yml"]["jobs"]["gate"]["needs"]+ assert plan_run.plan("schedule")["mac_impact"] is False+ flags = {name: "true" for name in classify_changes.LANES}+ flags.update(+ full="true",+ macos="true",+ release="false",+ proven="false",+ desktop_legs="all",+ mac_tests="false",+ )+ never_at_night = {"dependency-review", "soak", "release-qualification", "tests-macos-impact"}+ needs = {+ name: {"result": "skipped" if name in never_at_night else "success"} for name in gate_needs+ }+ needs["detect"]["outputs"] = flags+ assert required_results.evaluate(needs, pipeline=True, strict=True)["ok"]+ # Selected, it still has to run, strict or not.+ flags["mac_tests"] = "true"+ assert not required_results.evaluate(needs, pipeline=True, strict=True)["ok"]+ # Any other job skipped at night still fails the strict gate.+ flags["mac_tests"] = "false"+ needs["tests-linux"]["result"] = "skipped"+ assert not required_results.evaluate(needs, pipeline=True, strict=True)["ok"]++def test_dependency_review_runs_only_on_pull_requests_and_may_skip_elsewhere():ci = workflows()["ci.yml"]["jobs"]assert ci["dependency-review"]["if"] == "github.event_name == 'pull_request'"