Skip to content

Dodaios is an open-source agent OS for your desktop: it runs your coding agents, browser and apps by voice or chat, on your own machine. Formerly Personal Jarvis.

fix(ci): recognize Shopify catalog and guard private knowledge routes

rubenluetke10-beep8b56d96fa5c6
diff --git a/scripts/ci/privacy_pre_push.py b/scripts/ci/privacy_pre_push.py
index 828a223b16..395b5e84d2 100644
--- a/scripts/ci/privacy_pre_push.py
+++ b/scripts/ci/privacy_pre_push.py
@@ -63,6 +63,7 @@ _PUBLIC_CATALOG_MCP_URLS = {
"github": "https://api.githubcopilot.com/mcp/",
"granola": "https://mcp.granola.ai/mcp",
"salesforce": "https://api.salesforce.com/platform/mcp/v1/platform/sobject-all",
+ "shopify": "https://setup.shopify.com/mcp",
}
diff --git a/tests/contract/test_agent_mcp_harmony.py b/tests/contract/test_agent_mcp_harmony.py
index f71fcb4eb9..b9e19fe41c 100644
--- a/tests/contract/test_agent_mcp_harmony.py
+++ b/tests/contract/test_agent_mcp_harmony.py
@@ -142,6 +142,14 @@ WITHHELD: Final[dict[str, str]] = {
"review the red/green change; a remote client has no editor and "
"recall already covers lookup"
),
+ "GET /api/society/agents/{agent_id}/knowledge": (
+ "lists an agent's private memory files for the owner; remote clients "
+ "do not receive the agent notebook browsing surface"
+ ),
+ "GET /api/society/agents/{agent_id}/knowledge/file": (
+ "reads a private agent memory file for the owner in the app; remote "
+ "clients do not receive raw notebook contents"
+ ),
"PATCH /api/society/agents/{agent_id}/routines/{task_id}": (
"editing a routine changes recurring spend; the owner does it on the "
"routine card where the schedule is visible, not via a remote client"
diff --git a/tests/unit/ci/test_privacy_pre_push.py b/tests/unit/ci/test_privacy_pre_push.py
index 9455e459b2..c96f107b70 100644
--- a/tests/unit/ci/test_privacy_pre_push.py
+++ b/tests/unit/ci/test_privacy_pre_push.py
@@ -173,6 +173,26 @@ class TestForbiddenFile:
assert not gate.forbidden_file("main.py", FORBIDDEN_BASENAMES)
+class TestPublicCatalogMcp:
+ def test_shopify_catalog_manifest_is_credential_free(self):
+ path = "jarvis/marketplace/plugins/shopify/mcp.json"
+ manifest = (
+ '{"$schema":"https://agent-plugins.org/schemas/1.0.0/mcp.schema.json",'
+ '"mcpServers":{"shopify":{"type":"streamable-http",'
+ '"url":"https://setup.shopify.com/mcp"}}}'
+ )
+ assert gate.is_public_catalog_mcp(path, manifest)
+
+ def test_shopify_manifest_with_query_is_rejected(self):
+ path = "jarvis/marketplace/plugins/shopify/mcp.json"
+ manifest = (
+ '{"$schema":"https://agent-plugins.org/schemas/1.0.0/mcp.schema.json",'
+ '"mcpServers":{"shopify":{"type":"streamable-http",'
+ '"url":"https://setup.shopify.com/mcp?token=secret"}}}'
+ )
+ assert not gate.is_public_catalog_mcp(path, manifest)
+
+
# --------------------------------------------------------------------------- #
# scan_text_for_secrets
# --------------------------------------------------------------------------- #