Skip to content

Dodaios is an open-source agent OS for your desktop: it runs your coding agents, browser and apps by voice or chat, on your own machine. Formerly Personal Jarvis.

feat(ide): the side panel wears the blue in-use frame while the reader works in it

rubenluetke10-beep9a274b94bf49
diff --git a/jarvis/ui/web/frontend/src/components/agentic/AgenticTerminal.test.tsx b/jarvis/ui/web/frontend/src/components/agentic/AgenticTerminal.test.tsx
index 8b89821cba..e7d52e51f4 100644
--- a/jarvis/ui/web/frontend/src/components/agentic/AgenticTerminal.test.tsx
+++ b/jarvis/ui/web/frontend/src/components/agentic/AgenticTerminal.test.tsx
@@ -346,6 +346,10 @@ describe("AgenticTerminal layout", () => {
expect(ring.className).toContain("z-[45]");
expect(pane.lastElementChild).toBe(ring);
expect(pane.style.boxShadow).toBe("");
+ // While the reader works in the side panel, the panel wears the frame.
+ rerender(<AgenticTerminal {...props} focused markFocus={false} />);
+ expect(pane.style.borderColor).toBe(resting);
+ expect(screen.queryByTestId("pane-focus-ring-Dana")).toBeNull();
// One pane in the grid is still the pane in use: it is marked too.
rerender(<AgenticTerminal {...props} focused={false} />);
expect(pane.style.borderColor).toBe(resting);
diff --git a/jarvis/ui/web/frontend/src/components/agentic/AgenticTerminal.tsx b/jarvis/ui/web/frontend/src/components/agentic/AgenticTerminal.tsx
index 6deddd03bd..7b2dc21ce2 100644
--- a/jarvis/ui/web/frontend/src/components/agentic/AgenticTerminal.tsx
+++ b/jarvis/ui/web/frontend/src/components/agentic/AgenticTerminal.tsx
@@ -511,6 +511,12 @@ interface AgenticTerminalProps {
* works in outlined in the signal hue.
*/
headerMode?: "legacy" | "compact" | "minimal" | "none";
+ /**
+ * Minimal tiles only: may the focused pane wear the blue "you are here"
+ * edge right now? Off while the reader works in the IDE's side panel, which
+ * then wears it instead. The pane stays the prompt target either way.
+ */
+ markFocus?: boolean;
/** Compact header only: opens the fork dialog for this pane. */
onFork?: () => void;
/** Compact header only: the worktree branch this pane runs on, if any. */
@@ -654,6 +660,7 @@ export function AgenticTerminal({
workspaceId,
displayName,
headerMode = "legacy",
+ markFocus = true,
onFork,
branch,
computerName,
@@ -2703,7 +2710,7 @@ export function AgenticTerminal({
dragging || justDelivered
? undefined
: minimal
- ? focused ? tile.focus : tile.edge[visibleStatus]
+ ? focused && markFocus ? tile.focus : tile.edge[visibleStatus]
: focused
? undefined
: chrome.edge[visibleStatus],
@@ -2712,7 +2719,7 @@ export function AgenticTerminal({
data-testid={`agentic-pane-${name}`}
>
{headerMode === "compact" ? <WorkspaceTerminalHeader {...headerProps} />
- : minimal ? <WorkspaceTerminalHeader {...headerProps} variant="tile" focused={focused} />
+ : minimal ? <WorkspaceTerminalHeader {...headerProps} variant="tile" focused={focused && markFocus} />
: headerMode === "none" ? null : <PaneHeader
workspaceId={workspaceId}
status={visibleStatus}
@@ -2875,7 +2882,7 @@ export function AgenticTerminal({
than down the terminal (maintainer, 2026-09-30). One layer on top keeps
the line the same brightness all the way round.
*/}
- {minimal && focused && !dragging && !justDelivered && (
+ {minimal && focused && markFocus && !dragging && !justDelivered && (
<div
aria-hidden="true"
data-testid={`pane-focus-ring-${name}`}
diff --git a/jarvis/ui/web/frontend/src/components/agentic/WorkspaceTerminalGrid.test.tsx b/jarvis/ui/web/frontend/src/components/agentic/WorkspaceTerminalGrid.test.tsx
index 88aa85d405..bdcf78404e 100644
--- a/jarvis/ui/web/frontend/src/components/agentic/WorkspaceTerminalGrid.test.tsx
+++ b/jarvis/ui/web/frontend/src/components/agentic/WorkspaceTerminalGrid.test.tsx
@@ -9,8 +9,8 @@ vi.mock("./AgenticTerminal", () => ({ AgenticTerminal: (props: {
name: string; onToggleMaximize: () => void; onRestart: () => void; restartToken: number;
onFocus: () => void;
onArrangeStart?: (event: React.PointerEvent) => void;
- headerMode?: string;
-}) => <div onMouseDown={props.onFocus} data-testid={`pane-${props.name}`} data-header-mode={props.headerMode}>
+ headerMode?: string; markFocus?: boolean;
+}) => <div onMouseDown={props.onFocus} data-testid={`pane-${props.name}`} data-header-mode={props.headerMode} data-mark-focus={String(props.markFocus)}>
<button onClick={props.onToggleMaximize}>Maximize {props.name}</button>
<button type="button" data-ide-drag-handle="true" onPointerDown={props.onArrangeStart}>Move {props.name}</button>
<button onClick={props.onRestart}>Restart {props.name}</button>
@@ -255,3 +255,13 @@ it("draws square tiles in the minimal style and cards in the classic one", () =>
expect(document.querySelector<HTMLElement>('[data-session-id="T1"]')!.className).toContain("rounded-2xl");
expect(screen.getByTestId("pane-T1").dataset.headerMode).toBe("compact");
});
+
+it("hands the blue frame back from the side panel to a pressed pane", () => {
+ useIdeSidePanelStore.setState({ open: true, inUse: true });
+ render(<WorkspaceTerminalGrid {...props} session={makeSession()} paneStyle="minimal" />);
+ expect(screen.getByTestId("pane-T1").dataset.markFocus).toBe("false");
+ fireEvent.mouseDown(screen.getByTestId("pane-T2"));
+ expect(useIdeSidePanelStore.getState().inUse).toBe(false);
+ expect(screen.getByTestId("pane-T1").dataset.markFocus).toBe("true");
+ useIdeSidePanelStore.setState({ open: false, inUse: false });
+});
diff --git a/jarvis/ui/web/frontend/src/components/agentic/WorkspaceTerminalGrid.tsx b/jarvis/ui/web/frontend/src/components/agentic/WorkspaceTerminalGrid.tsx
index 8d7bf06002..a2a3bf2a01 100644
--- a/jarvis/ui/web/frontend/src/components/agentic/WorkspaceTerminalGrid.tsx
+++ b/jarvis/ui/web/frontend/src/components/agentic/WorkspaceTerminalGrid.tsx
@@ -68,6 +68,10 @@ export function WorkspaceTerminalGrid({ session, onChanged, onAdd, onClose, onSe
// The pane an agent card in the side panel pointed at, framed in blue.
const spotlight = useIdeSidePanelStore((state) => state.spotlight);
const setSpotlight = useIdeSidePanelStore((state) => state.setSpotlight);
+ // While the reader works in the side panel, the panel wears the blue frame
+ // and the selected pane lets go of its own; a press on a pane takes it back.
+ const panelInUse = useIdeSidePanelStore((state) => state.inUse);
+ const setPanelInUse = useIdeSidePanelStore((state) => state.setInUse);
const spotlitPane = spotlight?.workspaceId === session.id ? spotlight.pane : null;
const frame = useRef<HTMLDivElement>(null);
const [drag, setDrag] = useState<DragFeedback | null>(null);
@@ -381,7 +385,8 @@ export function WorkspaceTerminalGrid({ session, onChanged, onAdd, onClose, onSe
<AgenticTerminal headerMode={minimal ? "minimal" : "compact"} agent={terminal.agent}
name={terminal.name} workspaceId={session.id} displayName={terminal.display_name}
recap={terminal.recap} promptCount={terminal.prompts_sent} appearance={appearance ?? theme} fontSize={fontSize}
- focused={selected === terminal.name} onFocus={() => { if (spotlitPane && spotlitPane !== terminal.name) setSpotlight(null); onSelect(terminal.name); }}
+ focused={selected === terminal.name} markFocus={!panelInUse}
+ onFocus={() => { if (spotlitPane && spotlitPane !== terminal.name) setSpotlight(null); setPanelInUse(false); onSelect(terminal.name); }}
layoutBusy={resizing}
maximized={visibleMaximized === id} onToggleMaximize={() => setMaximized((current) => current === id ? null : id)}
onArrangeStart={visibleMaximized || saving || disabled ? undefined : (event) => startDrag(id, event)} arranging={drag?.id === id}
diff --git a/jarvis/ui/web/frontend/src/components/agentic/sidePanel/IdeSidePanel.test.tsx b/jarvis/ui/web/frontend/src/components/agentic/sidePanel/IdeSidePanel.test.tsx
index 08286bac7b..553aa182c2 100644
--- a/jarvis/ui/web/frontend/src/components/agentic/sidePanel/IdeSidePanel.test.tsx
+++ b/jarvis/ui/web/frontend/src/components/agentic/sidePanel/IdeSidePanel.test.tsx
@@ -33,7 +33,7 @@ beforeEach(() => {
useWorkspacePanesStore.setState({ panes: [], activeId: null, loaded: true, load: async () => {} });
useIdeProjectsStore.setState({ activeWorkspaceId: null });
useEventStore.setState({ activeSection: "agentic-ide" });
- useIdeSidePanelStore.setState({ open: false, tabs: ["agents"], active: "agents", maximized: false });
+ useIdeSidePanelStore.setState({ open: false, tabs: ["agents"], active: "agents", maximized: false, inUse: false });
});
afterEach(cleanup);
@@ -165,7 +165,7 @@ describe("IdeSidePanel", () => {
expect(screen.getByTestId("office-stage")).toBe(stage);
fireEvent.click(screen.getByTestId("ide-side-panel-maximize"));
- expect(screen.getByTestId("ide-side-panel-body").className).toBe("h-full");
+ expect(screen.getByTestId("ide-side-panel-body").className).toBe("relative h-full");
expect(screen.getByTestId("ide-side-panel-grid").className).not.toContain("invisible");
expect(screen.getByTestId("office-stage")).toBe(stage);
});
@@ -183,4 +183,27 @@ describe("IdeSidePanel", () => {
fireEvent.click(screen.getByTestId("ide-side-panel-rail-office"));
expect(useIdeSidePanelStore.getState()).toMatchObject({ open: true, active: "office" });
});
+
+ it("frames the panel in blue while the reader works in it", () => {
+ useIdeSidePanelStore.setState({ open: true });
+ const { rerender } = render(<IdeSidePanelFrame markInUse><div data-testid="grid">grid</div></IdeSidePanelFrame>);
+ expect(screen.queryByTestId("ide-side-panel-in-use")).toBeNull();
+ fireEvent.pointerDown(screen.getByTestId("ide-side-panel-tab-agents"));
+ expect(useIdeSidePanelStore.getState().inUse).toBe(true);
+ const ring = screen.getByTestId("ide-side-panel-in-use");
+ expect(ring.className).toContain("ring-accent");
+ expect(ring.className).toContain("pointer-events-none");
+ // A press on the grid is the grid's business (the pane hands the frame back).
+ fireEvent.pointerDown(screen.getByTestId("grid"));
+ expect(useIdeSidePanelStore.getState().inUse).toBe(true);
+ act(() => useIdeSidePanelStore.getState().setInUse(false));
+ expect(screen.queryByTestId("ide-side-panel-in-use")).toBeNull();
+ // The classic pane style draws no blue frames at all.
+ act(() => useIdeSidePanelStore.getState().setInUse(true));
+ rerender(<IdeSidePanelFrame><div data-testid="grid">grid</div></IdeSidePanelFrame>);
+ expect(screen.queryByTestId("ide-side-panel-in-use")).toBeNull();
+ // Closing the panel ends its turn as the area in use.
+ act(() => useIdeSidePanelStore.getState().setOpen(false));
+ expect(useIdeSidePanelStore.getState().inUse).toBe(false);
+ });
});
diff --git a/jarvis/ui/web/frontend/src/components/agentic/sidePanel/IdeSidePanel.tsx b/jarvis/ui/web/frontend/src/components/agentic/sidePanel/IdeSidePanel.tsx
index 72c4befdf6..9259c322f8 100644
--- a/jarvis/ui/web/frontend/src/components/agentic/sidePanel/IdeSidePanel.tsx
+++ b/jarvis/ui/web/frontend/src/components/agentic/sidePanel/IdeSidePanel.tsx
@@ -36,9 +36,15 @@ const HEADER_BTN =
* size, so opening or closing it never changes the sibling identity of a live
* terminal or its PTY socket — the same trick the legacy explorer used.
*/
-export function IdeSidePanelFrame({ children }: { children: ReactNode }) {
+/**
+ * `markInUse`: frame the panel in the signal blue while the reader works in it,
+ * the way a focused terminal tile is framed (the minimal pane style).
+ */
+export function IdeSidePanelFrame({ children, markInUse = false }: { children: ReactNode; markInUse?: boolean }) {
const t = useT();
const open = useIdeSidePanelStore((state) => state.open);
+ const inUse = useIdeSidePanelStore((state) => state.inUse);
+ const setInUse = useIdeSidePanelStore((state) => state.setInUse);
const active = useIdeSidePanelStore((state) => state.active);
const maximized = useIdeSidePanelStore((state) => state.maximized);
// Ctrl+click on a path in any terminal opens it in the Explorer tab.
@@ -125,9 +131,18 @@ export function IdeSidePanelFrame({ children }: { children: ReactNode }) {
/>
</div>
)}
- {/* Same element either way, so the live office scene is never remounted. */}
- <div data-testid="ide-side-panel-body" className={maximized ? "absolute inset-0 z-30" : "h-full"}>
+ {/* Same element either way, so the live office scene is never remounted.
+ A press anywhere in it (capture phase: the office canvas and the
+ terminals in it stop their own events) makes it the area in use. */}
+ <div data-testid="ide-side-panel-body" className={maximized ? "absolute inset-0 z-30" : "relative h-full"}
+ onPointerDownCapture={() => setInUse(true)}>
<IdeSidePanel />
+ {/* The "you are here" frame, drawn over everything in the panel so
+ no tab header or scene can cover part of it. */}
+ {markInUse && inUse && (
+ <div aria-hidden="true" data-testid="ide-side-panel-in-use"
+ className="pointer-events-none absolute inset-0 z-40 ring-2 ring-inset ring-accent" />
+ )}
</div>
</>
)}
diff --git a/jarvis/ui/web/frontend/src/store/ideSidePanel.ts b/jarvis/ui/web/frontend/src/store/ideSidePanel.ts
index d75867d55a..6ef5211b41 100644
--- a/jarvis/ui/web/frontend/src/store/ideSidePanel.ts
+++ b/jarvis/ui/web/frontend/src/store/ideSidePanel.ts
@@ -84,6 +84,14 @@ interface IdeSidePanelState {
*/
maximized: boolean;
setMaximized: (maximized: boolean) => void;
+ /**
+ * The reader is working in the panel: their last press landed in it rather
+ * than in a terminal. The panel then wears the blue "you are here" frame a
+ * focused terminal wears, and the terminal lets go of its own. A press on
+ * a pane hands it back. Not persisted.
+ */
+ inUse: boolean;
+ setInUse: (inUse: boolean) => void;
}
const initialTabs = storedTabs();
@@ -102,8 +110,10 @@ export const useIdeSidePanelStore = create<IdeSidePanelState>((set, get) => {
setSpotlight: (spotlight) => set({ spotlight }),
maximized: false,
setMaximized: (maximized) => set({ maximized: maximized && get().open }),
+ inUse: false,
+ setInUse: (inUse) => { if (get().inUse !== inUse) set({ inUse: inUse && get().open }); },
setOpen: (open) => {
- if (!open) set({ spotlight: null, maximized: false });
+ if (!open) set({ spotlight: null, maximized: false, inUse: false });
commit({ open });
},
toggle: () => get().setOpen(!get().open),
@@ -120,7 +130,7 @@ export const useIdeSidePanelStore = create<IdeSidePanelState>((set, get) => {
if (index < 0) return;
const rest = tabs.filter((tab) => tab !== id);
if (rest.length === 0) {
- set({ spotlight: null, maximized: false });
+ set({ spotlight: null, maximized: false, inUse: false });
commit({ open: false, tabs: DEFAULT_TABS, active: DEFAULT_TABS[0] });
return;
}
diff --git a/jarvis/ui/web/frontend/src/views/AgenticIdeView.tsx b/jarvis/ui/web/frontend/src/views/AgenticIdeView.tsx
index 38c805e347..e7f6034abe 100644
--- a/jarvis/ui/web/frontend/src/views/AgenticIdeView.tsx
+++ b/jarvis/ui/web/frontend/src/views/AgenticIdeView.tsx
@@ -484,7 +484,7 @@ export function AgenticIdeView({ onScreen = true }: AgenticIdeViewProps) {
<CloseAgentDialog target={closeTarget} busy={busy} onCancel={() => setCloseRequest(null)} onConfirm={confirmClose} />
<main className="min-h-0 flex-1">
- <IdeSidePanelFrame>
+ <IdeSidePanelFrame markInUse={paneStyle === "minimal"}>
{session ? <WorkspaceTerminalGrid key={session.id} session={session} onChanged={(next) => setState((current) => current?.session?.id === next.id ? { ...current, session: next } : current)}
onAdd={openAgentPicker} onClose={closeAgent} onSelect={setSelected} selected={selected} maxPanes={maxPanes} fontSize={fontSize} appearance={appearance} disabled={busy}
onMutationStart={beginGridMutation} onMutationEnd={endGridMutation} paneStyle={paneStyle} />