Dodaios is an open-source agent OS for your desktop: it runs your coding agents, browser and apps by voice or chat, on your own machine. Formerly Personal Jarvis.
Python agent-orchestrationai-agentai-coding-assistantclaude-codecoding-agentcomputer-usedesktop-applocal-firstmcppersonal-jarvisvoice-assistantvoice-coding
fix(agents): apply conversational reply structure to all chat seats
rubenluetke10-beepc607e8a71434
diff --git a/jarvis/agent_chat/runner_cli.py b/jarvis/agent_chat/runner_cli.pyindex effa026e82..d78af14681 100644--- a/jarvis/agent_chat/runner_cli.py+++ b/jarvis/agent_chat/runner_cli.py@@ -1065,6 +1065,8 @@ def _with_identity(return promptif resume:if identity.session_id.startswith("society:"):+ from jarvis.core.response_style import CONVERSATIONAL_TURN_REMINDER+# A resumed vendor conversation may remember an old, incomplete# tool catalog. Refresh the execution contract without repeating# the large identity/history block on every turn.@@ -1081,7 +1083,9 @@ def _with_identity("Use existing connected-account information; ask only for essential ""missing information. If a tool is unavailable or fails, report the ""actual blocker without claiming completion. Existing permission "- "rules still apply.\n</jarvis_turn_context>\n\n" + prompt+ "rules still apply.\n"+ + CONVERSATIONAL_TURN_REMINDER+ + "\n</jarvis_turn_context>\n\n" + prompt)return prompttext = identity.compact if compact else identity.textdiff --git a/jarvis/core/response_style.py b/jarvis/core/response_style.pyindex 6260583d04..c845378fe8 100644--- a/jarvis/core/response_style.py+++ b/jarvis/core/response_style.py@@ -1,5 +1,15 @@"""Default conversational reporting for human-facing chat replies."""+CONVERSATIONAL_TURN_REMINDER = (+ "Reply naturally in short paragraphs, one idea per paragraph. Answer the latest "+ "point directly, with the observed result first. No mandatory report headings or "+ "handoff checklist. Explain tool results instead of dumping JSON. Share meaningful "+ "new findings as work proceeds, without narrating every click. Use a short list "+ "only when comparing items; expand when the person asks for detail. Keep explicit "+ "user preferences and the selected language. Do not invent outcomes, ongoing work "+ "or a next step just to end with one."+)+CONVERSATIONAL_RESPONSE_STYLE = ("Conversational reporting: sound like a capable, approachable colleague. ""Lead with the answer or observed outcome, then explain what it means for the person. "@@ -18,4 +28,31 @@ CONVERSATIONAL_RESPONSE_STYLE = ("Ask only for information that changes the next action; do not end every reply with ""a question or repeat the user's request. Follow explicit user preferences for length ""and tone, and the turn's already-selected output language."+ "\n\nConversation shape:\n"+ "- Reply to the person's latest point directly. Usually use one to three sentences "+ "per paragraph, with one idea per paragraph and ordinary words. Do not turn every "+ "answer into sections named Result, Analysis, Summary or Next steps.\n"+ "- Keep a real conversation moving: when a meaningful tool stage finishes, explain "+ "the new finding briefly before continuing if useful. Do not save every finding "+ "for one large final report, narrate every click, or split one thought into many "+ "messages. If nothing new happened, do not send another progress update.\n"+ "- For a correction, acknowledge the specific change once and apply it; do not "+ "restart the explanation or defend the old answer. If evidence contradicts the "+ "person's assumption, explain that calmly rather than agreeing automatically.\n"+ "- A comparison may use a short list. A difficult explanation may need several "+ "short paragraphs. Supply all requested detail, but do not restate the same facts "+ "in an introduction, a list and a conclusion. Finish when the useful information "+ "has been delivered; no obligatory offer, question or handoff checklist.\n"+ "- Keep implementation vocabulary in the tool details unless it explains a real "+ "limitation. Say what works, what is missing, and what the person needs to do.\n"+ "\nIllustrations of tone and structure, not facts to claim or scripts to copy. "+ "Adapt them to the evidence and the selected language:\n"+ "Verified outcome: 'The page opened correctly. Its heading is Example Domain.'\n"+ "Partial access: 'I can read the account, but posting is not connected yet. "+ "Use the connection card to enable it.' Only mention a card if it exists.\n"+ "Correction: 'Understood. Future release posts will include a short description "+ "of the changes.' This describes intent; confirm saving only after the tool succeeds.\n"+ "New finding: 'The upload failed because this connection lacks upload access. "+ "Reading still works; I am checking the available connection options.' "+ "Use a progress statement only while actually continuing the work.")diff --git a/jarvis/society/surface.py b/jarvis/society/surface.pyindex 54ecc9f9fc..d29471c5c4 100644--- a/jarvis/society/surface.py+++ b/jarvis/society/surface.py@@ -26,6 +26,7 @@ from pathlib import Pathfrom typing import Any, Final, castfrom jarvis.core.protocols import Tool+from jarvis.core.response_style import CONVERSATIONAL_RESPONSE_STYLEfrom .agent_tools import (MemoryRecallTool,@@ -76,9 +77,9 @@ mission workers.Discover projects and connected CLIs first; use explicit project paths and persistent pane IDs.Opening and sending obey your approval rules. Read recorded context before claiming completion.- Teammates: send ONE teammate a message with society_message_agent (kinds: say, query, \-answer, propose). Compose it yourself. When you finish work for someone, end with a handoff: \-what is done, where the output is, what evidence you used, what remains open, who owns the \-next step.+answer, propose). Compose it yourself. When handing work to a teammate, include the result, \+its location and any unresolved dependency they need to continue. A reply to the user is a \+natural conversation, not a mandatory handoff checklist; mention only relevant details.- Shell: society_shell runs commands in YOUR workspace folder only (relative paths stay inside it; \outside paths are refused). Destructive commands ask the user first.- Learning: after a finished task you may gain a learned skill of your own (listed \@@ -621,6 +622,9 @@ def build_briefing(else "You do not assign work; ask Jarvis or an orchestrator."))+ # API and CLI seats both consume this briefing. Put reply guidance before+ # potentially long standing instructions so compact CLI identities retain it.+ parts.append("## How to reply to the person\n" + CONVERSATIONAL_RESPONSE_STYLE)if agent.description.strip():parts.append("## Standing instructions\n" + agent.description.strip())diff --git a/tests/unit/society/test_reply_style.py b/tests/unit/society/test_reply_style.pynew file mode 100644index 0000000000..142219d94d--- /dev/null+++ b/tests/unit/society/test_reply_style.py@@ -0,0 +1,58 @@+"""Agent-specific API and CLI briefings retain conversational reply guidance."""++from jarvis.agent_chat.jarvis_harness import Identity, compact_identity, identity_prompt+from jarvis.agent_chat.runner_cli import _with_identity+from jarvis.core.response_style import (+ CONVERSATIONAL_RESPONSE_STYLE,+ CONVERSATIONAL_TURN_REMINDER,+)+from jarvis.society.roster import AgentRecord+from jarvis.society.surface import build_briefing+++def _briefing(extra: str = "") -> str:+ agent = AgentRecord.from_row(+ {+ "agent_id": "reply-style-test",+ "name": "Research assistant",+ "tier": "specialist",+ "description": "Explain findings simply. Ask before publishing anything." + extra,+ }+ )+ return build_briefing(agent, [], [agent])+++def test_agent_briefing_includes_reply_style_without_replacing_its_instructions() -> None:+ briefing = _briefing()+ assert CONVERSATIONAL_RESPONSE_STYLE in briefing+ assert "Ask before publishing anything." in briefing+ assert "You are Research assistant" in briefing+ assert "end with a handoff" not in briefing+++async def test_cli_identity_carries_the_same_reply_policy_on_fresh_and_resumed_turns() -> None:+ for resume in (None, "existing-vendor-session"):+ identity = await identity_prompt(+ user_text="Explain the result.", history=[], resume=resume, prompt_override=_briefing()+ )+ assert CONVERSATIONAL_RESPONSE_STYLE in identity+ assert CONVERSATIONAL_RESPONSE_STYLE in compact_identity(identity)+ seat = Identity(+ session_id="society:reply-style-test", text=identity, compact=compact_identity(identity)+ )+ delivered = _with_identity("Explain the result.", seat, resume)+ expected = CONVERSATIONAL_TURN_REMINDER if resume else CONVERSATIONAL_RESPONSE_STYLE+ assert expected in delivered+ assert delivered.endswith("Explain the result.")+++async def test_reply_policy_survives_long_instructions_in_a_compact_cli_identity() -> None:+ identity = await identity_prompt(+ user_text="Explain the result.",+ history=[],+ resume=None,+ prompt_override=_briefing("\nDetailed domain context." * 1000),+ )+ compact = compact_identity(identity)+ assert len(compact) < len(identity)+ assert CONVERSATIONAL_RESPONSE_STYLE in compact