Skip to content

Dodaios is an open-source agent OS for your desktop: it runs your coding agents, browser and apps by voice or chat, on your own machine. Formerly Personal Jarvis.

fix(browser): give a cold installed-Chrome start the full start budget (#467)

Ruben Lütkec86e0959258d
diff --git a/jarvis/society/browser/install.py b/jarvis/society/browser/install.py
index 3d56ccc7d6..60c71780e6 100644
--- a/jarvis/society/browser/install.py
+++ b/jarvis/society/browser/install.py
@@ -366,6 +366,14 @@ def ensure_installed(
probe = lines[-1]
executable = Path(probe["executable"]).resolve()
if not executable.is_relative_to(root):
+ # Local diagnostics only: which two paths disagreed. A flaky
+ # CI failure here (run 37674355475) left no way to tell a
+ # foreign binary from a path-normalisation difference.
+ log.error(
+ "Browser probe executable %s is outside the managed root %s",
+ executable,
+ root,
+ )
raise RuntimeError("Browser verification used an unmanaged executable")
manifest = {
"browser_use": BROWSER_USE_VERSION,
diff --git a/jarvis/society/browser/manual_chrome.py b/jarvis/society/browser/manual_chrome.py
index 75f022d65c..ca1acc45c4 100644
--- a/jarvis/society/browser/manual_chrome.py
+++ b/jarvis/society/browser/manual_chrome.py
@@ -274,7 +274,17 @@ def _owned_windows(pid: int) -> list[int]:
return windows
-async def _wait_for_window(pid: int, *, timeout: float = 15.0) -> None: # noqa: ASYNC109
+#: How long the installed Chrome may take to show its first window. A cold
+#: first start on a fresh machine (new profile, first-run setup, antivirus
+#: scanning the binary) has taken longer than 15 s, which failed the start with
+#: a bare TimeoutError well inside the caller's 90 s start budget
+#: (``_START_TIMEOUT_S`` in live.py, CI run 37674355475).
+_WINDOW_ARRIVAL_TIMEOUT_S = 60.0
+
+
+async def _wait_for_window(
+ pid: int, *, timeout: float = _WINDOW_ARRIVAL_TIMEOUT_S # noqa: ASYNC109
+) -> None:
watcher = _WindowArrival(pid)
watcher.thread.start()
try:
@@ -282,9 +292,12 @@ async def _wait_for_window(pid: int, *, timeout: float = 15.0) -> None: # noqa:
raise RuntimeError("Chrome startup window listener did not start")
if watcher.error:
raise RuntimeError("Chrome startup window listener failed") from watcher.error
- async with asyncio.timeout(timeout):
- while not await asyncio.to_thread(_owned_windows, pid):
- await watcher.events.get()
+ try:
+ async with asyncio.timeout(timeout):
+ while not await asyncio.to_thread(_owned_windows, pid):
+ await watcher.events.get()
+ except TimeoutError as exc:
+ raise TimeoutError(f"Chrome showed no window within {timeout:.0f} s") from exc
finally:
await asyncio.to_thread(watcher.stop)