Skip to content

Dodaios is an open-source agent OS for your desktop: it runs your coding agents, browser and apps by voice or chat, on your own machine. Formerly Personal Jarvis.

feat(ide): maximize the side panel over the whole view

rubenluetke10-beepd57bfa42449b
diff --git a/jarvis/ui/web/frontend/src/components/agentic/sidePanel/IdeSidePanel.test.tsx b/jarvis/ui/web/frontend/src/components/agentic/sidePanel/IdeSidePanel.test.tsx
index 0080995d99..0435795254 100644
--- a/jarvis/ui/web/frontend/src/components/agentic/sidePanel/IdeSidePanel.test.tsx
+++ b/jarvis/ui/web/frontend/src/components/agentic/sidePanel/IdeSidePanel.test.tsx
@@ -33,7 +33,7 @@ beforeEach(() => {
useWorkspacePanesStore.setState({ panes: [], activeId: null, loaded: true, load: async () => {} });
useIdeProjectsStore.setState({ activeWorkspaceId: null });
useEventStore.setState({ activeSection: "agentic-ide" });
- useIdeSidePanelStore.setState({ open: false, tabs: ["agents"], active: "agents" });
+ useIdeSidePanelStore.setState({ open: false, tabs: ["agents"], active: "agents", maximized: false });
});
afterEach(cleanup);
@@ -147,6 +147,34 @@ describe("IdeSidePanel", () => {
expect(useIdeSidePanelStore.getState()).toMatchObject({ active: "agents", tabs: ["office", "agents"] });
});
+ it("maximizes the office over the whole view without remounting it or resizing the grid", async () => {
+ localStorage.setItem("jarvis.agenticIde.sidePanelWidth.v1", "600");
+ act(() => useIdeSidePanelStore.setState({ open: true, tabs: ["office"], active: "office" }));
+ render(<Harness />);
+ const stage = await screen.findByTestId("office-stage");
+ const host = screen.getByTestId("ide-side-panel-host");
+
+ fireEvent.click(screen.getByTestId("ide-side-panel-maximize"));
+ expect(useIdeSidePanelStore.getState().maximized).toBe(true);
+ expect(screen.getByTestId("ide-side-panel-body").className).toContain("absolute inset-0");
+ expect(host.className).not.toContain("relative");
+ expect(host.style.width).toBe("600px");
+ expect(screen.queryByTestId("ide-side-panel-resizer")).toBeNull();
+ expect(screen.getByTestId("office-stage")).toBe(stage);
+
+ fireEvent.click(screen.getByTestId("ide-side-panel-maximize"));
+ expect(screen.getByTestId("ide-side-panel-body").className).toBe("h-full");
+ expect(screen.getByTestId("office-stage")).toBe(stage);
+ });
+
+ it("drops the full view when the panel closes", () => {
+ act(() => useIdeSidePanelStore.setState({ open: true, tabs: ["agents"], active: "agents" }));
+ render(<Harness />);
+ fireEvent.click(screen.getByTestId("ide-side-panel-maximize"));
+ fireEvent.click(screen.getByTestId("ide-side-panel-collapse"));
+ expect(useIdeSidePanelStore.getState().maximized).toBe(false);
+ });
+
it("lists Office on the closed panel's rail", () => {
render(<Harness />);
fireEvent.click(screen.getByTestId("ide-side-panel-rail-office"));
diff --git a/jarvis/ui/web/frontend/src/components/agentic/sidePanel/IdeSidePanel.tsx b/jarvis/ui/web/frontend/src/components/agentic/sidePanel/IdeSidePanel.tsx
index 077592bb5f..830afc60a3 100644
--- a/jarvis/ui/web/frontend/src/components/agentic/sidePanel/IdeSidePanel.tsx
+++ b/jarvis/ui/web/frontend/src/components/agentic/sidePanel/IdeSidePanel.tsx
@@ -1,5 +1,5 @@
import { useEffect, useRef, useState, type ReactNode } from "react";
-import { Check, MoveHorizontal, PanelRightClose, Plus, X } from "lucide-react";
+import { Check, Maximize2, Minimize2, MoveHorizontal, PanelRightClose, Plus, X } from "lucide-react";
import { fill, useT } from "@/i18n";
import { cn } from "@/lib/utils";
import { useResizablePane } from "@/hooks/useResizablePane";
@@ -40,6 +40,7 @@ export function IdeSidePanelFrame({ children }: { children: ReactNode }) {
const t = useT();
const open = useIdeSidePanelStore((state) => state.open);
const active = useIdeSidePanelStore((state) => state.active);
+ const maximized = useIdeSidePanelStore((state) => state.maximized);
// Ctrl+click on a path in any terminal opens it in the Explorer tab.
useExplorerPathRouting();
// A click on a pane in the grid counts as reviewing that agent.
@@ -78,12 +79,16 @@ export function IdeSidePanelFrame({ children }: { children: ReactNode }) {
}, [officeInFront]);
return (
- <div ref={frame} className="flex h-full min-h-0 w-full">
+ <div ref={frame} className="relative flex h-full min-h-0 w-full">
<div className="h-full min-h-0 min-w-0 flex-1">{children}</div>
+ {/* Maximized, the host keeps its width in the row so the terminals behind
+ it never resize, and stops being the positioning box: the panel then
+ anchors to the frame and covers the whole view. */}
<div
data-testid="ide-side-panel-host"
className={cn(
- "relative h-full shrink-0",
+ "h-full shrink-0",
+ !maximized && "relative",
!pane.isResizing && "transition-[width] duration-200 motion-reduce:transition-none",
)}
style={{ width: open ? width : 0 }}
@@ -91,32 +96,37 @@ export function IdeSidePanelFrame({ children }: { children: ReactNode }) {
>
{open && (
<>
- <div className="group absolute inset-y-0 left-0 z-20 flex -translate-x-1/2">
- <PaneResizer
- testId="ide-side-panel-resizer"
- orientation="vertical"
- active={pane.isResizing}
- title={t("ide_side_panel.resize")}
- onPointerDown={pane.startResize}
- onDoubleClick={pane.reset}
- // A start-edge grip: Left grows the panel, so the delta flips.
- onNudge={(delta) => pane.nudge(-delta)}
- valueNow={width}
- valueMin={MIN_PX}
- valueMax={max}
- controls={SIDE_PANEL_ID}
- className="h-full"
- showLine={false}
- />
- <MoveHorizontal
- aria-hidden
- className={cn(
- "pointer-events-none absolute left-1/2 top-1/2 h-5 w-5 -translate-x-1/2 -translate-y-1/2 rounded-full bg-secondary p-0.5 text-foreground transition-opacity",
- pane.isResizing ? "opacity-100" : "opacity-0 group-hover:opacity-100 group-focus-within:opacity-100",
- )}
- />
+ {!maximized && (
+ <div className="group absolute inset-y-0 left-0 z-20 flex -translate-x-1/2">
+ <PaneResizer
+ testId="ide-side-panel-resizer"
+ orientation="vertical"
+ active={pane.isResizing}
+ title={t("ide_side_panel.resize")}
+ onPointerDown={pane.startResize}
+ onDoubleClick={pane.reset}
+ // A start-edge grip: Left grows the panel, so the delta flips.
+ onNudge={(delta) => pane.nudge(-delta)}
+ valueNow={width}
+ valueMin={MIN_PX}
+ valueMax={max}
+ controls={SIDE_PANEL_ID}
+ className="h-full"
+ showLine={false}
+ />
+ <MoveHorizontal
+ aria-hidden
+ className={cn(
+ "pointer-events-none absolute left-1/2 top-1/2 h-5 w-5 -translate-x-1/2 -translate-y-1/2 rounded-full bg-secondary p-0.5 text-foreground transition-opacity",
+ pane.isResizing ? "opacity-100" : "opacity-0 group-hover:opacity-100 group-focus-within:opacity-100",
+ )}
+ />
+ </div>
+ )}
+ {/* Same element either way, so the live office scene is never remounted. */}
+ <div data-testid="ide-side-panel-body" className={maximized ? "absolute inset-0 z-30 bg-background" : "h-full"}>
+ <IdeSidePanel />
</div>
- <IdeSidePanel />
</>
)}
</div>
@@ -183,6 +193,8 @@ export function IdeSidePanel() {
const openTab = useIdeSidePanelStore((state) => state.openTab);
const closeTab = useIdeSidePanelStore((state) => state.closeTab);
const setOpen = useIdeSidePanelStore((state) => state.setOpen);
+ const maximized = useIdeSidePanelStore((state) => state.maximized);
+ const setMaximized = useIdeSidePanelStore((state) => state.setMaximized);
const [menuOpen, setMenuOpen] = useState(false);
const menu = useRef<HTMLDivElement>(null);
const current = sidePanelTab(active);
@@ -287,6 +299,17 @@ export function IdeSidePanel() {
</div>
)}
</div>
+ <button
+ type="button"
+ data-testid="ide-side-panel-maximize"
+ aria-label={t(maximized ? "ide_side_panel.restore" : "ide_side_panel.maximize")}
+ title={t(maximized ? "ide_side_panel.restore" : "ide_side_panel.maximize")}
+ aria-pressed={maximized}
+ onClick={() => setMaximized(!maximized)}
+ className={HEADER_BTN}
+ >
+ {maximized ? <Minimize2 className="h-4 w-4" aria-hidden /> : <Maximize2 className="h-4 w-4" aria-hidden />}
+ </button>
<button
type="button"
data-testid="ide-side-panel-collapse"
diff --git a/jarvis/ui/web/frontend/src/components/society/office/codingNavigate.ts b/jarvis/ui/web/frontend/src/components/society/office/codingNavigate.ts
index 73981270b6..e31b9b5133 100644
--- a/jarvis/ui/web/frontend/src/components/society/office/codingNavigate.ts
+++ b/jarvis/ui/web/frontend/src/components/society/office/codingNavigate.ts
@@ -2,9 +2,12 @@
import type { WorkspacePaneRow } from "@/lib/agenticIdeApi";
import { useEventStore } from "@/store/events";
import { useIdeChatStore } from "@/store/ideChat";
+import { useIdeSidePanelStore } from "@/store/ideSidePanel";
export function openPaneSession(pane: Pick<WorkspacePaneRow, "workspace_id" | "name">): void {
const events = useEventStore.getState();
if (events.activeSection !== "agentic-ide") events.setActiveSection("agentic-ide");
useIdeChatStore.getState().requestPane(pane.workspace_id, pane.name);
+ // A full-view office would hide the very pane it just focused.
+ useIdeSidePanelStore.getState().setMaximized(false);
}
diff --git a/jarvis/ui/web/frontend/src/i18n/locales/de.json b/jarvis/ui/web/frontend/src/i18n/locales/de.json
index 061cf96d33..217308ca4e 100644
--- a/jarvis/ui/web/frontend/src/i18n/locales/de.json
+++ b/jarvis/ui/web/frontend/src/i18n/locales/de.json
@@ -5777,6 +5777,8 @@
"expand": "Seitenleiste öffnen",
"collapse": "Seitenleiste schließen",
"resize": "Breite der Seitenleiste ändern",
+ "maximize": "Ganze Ansicht füllen",
+ "restore": "Zurück in die Seitenleiste",
"add_tab": "Tab hinzufügen",
"all_open": "Alle Tabs sind bereits offen",
"close_tab": "Tab schließen",
diff --git a/jarvis/ui/web/frontend/src/i18n/locales/en.json b/jarvis/ui/web/frontend/src/i18n/locales/en.json
index 8586172d3f..6b20accd8b 100644
--- a/jarvis/ui/web/frontend/src/i18n/locales/en.json
+++ b/jarvis/ui/web/frontend/src/i18n/locales/en.json
@@ -5810,6 +5810,8 @@
"expand": "Open side panel",
"collapse": "Close side panel",
"resize": "Resize side panel",
+ "maximize": "Fill the whole view",
+ "restore": "Back to the side panel",
"add_tab": "Add a tab",
"all_open": "Every tab is already open",
"close_tab": "Close tab",
diff --git a/jarvis/ui/web/frontend/src/i18n/locales/es.json b/jarvis/ui/web/frontend/src/i18n/locales/es.json
index c1f22bba67..7e646917ad 100644
--- a/jarvis/ui/web/frontend/src/i18n/locales/es.json
+++ b/jarvis/ui/web/frontend/src/i18n/locales/es.json
@@ -5777,6 +5777,8 @@
"expand": "Abrir panel lateral",
"collapse": "Cerrar panel lateral",
"resize": "Cambiar el ancho del panel lateral",
+ "maximize": "Ocupar toda la vista",
+ "restore": "Volver al panel lateral",
"add_tab": "Añadir una pestaña",
"all_open": "Todas las pestañas ya están abiertas",
"close_tab": "Cerrar pestaña",
diff --git a/jarvis/ui/web/frontend/src/store/ideSidePanel.ts b/jarvis/ui/web/frontend/src/store/ideSidePanel.ts
index 559eb19255..d75867d55a 100644
--- a/jarvis/ui/web/frontend/src/store/ideSidePanel.ts
+++ b/jarvis/ui/web/frontend/src/store/ideSidePanel.ts
@@ -78,6 +78,12 @@ interface IdeSidePanelState {
closeTab: (id: SidePanelTabId) => void;
spotlight: PaneSpotlight | null;
setSpotlight: (spotlight: PaneSpotlight | null) => void;
+ /**
+ * The panel covers the whole IDE view (the office walked full-size). Not
+ * persisted: a reload always comes back to the terminals.
+ */
+ maximized: boolean;
+ setMaximized: (maximized: boolean) => void;
}
const initialTabs = storedTabs();
@@ -94,8 +100,10 @@ export const useIdeSidePanelStore = create<IdeSidePanelState>((set, get) => {
active: initialTabs.active,
spotlight: null,
setSpotlight: (spotlight) => set({ spotlight }),
+ maximized: false,
+ setMaximized: (maximized) => set({ maximized: maximized && get().open }),
setOpen: (open) => {
- if (!open) set({ spotlight: null });
+ if (!open) set({ spotlight: null, maximized: false });
commit({ open });
},
toggle: () => get().setOpen(!get().open),
@@ -112,7 +120,7 @@ export const useIdeSidePanelStore = create<IdeSidePanelState>((set, get) => {
if (index < 0) return;
const rest = tabs.filter((tab) => tab !== id);
if (rest.length === 0) {
- set({ spotlight: null });
+ set({ spotlight: null, maximized: false });
commit({ open: false, tabs: DEFAULT_TABS, active: DEFAULT_TABS[0] });
return;
}