Skip to content

Dodaios is an open-source agent OS for your desktop: it runs your coding agents, browser and apps by voice or chat, on your own machine. Formerly Personal Jarvis.

fix(agents): open routines from the entire card

rubenluetke10-beepd65e9116dda5
diff --git a/jarvis/ui/web/frontend/src/components/society/card/AgentRoutinesList.test.tsx b/jarvis/ui/web/frontend/src/components/society/card/AgentRoutinesList.test.tsx
index 06427382f7..ead8bec34a 100644
--- a/jarvis/ui/web/frontend/src/components/society/card/AgentRoutinesList.test.tsx
+++ b/jarvis/ui/web/frontend/src/components/society/card/AgentRoutinesList.test.tsx
@@ -8,6 +8,8 @@ import { afterEach, beforeEach, describe, expect, test, vi } from "vitest";
import { AgentRoutinesList } from "@/components/society/card/AgentRoutinesList";
+vi.mock("./AgentRoutineDetail", () => ({ AgentRoutineDetail: () => <div data-testid="routine-opened" /> }));
+
function mount(agentId = "mailbox") {
const client = new QueryClient({
defaultOptions: { queries: { retry: false, staleTime: Infinity, refetchInterval: false } },
@@ -27,7 +29,7 @@ function json(body: unknown, status = 200) {
} as Response;
}
-let routines: { id: string; title: string; state: string; trigger: unknown }[];
+let routines: { id: string; title: string; state: string; trigger: unknown; due_at_ns?: number }[];
let fetchMock: ReturnType<typeof vi.fn>;
describe("AgentRoutinesList", () => {
@@ -73,6 +75,18 @@ describe("AgentRoutinesList", () => {
expect(screen.getByTestId("agent-routines").textContent).not.toContain("[agent:Mailbox]");
});
+ test.each(["schedule", "next-run", "icon", "padding"])("opens the routine when clicking %s", async (area) => {
+ routines[0].due_at_ns = Date.UTC(2026, 8, 13, 8) * 1e6;
+ mount();
+ const card = await screen.findByRole("button", { name: "Morning inbox" });
+ const target = area === "schedule" ? screen.getByText("Every hour")
+ : area === "next-run" ? screen.getByText(/^Next run:/)
+ : area === "icon" ? card.querySelector("svg")! : card;
+ expect(card.contains(target)).toBe(true);
+ fireEvent.click(target);
+ expect(await screen.findByTestId("routine-opened")).toBeTruthy();
+ });
+
test("adding a routine posts to this agent and shows the new row", async () => {
mount();
fireEvent.click(await screen.findByTestId("agent-routines-add"));
diff --git a/jarvis/ui/web/frontend/src/components/society/card/AgentRoutinesList.tsx b/jarvis/ui/web/frontend/src/components/society/card/AgentRoutinesList.tsx
index a3aea04047..985ddcb04d 100644
--- a/jarvis/ui/web/frontend/src/components/society/card/AgentRoutinesList.tsx
+++ b/jarvis/ui/web/frontend/src/components/society/card/AgentRoutinesList.tsx
@@ -50,15 +50,17 @@ export function AgentRoutinesList({ agentId, sampleRoutines, variant = "rail", c
{rows.map((routine) => {
const active = ["scheduled", "active", "enabled", ""].includes(routine.state);
const trigger = routine.trigger as { type?: string; source?: { kind: string } } | null;
- return <li key={routine.id} className="flex items-start gap-2 rounded-md px-0.5 py-1.5 hover:bg-secondary/60">
+ return <li key={routine.id} className="rounded-md">
+ <button type="button" aria-label={displayRoutineTitle(routine.title)} className="flex w-full cursor-pointer select-none items-start gap-2 rounded-md px-0.5 py-1.5 text-left hover:bg-secondary/60 focus-visible:outline focus-visible:outline-ring" onClick={() => setSelected(routine.id)}>
<Clock size={16} aria-hidden className={cn("mt-0.5 shrink-0", active ? "text-success" : "text-muted-foreground")} />
- <div className="min-w-0 flex-1">
- <button type="button" className="block w-full truncate rounded text-left text-[13px] font-medium text-foreground focus-visible:outline focus-visible:outline-ring" onClick={() => setSelected(routine.id)}>{displayRoutineTitle(routine.title)}</button>
+ <span className="min-w-0 flex-1">
+ <span className="block truncate text-[13px] font-medium text-foreground">{displayRoutineTitle(routine.title)}</span>
<span className="block break-words text-[11px] leading-snug text-muted-foreground">{routineScheduleLine(routine, t)}{routine.state === "paused" ? ` · ${t("tasks_view.state.paused")}` : ""}</span>
{routine.dueMs && active ? <span className="block text-[11px] text-muted-foreground">{t("automations_view.next_run")}: {new Date(routine.dueMs).toLocaleString(undefined, { timeZoneName: "short" })}</span> : null}
- {trigger?.type === "webhook" && <WebhookConnection key={routine.id} taskId={routine.id} />}
- {trigger?.type === "source" && trigger.source && <SourceControls key={routine.id} taskId={routine.id} source={trigger.source} />}
- </div>
+ </span>
+ </button>
+ {trigger?.type === "webhook" && <div className="pl-6"><WebhookConnection key={routine.id} taskId={routine.id} /></div>}
+ {trigger?.type === "source" && trigger.source && <div className="pl-6"><SourceControls key={routine.id} taskId={routine.id} source={trigger.source} /></div>}
</li>;
})}
</ul>