Skip to content

Dodaios is an open-source agent OS for your desktop: it runs your coding agents, browser and apps by voice or chat, on your own machine. Formerly Personal Jarvis.

feat(marketplace): ship the shared GitHub device-flow client

rubenluetke10-beepe6fa91387166
diff --git a/docs/marketplace/plugin-auth-audit.md b/docs/marketplace/plugin-auth-audit.md
index 985c7fbf26..b0c2d045ac 100644
--- a/docs/marketplace/plugin-auth-audit.md
+++ b/docs/marketplace/plugin-auth-audit.md
@@ -22,7 +22,7 @@ Twenty-six further hosted MCP services (Atlassian, Sentry, PayPal, Zapier and ot
| Plugin | Add works | Browser auth | Callback | Connected state | Real smoke test | Reconnect | OS/provider limitations | Result | Remaining blocker |
|---|---|---|---|---|---|---|---|---|---|
-| `github` (GitHub) | Reconnect entry only; existing connection retained | Not reached | Not verified | Existing state only; new grant not verified | Not run | Not completed | Windows UI only; other OSes not exercised | **BLOCKED** | Publisher OAuth client is missing; the real UI displays publisher setup pending. **Owner:** Project publisher. **Next:** Provision the official shared OAuth registration and any required review, then repeat the full clean browser journey. Observation: Existing connection retained; Reconnect opens publisher-pending dialog with expert fallback collapsed. Clean disconnect/reconnect blocked by missing publisher device client. |
+| `github` (GitHub) | Reconnect entry only; existing connection retained | Reached (2026-10-05) | Not verified | Existing state only; new grant not verified | Not run | Not completed | Windows UI only; other OSes not exercised | **BLOCKED** | The shared "Personal Jarvis" OAuth App (owned by the PersonalJarvis organisation, Device Flow on, non-expiring tokens, no client secret) is registered and its public client id ships in `SHIPPED_PUBLIC_CLIENT_IDS`. On 2026-10-05 a device-code request with that id succeeded and github.com/login/device showed the consent page for "Personal Jarvis by PersonalJarvis" with logo and the catalog scopes; the final authorize click was not completed because the browser tab was not visible. **Owner:** Project publisher. **Next:** Repeat the full clean in-app journey (connect, smoke, reconnect, restart). Observation: Existing connection retained; Reconnect opens publisher-pending dialog with expert fallback collapsed. Clean disconnect/reconnect blocked by missing publisher device client. |
| `vercel` (Vercel) | Connect entry observed; completion blocked | Provider page reached; authorization incomplete | Not verified | Not verified | Not run | Not completed | Windows UI only; other OSes not exercised | **BLOCKED** | Provider account sign-in has not been completed. **Owner:** Provider account holder. **Next:** Complete official sign-in and consent, then verify all seven stages with a real read-only plugin action. Observation: Connect opened official vercel.com/oauth/authorize; provider sign-in required. No user token or client setup. |
| `supabase` (Supabase) | Connect entry observed; completion blocked | Provider page reached; authorization incomplete | Not verified | Not verified | Not run | Not completed | Windows UI only; other OSes not exercised | **BLOCKED** | Provider account sign-in has not been completed. **Owner:** Provider account holder. **Next:** Complete official sign-in and consent, then verify all seven stages with a real read-only plugin action. Observation: Connect opened supabase.com/dashboard/sign-in via provider DCR. Account sign-in required. |
| `notion` (Notion) | Reconnect entry only; existing connection retained | Provider page reached; authorization incomplete | Not verified | Existing state only; new grant not verified | PASS: notion/notion-fetch; existing grant | Not completed | Windows UI only; other OSes not exercised | **BLOCKED** | Official provider consent page reached; a new resource access grant awaits explicit account-holder approval. **Owner:** Provider account holder. **Next:** Approve the intended workspace or cloud resource grant, then verify callback, action, reconnect and restart. Observation: Existing connection retained; Reconnect reached real Notion workspace consent. New grant awaits explicit user approval for workspace access. Continued observation: the real UI-triggered notion/notion-fetch result is_error=false, duration 790 ms. Full clean-state/lifecycle acceptance remains unverified. |
diff --git a/jarvis/marketplace/publisher_clients.py b/jarvis/marketplace/publisher_clients.py
index e536d4d8e8..4b80b6fa91 100644
--- a/jarvis/marketplace/publisher_clients.py
+++ b/jarvis/marketplace/publisher_clients.py
@@ -56,7 +56,11 @@ ClientSource = Literal["publisher", "own", "catalog", "missing"]
# Microsoft is one Entra public client named "Personal Jarvis": personal and
# work/school accounts, loopback PKCE on http://127.0.0.1:43891/oauth/callback,
# no client secret. One id serves every plugin in the family.
+# GitHub is the "Personal Jarvis" OAuth App owned by the PersonalJarvis
+# organisation: Device Flow enabled, non-expiring user tokens, no client secret
+# (the device flow never sends one).
SHIPPED_PUBLIC_CLIENT_IDS: dict[str, str] = {
+ "github": "Ov23liaA2KfHbfVOelcx",
"microsoft": "1986efcb-f871-4ffa-8df7-64c04dd3ab56",
}
diff --git a/tests/contract/test_plugin_auth_standard.py b/tests/contract/test_plugin_auth_standard.py
index b051106b67..371d3acc7d 100644
--- a/tests/contract/test_plugin_auth_standard.py
+++ b/tests/contract/test_plugin_auth_standard.py
@@ -158,7 +158,7 @@ def test_real_catalog_client_keeps_source_catalog(monkeypatch):
@pytest.mark.asyncio
[email protected]("source", ["publisher", "own", "missing"])
[email protected]("source", ["publisher", "own", "shipped", "missing"])
async def test_device_connect_uses_resolved_client(monkeypatch, source):
import asyncio
@@ -174,7 +174,7 @@ async def test_device_connect_uses_resolved_client(monkeypatch, source):
def fake_get(key, env_fallback=None):
if source == "own" and key == "github_oauth_client_id":
return "expert-client"
- if source != "missing" and key == "publisher_github_oauth_client_id":
+ if source in ("publisher", "own") and key == "publisher_github_oauth_client_id":
return "publisher-client"
return None
@@ -192,6 +192,10 @@ async def test_device_connect_uses_resolved_client(monkeypatch, source):
monkeypatch.setattr("jarvis.core.config.get_secret", fake_get)
monkeypatch.setattr(routes, "DeviceFlowHandler", DeviceHandler)
monkeypatch.setattr(routes, "get_registry", lambda: registry)
+ if source == "missing":
+ monkeypatch.setattr(
+ "jarvis.marketplace.publisher_clients.SHIPPED_PUBLIC_CLIENT_IDS", {}
+ )
if source == "missing":
with pytest.raises(HTTPException) as exc:
await routes.connect_start("github", BackgroundTasks())
@@ -201,7 +205,14 @@ async def test_device_connect_uses_resolved_client(monkeypatch, source):
response = await routes.connect_start("github", BackgroundTasks())
await asyncio.wait_for(completed.wait(), timeout=1)
assert response["kind"] == "device_flow"
- assert captured == ["expert-client" if source == "own" else "publisher-client"]
+ from jarvis.marketplace.publisher_clients import SHIPPED_PUBLIC_CLIENT_IDS
+
+ expected = {
+ "own": "expert-client",
+ "publisher": "publisher-client",
+ "shipped": SHIPPED_PUBLIC_CLIENT_IDS["github"],
+ }[source]
+ assert captured == [expected]
# ----------------------------------------------------------------------
@@ -676,15 +687,19 @@ async def test_list_plugins_exposes_fallback_and_device_standard(monkeypatch):
payload = await mr.list_plugins(Response())
by_id = {p["id"]: p for p in payload["plugins"]}
+ # GitHub ships its public device-flow client: the browser login is ready
+ # with zero setup, and the token path stays only as the expert fallback.
github = by_id["github"]
assert github["fallback_auth"]["mode"] == "pat_paste"
assert github["auth_standard"]["fallback"] is True
- assert github["auth_standard"]["ready"] is False
- assert github["oauth_client_configured"] is False
+ assert github["auth_standard"]["ready"] is True
+ assert github["auth_standard"]["source"] == "publisher"
gitlab = by_id["gitlab"]
assert gitlab["fallback_auth"]["mode"] == "pat_paste"
assert gitlab["auth_standard"]["fallback"] is True
+ assert gitlab["auth_standard"]["ready"] is False
+ assert gitlab["oauth_client_configured"] is False
outlook = by_id["outlook"]
assert outlook["fallback_auth"] is None