Skip to content

Dodaios is an open-source agent OS for your desktop: it runs your coding agents, browser and apps by voice or chat, on your own machine. Formerly Personal Jarvis.

feat(skills): stop shipping the morning routine and retire unedited copies

rubenluetke10-beepea1070ae2d56
diff --git a/docs/product/extend-and-automate/skills.md b/docs/product/extend-and-automate/skills.md
index 9a35d4ef71..58cdb91f2f 100644
--- a/docs/product/extend-and-automate/skills.md
+++ b/docs/product/extend-and-automate/skills.md
@@ -225,7 +225,10 @@ spoken-language filter.
Scheduled triggers can exist in an installed skill, but the scheduler starts
with the voice pipeline, so they do not run in a headless API-only session or
-while Jarvis is stopped. Hotkey definitions can be stored and displayed, but no
+while Jarvis is stopped. No built-in skill carries a schedule: a skill runs on
+its own only when you gave it a schedule yourself. Earlier versions shipped a
+morning-routine skill that ran every morning; an update removes it unless you
+edited it, in which case it stays as your own skill. Hotkey definitions can be stored and displayed, but no
live skill-hotkey handler is connected to them; do not rely on one to start
work.
diff --git a/jarvis/skills/bootstrap.py b/jarvis/skills/bootstrap.py
index 804ed2ffec..62429c2e91 100644
--- a/jarvis/skills/bootstrap.py
+++ b/jarvis/skills/bootstrap.py
@@ -18,6 +18,11 @@ stores the last bootstrapped package version. On a mismatch, missing skills
are copied in again (existing ones are left alone). That's how, e.g., a new
builtin skill added in a later version automatically arrives without
destroying user customizations.
+
+Retirement: a builtin that no longer ships still has its bootstrap copy in
+every existing install. An UNEDITED copy is removed (``_RETIRED_SHIPPED_HASHES``
+recognises every version that shipped); a copy the user changed is theirs and
+stays as an ordinary personal skill.
"""
from __future__ import annotations
@@ -63,6 +68,24 @@ _V2_SHIPPED_HASHES: dict[str, str] = {
"skill-creator": "fce6f964195f51427a850ddf1663e44143585454e3b3b59e1b5f0d2f1a742d33",
}
+#: Builtins that no longer ship, with the SHA-256 of every ``SKILL.md`` version
+#: that did, hashed with LF line endings (``_lf_sha256``) so a CRLF checkout on
+#: Windows matches too. A user copy that still equals one of them was never
+#: edited and is retired; any other copy is the user's own and stays.
+#:
+#: ``morning-routine`` (retired 2026-09-30): its cron trigger ran a full brain
+#: turn at 07:00 every day on every install. Routines are the user's to make.
+_RETIRED_SHIPPED_HASHES: dict[str, frozenset[str]] = {
+ "morning-routine": frozenset({
+ "200f90780791f9fdc43fa59cc24ed0ff2244aac048ccda57d8bca039a09140c7",
+ "2dad2ff68f71c9246e2a94bb62a25b3b665c43170747e0b0921ba0b6f0e3773b",
+ "84dc027591bfbe2c93088c2797c45f94b4bc33d937f56ea49f55b78a8215c600",
+ "881e3c4f924d09b16f47b2f46e6898849b2ae0326119bd74e112d99a6d162109",
+ "d0c22152edb314afe12aaa9a5879affad9b8244cd295dc00d612cb7138caf928",
+ "fdec29775663499c0e771d4e6325ffd73d9d283e9633e0e914654e6a56b9bd29",
+ }),
+}
+
def ensure_user_skills_dir() -> Path:
"""Creates ``user_skills_dir()`` and copies in any missing builtin skills.
@@ -137,6 +160,9 @@ def ensure_user_skills_dir() -> Path:
if added:
upgraded.append(f"{name} (+{','.join(added)})")
+ # Before the manifest is rewritten: its entry is one way a retired copy is
+ # recognised as unedited.
+ retired, kept_retired = _retire_unshipped(dst_root, shipped)
_write_shipped_hashes(dst_root, new_manifest)
_write_version_marker(dst_root)
if copied:
@@ -151,6 +177,12 @@ def ensure_user_skills_dir() -> Path:
if upgraded:
log.info("bootstrap: %d builtin skills got new resources: %s",
len(upgraded), ", ".join(upgraded))
+ if retired:
+ log.info("bootstrap: %d unedited builtin skills no longer ship, removed: %s",
+ len(retired), ", ".join(retired))
+ if kept_retired:
+ log.info("bootstrap: %d retired builtin skills were edited, kept as "
+ "personal skills: %s", len(kept_retired), ", ".join(kept_retired))
return dst_root
@@ -158,6 +190,68 @@ def _sha256(path: Path) -> str:
return hashlib.sha256(path.read_bytes()).hexdigest()
+def _lf_sha256(data: bytes) -> str:
+ """SHA-256 of ``data`` with CRLF folded to LF — the same text on any OS."""
+ return hashlib.sha256(data.replace(b"\r\n", b"\n")).hexdigest()
+
+
+def _retire_unshipped(
+ dst_root: Path, shipped: dict[str, str]
+) -> tuple[list[str], list[str]]:
+ """Remove the unedited user copies of builtins that no longer ship.
+
+ Only the shipped ``SKILL.md`` goes; the folder follows when nothing else is
+ left in it, so a file the user put there is never deleted. Returns
+ ``(retired, kept_because_edited)``.
+ """
+ retired: list[str] = []
+ kept: list[str] = []
+ for name, hashes in _RETIRED_SHIPPED_HASHES.items():
+ if name in BUILTIN_SKILL_NAMES:
+ continue # shipped again: the normal refresh owns it
+ dst = dst_root / name
+ dst_md = dst / "SKILL.md"
+ try:
+ raw = dst_md.read_bytes()
+ except FileNotFoundError:
+ continue
+ except OSError as exc:
+ log.warning("retired builtin skill '%s' unreadable, left alone: %s", name, exc)
+ continue
+ manifest_hash = shipped.get(name)
+ unedited = (
+ manifest_hash is not None and hashlib.sha256(raw).hexdigest() == manifest_hash
+ ) or _lf_sha256(raw) in hashes
+ if not unedited:
+ kept.append(name)
+ continue
+ try:
+ dst_md.unlink()
+ except OSError as exc:
+ log.warning("retire builtin skill '%s' failed: %s", name, exc)
+ continue
+ try:
+ dst.rmdir()
+ except OSError:
+ # Something the user added still lives there; it stays theirs.
+ log.debug("retired skill folder '%s' kept: not empty", name)
+ _forget_prefs(name)
+ retired.append(name)
+ return retired, kept
+
+
+def _forget_prefs(name: str) -> None:
+ """Drop a retired skill's on/off, order and auto-fire entries, as a delete does."""
+ try:
+ from . import prefs
+
+ current = prefs.load_prefs()
+ if name in current.order or name in current.state or name in current.autofire:
+ prefs.remove_skill(name)
+ except Exception as exc: # noqa: BLE001 - a stale pref entry only costs tidiness
+ log.warning("could not drop the preferences of retired skill '%s': %s", name, exc)
+
+
def _load_shipped_hashes(dst_root: Path) -> dict[str, str]:
"""Read the shipped-hashes manifest; empty dict when absent/corrupt."""
try:
diff --git a/jarvis/skills/builtin/__init__.py b/jarvis/skills/builtin/__init__.py
index 0ddafda639..c58196e41a 100644
--- a/jarvis/skills/builtin/__init__.py
+++ b/jarvis/skills/builtin/__init__.py
@@ -8,7 +8,6 @@ copied into `user_skills_dir()` by
that location.
List of bundled skills:
- - morning-routine calendar / mail / weather morning briefing
- deep-work-mode DND + focus timer via hotkey/voice
- memory-save "remember that ..." saved to memory-MCP
- skill-creator meta-skill for building further skills
@@ -53,7 +52,10 @@ _PLUGIN_PAIRED_SKILLS: tuple[str, ...] = (
)
BUILTIN_SKILL_NAMES: tuple[str, ...] = (
- "morning-routine",
+ # No shipped routine: a daily briefing ran a full brain turn at 07:00 on
+ # every install, and routines are the user's own to make (2026-09-30).
+ # The bootstrap retires an unedited copy of the old ``morning-routine``
+ # (``jarvis.skills.bootstrap._RETIRED_SHIPPED_HASHES``).
"deep-work-mode",
"memory-save",
"skill-creator",
diff --git a/jarvis/skills/builtin/morning-routine/SKILL.md b/jarvis/skills/builtin/morning-routine/SKILL.md
deleted file mode 100644
index 4e85374611..0000000000
--- a/jarvis/skills/builtin/morning-routine/SKILL.md
+++ /dev/null
@@ -1,77 +0,0 @@
----
-schema_version: "1"
-name: morning-routine
-version: "2.0.0"
-description: >-
- Delivers the user's spoken morning briefing: today's calendar, unread
- email summary, weather, and anything urgent. Use when the user asks for
- a morning briefing or day overview, says good morning, starts their day,
- or asks "what's on today" / "wie sieht mein Tag aus".
-when_to_use: >-
- Use when the user says "starte die Morgenroutine", "guten Morgen",
- "good morning", "morning briefing", "Tagesueberblick", "what's my day
- looking like", or asks for their schedule first thing in the day.
-category: productivity
-tags: [daily, routine, mail, calendar, weather]
-author: builtin
-license: Apache-2.0
-triggers:
- - type: voice
- pattern: "(morgenroutine|morgen[-\\s]?briefing|morning routine|morning briefing|start day|tages(ue|ü)berblick)"
- language: [de, en]
- - type: voice
- pattern: "^(guten morgen|good morning)[.!\\s]*$"
- language: [de, en]
- - type: schedule
- cron: "0 7 * * *"
- language: [de, en]
-requires_tools: []
-risk_policy:
- default_tier: monitor
-config:
- email_limit: 5
- calendar_days_ahead: 1
- weather_location: "Berlin"
- weather_format: metric
-token_budget_estimate: 3000
-execution: inline
----
-
-# Morning Routine
-
-Deliver a short spoken morning briefing — an overview of the day in under
-30 seconds. No walls of text, no reading out 20 emails. Work through the
-steps below with the tools you actually have; skip a step gracefully
-(one short clause, e.g. "calendar is not connected yet") when its
-integration is unavailable. Never invent data.
-
-## Steps
-
-1. **Calendar.** If a calendar plugin or tool is connected (e.g. a
- `google-calendar/...` tool), fetch today's events
- ({{ config.calendar_days_ahead }} day ahead).
- - 0 events: say the calendar is free today.
- - 1 event: name it with its time.
- - Several: give the count and the next one with its time.
- - If the next event starts within 60 minutes, add a heads-up.
-
-2. **Email.** If the Gmail plugin is connected (tools namespaced
- `gmail/...`), check unread mail (limit {{ config.email_limit }}).
- - 0 unread: "inbox is empty".
- - Up to 3: mention sender and subject briefly.
- - More: give the count and the 1-2 most important senders.
- Never read full bodies; never read out secrets or codes.
-
-3. **Weather.** If a web search tool is available, get today's weather for
- {{ config.weather_location }} ({{ config.weather_format }}). One clause:
- condition, high/low. Skip silently if unavailable.
-
-4. **Anything urgent.** If a running mission or an unread important
- notification is visible to you, mention it in one sentence.
-
-## Answer format
-
-Compose ONE flowing, friendly briefing of 3-5 short sentences — natural
-spoken language, no lists, no markdown, no tool names. End with the most
-actionable item (e.g. the next appointment). Answer in the user's
-language.
diff --git a/scripts/skill_routing_eval.py b/scripts/skill_routing_eval.py
index a0b6b44f5f..bcd7cab6ca 100644
--- a/scripts/skill_routing_eval.py
+++ b/scripts/skill_routing_eval.py
@@ -50,7 +50,10 @@ if sys.platform == "win32":
# must NOT fire any skill. Every positive paraphrase avoids the skill's literal
# voice-trigger tokens, so only the model-judged path can fire it.
GOLDEN: list[tuple[str, str | None]] = [
- ("fass mir mal kurz zusammen was heute alles ansteht", "morning-routine"),
+ # No builtin owns a day overview since the shipped morning routine was
+ # retired (2026-09-30), so this one must fire nothing.
+ ("fass mir mal kurz zusammen was heute alles ansteht", # i18n-allow: simulated German user utterance under test (negative control)
+ None),
("ich brauch jetzt ruhe zum arbeiten, blende mir die ablenkungen aus", # i18n-allow: simulated German user utterance under test
"deep-work-mode"),
("schau mal ob heute schon was wichtiges per e-mail reingekommen ist", # i18n-allow: simulated German user utterance under test
diff --git a/tests/fixtures/skill_routing/BASELINE.json b/tests/fixtures/skill_routing/BASELINE.json
index 5fb0ac8747..850bff1079 100644
--- a/tests/fixtures/skill_routing/BASELINE.json
+++ b/tests/fixtures/skill_routing/BASELINE.json
@@ -4,13 +4,12 @@
"relevance_recall": 1.0,
"false_fires": 0,
"known_gaps": 2,
- "positives_scored": 79,
+ "positives_scored": 81,
"negatives": 26,
"per_skill": {
"cli-gcloud": 1.0,
"control-api": 0.0,
"deep-work-mode": 1.0,
- "morning-routine": 1.0,
"plugin-airtable": 1.0,
"plugin-asana": 1.0,
"plugin-cal_com": 1.0,
@@ -23,6 +22,7 @@
"plugin-gmail": 1.0,
"plugin-google_calendar": 1.0,
"plugin-google_drive": 0.5,
+ "plugin-higgsfield": 1.0,
"plugin-home_assistant": 1.0,
"plugin-linear": 1.0,
"plugin-notion": 1.0,
diff --git a/tests/fixtures/skill_routing/golden.yaml b/tests/fixtures/skill_routing/golden.yaml
index f685c158c8..2988a654d9 100644
--- a/tests/fixtures/skill_routing/golden.yaml
+++ b/tests/fixtures/skill_routing/golden.yaml
@@ -56,27 +56,6 @@ skills:
- text: "erzaehl mir was ueber konzentration und produktivitaet"
reason: knowledge question, no activation intent
- morning-routine:
- positives:
- - text: "gib mir bitte den tagesueberblick"
- channel: trigger
- lang: de
- min_band: narrow
- source: authored
- - text: "mach mir mein morgen briefing"
- channel: trigger
- lang: de
- min_band: narrow
- source: authored
- - text: "run my morning briefing please"
- channel: trigger
- lang: en
- min_band: narrow
- source: authored
- hard_negatives:
- - text: "was ist eine morgenroutine ueberhaupt"
- reason: definitional question
-
plugin-gmail:
positives:
- text: "lies mir meine neuen nachrichten im posteingang vor"
diff --git a/tests/integration/test_phase1c_e2e.py b/tests/integration/test_phase1c_e2e.py
index 245007898c..85012cbcdd 100644
--- a/tests/integration/test_phase1c_e2e.py
+++ b/tests/integration/test_phase1c_e2e.py
@@ -21,33 +21,34 @@ def bus() -> EventBus:
return EventBus()
-def test_registry_loads_all_3_builtin_skills(builtin_root: Path, bus: EventBus) -> None:
+def test_registry_loads_the_base_builtin_skills(builtin_root: Path, bus: EventBus) -> None:
reg = SkillRegistry(builtin_root, bus)
reg.reload_sync()
names = [s.frontmatter.name for s in reg.list() if s.frontmatter is not None]
- assert "morning-routine" in names
assert "deep-work-mode" in names
assert "memory-save" in names
+ # Retired 2026-09-30: no shipped routine runs by itself.
+ assert "morning-routine" not in names
def test_trigger_matcher_matches_voice_de(builtin_root: Path, bus: EventBus) -> None:
reg = SkillRegistry(builtin_root, bus)
reg.reload_sync()
matcher = TriggerMatcher(reg)
- skill = matcher.match_voice("guten morgen", lang="de")
+ skill = matcher.match_voice("konzentrationsmodus", lang="de")
assert skill is not None
assert skill.frontmatter is not None
- assert skill.frontmatter.name == "morning-routine"
+ assert skill.frontmatter.name == "deep-work-mode"
def test_trigger_matcher_matches_voice_en(builtin_root: Path, bus: EventBus) -> None:
reg = SkillRegistry(builtin_root, bus)
reg.reload_sync()
matcher = TriggerMatcher(reg)
- skill = matcher.match_voice("good morning", lang="en")
+ skill = matcher.match_voice("deep work", lang="en")
assert skill is not None
assert skill.frontmatter is not None
- assert skill.frontmatter.name == "morning-routine"
+ assert skill.frontmatter.name == "deep-work-mode"
def test_trigger_matcher_hotkey_deep_work(builtin_root: Path, bus: EventBus) -> None:
diff --git a/tests/integration/test_skill_trigger_e2e.py b/tests/integration/test_skill_trigger_e2e.py
index c54d1550ba..969ac85112 100644
--- a/tests/integration/test_skill_trigger_e2e.py
+++ b/tests/integration/test_skill_trigger_e2e.py
@@ -24,15 +24,25 @@ async def test_voice_match_de_en(builtin_root: Path) -> None:
reg = SkillRegistry(builtin_root, bus)
reg.reload_sync()
matcher = TriggerMatcher(reg)
- de = matcher.match_voice("guten morgen", lang="de")
- en = matcher.match_voice("good morning", lang="en")
+ de = matcher.match_voice("fokusmodus", lang="de")
+ en = matcher.match_voice("deep work mode", lang="en")
assert de is not None and de.frontmatter is not None
assert en is not None and en.frontmatter is not None
- assert de.frontmatter.name == "morning-routine"
- assert en.frontmatter.name == "morning-routine"
+ assert de.frontmatter.name == "deep-work-mode"
+ assert en.frontmatter.name == "deep-work-mode"
assert de.frontmatter.name == en.frontmatter.name
+async def test_a_greeting_fires_no_shipped_skill(builtin_root: Path) -> None:
+ """The shipped morning routine is retired (2026-09-30): "good morning" is
+ smalltalk again, never a daily briefing nobody asked for."""
+ reg = SkillRegistry(builtin_root, EventBus())
+ reg.reload_sync()
+ matcher = TriggerMatcher(reg)
+ assert matcher.match_voice("guten morgen", lang="de") is None
+ assert matcher.match_voice("good morning", lang="en") is None
+
+
async def test_cron_scheduler_graceful_without_croniter(
monkeypatch: pytest.MonkeyPatch, builtin_root: Path
) -> None:
diff --git a/tests/unit/skills/test_bootstrap_refresh.py b/tests/unit/skills/test_bootstrap_refresh.py
index 8e2427558c..b181ae2c12 100644
--- a/tests/unit/skills/test_bootstrap_refresh.py
+++ b/tests/unit/skills/test_bootstrap_refresh.py
@@ -107,3 +107,106 @@ def test_up_to_date_copy_untouched(env) -> None:
bootstrap.ensure_user_skills_dir()
assert (old / "SKILL.md").stat().st_mtime_ns == before_mtime
+
+
+# ----------------------------------------------------------------------
+# Retirement: a builtin that no longer ships (morning-routine, 2026-09-30)
+# ----------------------------------------------------------------------
+
+_SHIPPED_ROUTINE = "---\nname: retired-demo\n---\nshipped body\n"
+
+
+def retired(env, monkeypatch: pytest.MonkeyPatch):
+ """``retired-demo`` shipped once and is gone from BUILTIN_SKILL_NAMES."""
+ _, dst_root = env
+ lf_hash = hashlib.sha256(_SHIPPED_ROUTINE.encode()).hexdigest()
+ monkeypatch.setattr(
+ bootstrap, "_RETIRED_SHIPPED_HASHES", {"retired-demo": frozenset({lf_hash})}
+ )
+ forgotten: list[str] = []
+ monkeypatch.setattr(bootstrap, "_forget_prefs", forgotten.append)
+ return dst_root, forgotten
+
+
+def _install_copy(dst_root: Path, content: bytes) -> Path:
+ folder = dst_root / "retired-demo"
+ folder.mkdir()
+ (folder / "SKILL.md").write_bytes(content)
+ return folder
+
+
+def test_the_retired_routine_is_no_longer_shipped() -> None:
+ from jarvis.skills.builtin import BUILTIN_SKILL_NAMES, BUILTIN_SKILLS_DIR
+
+ assert "morning-routine" not in BUILTIN_SKILL_NAMES
+ assert not (BUILTIN_SKILLS_DIR / "morning-routine").exists()
+ shipped_versions = bootstrap._RETIRED_SHIPPED_HASHES["morning-routine"]
+ # The v2-era copy every older install carries is recognised as unedited.
+ assert bootstrap._V2_SHIPPED_HASHES["morning-routine"] in shipped_versions
+
+
+def test_an_unedited_copy_of_a_retired_builtin_is_removed(retired) -> None:
+ dst_root, forgotten = retired
+ folder = _install_copy(dst_root, _SHIPPED_ROUTINE.encode())
+
+ bootstrap.ensure_user_skills_dir()
+
+ assert not folder.exists()
+ assert forgotten == ["retired-demo"]
+
+
+def test_a_crlf_checkout_of_the_retired_builtin_counts_as_unedited(retired) -> None:
+ dst_root, _ = retired
+ folder = _install_copy(dst_root, _SHIPPED_ROUTINE.replace("\n", "\r\n").encode())
+
+ bootstrap.ensure_user_skills_dir()
+
+ assert not folder.exists()
+
+
+def test_the_manifest_entry_also_proves_a_copy_unedited(retired, monkeypatch) -> None:
+ dst_root, _ = retired
+ monkeypatch.setattr(bootstrap, "_RETIRED_SHIPPED_HASHES", {"retired-demo": frozenset()})
+ content = b"a version this map never listed"
+ folder = _install_copy(dst_root, content)
+ (dst_root / ".shipped-hashes.json").write_text(
+ json.dumps({"retired-demo": hashlib.sha256(content).hexdigest()}), encoding="utf-8"
+ )
+
+ bootstrap.ensure_user_skills_dir()
+
+ assert not folder.exists()
+ manifest = json.loads((dst_root / ".shipped-hashes.json").read_text(encoding="utf-8"))
+ assert "retired-demo" not in manifest
+
+
+def test_an_edited_copy_of_a_retired_builtin_stays_the_users(retired) -> None:
+ dst_root, forgotten = retired
+ folder = _install_copy(dst_root, b"---\nname: retired-demo\n---\nmy own briefing\n")
+
+ bootstrap.ensure_user_skills_dir()
+
+ assert (folder / "SKILL.md").read_bytes().endswith(b"my own briefing\n")
+ assert forgotten == []
+
+
+def test_a_file_the_user_added_survives_the_retirement(retired) -> None:
+ dst_root, _ = retired
+ folder = _install_copy(dst_root, _SHIPPED_ROUTINE.encode())
+ (folder / "notes.txt").write_text("mine", encoding="utf-8")
+
+ bootstrap.ensure_user_skills_dir()
+
+ assert not (folder / "SKILL.md").exists()
+ assert (folder / "notes.txt").read_text(encoding="utf-8") == "mine"
+
+
+def test_a_retired_name_that_ships_again_is_not_retired(retired, monkeypatch) -> None:
+ dst_root, _ = retired
+ monkeypatch.setattr(bootstrap, "BUILTIN_SKILL_NAMES", ("demo-skill", "retired-demo"))
+ folder = _install_copy(dst_root, _SHIPPED_ROUTINE.encode())
+
+ bootstrap.ensure_user_skills_dir()
+
+ assert (folder / "SKILL.md").exists()
diff --git a/tests/unit/skills/test_builtin_skills.py b/tests/unit/skills/test_builtin_skills.py
index 14e97e3395..19218a0068 100644
--- a/tests/unit/skills/test_builtin_skills.py
+++ b/tests/unit/skills/test_builtin_skills.py
@@ -89,7 +89,6 @@ def test_expected_builtin_count() -> None:
from jarvis.skills.builtin import _PLUGIN_PAIRED_SKILLS
base = {
- "morning-routine",
"deep-work-mode",
"memory-save",
"skill-creator",
@@ -162,19 +161,15 @@ def test_cli_gcloud_specifics() -> None:
assert fm.intent_objects == []
-def test_morning_routine_specifics() -> None:
- """Instruction-skill model (2026-06-09): no fictional MCP tool names in
- requires_tools — the body instructs the brain to use whatever calendar/
- mail/web tools are actually connected."""
- skill = parse_skill(builtin_skill_path("morning-routine"))
[email protected]("name", list(BUILTIN_SKILL_NAMES))
+def test_no_builtin_skill_runs_on_a_schedule(name: str) -> None:
+ """Nothing shipped runs by itself (2026-09-30): the retired morning-routine
+ fired a full brain turn at 07:00 on every install. A schedule is a routine,
+ and routines are the user's own to make."""
+ skill = parse_skill(builtin_skill_path(name))
fm = skill.frontmatter
assert fm is not None
- trig_types = {t.type for t in fm.triggers}
- assert "voice" in trig_types
- assert "schedule" in trig_types
- assert fm.requires_tools == []
- assert fm.execution == "inline"
- assert fm.config.get("weather_location") == "Berlin"
+ assert "schedule" not in {t.type for t in fm.triggers}
def test_deep_work_mode_specifics() -> None:
diff --git a/tests/unit/skills/test_prompt_injection.py b/tests/unit/skills/test_prompt_injection.py
index 7bbd18577f..833a49237e 100644
--- a/tests/unit/skills/test_prompt_injection.py
+++ b/tests/unit/skills/test_prompt_injection.py
@@ -325,8 +325,8 @@ def test_user_skills_render_before_builtins() -> None:
"""User-authored skills sort before shipped builtins in the listing."""
registry = _FakeRegistry(skills=[
# Real builtin name → _is_builtin() classifies it as shipped.
- _FakeSkill(name="morning-routine", frontmatter=_FakeFrontmatter(
- description="builtin briefing")),
+ _FakeSkill(name="memory-save", frontmatter=_FakeFrontmatter(
+ description="builtin memory")),
_FakeSkill(name="my-own-skill", frontmatter=_FakeFrontmatter(
description="user authored")),
])
@@ -334,7 +334,7 @@ def test_user_skills_render_before_builtins() -> None:
out = render_available_skills_section(registry) # type: ignore[arg-type]
assert out is not None
- assert out.index("- `my-own-skill`") < out.index("- `morning-routine`")
+ assert out.index("- `my-own-skill`") < out.index("- `memory-save`")
def test_builtins_fold_before_user_skills_on_overflow() -> None:
@@ -342,8 +342,8 @@ def test_builtins_fold_before_user_skills_on_overflow() -> None:
own skills keep their described bullets.
"""
registry = _FakeRegistry(skills=[
- _FakeSkill(name="morning-routine", frontmatter=_FakeFrontmatter(
- description="builtin briefing")),
+ _FakeSkill(name="memory-save", frontmatter=_FakeFrontmatter(
+ description="builtin memory")),
_FakeSkill(name="deep-work-mode", frontmatter=_FakeFrontmatter(
description="builtin focus")),
_FakeSkill(name="my-own-skill", frontmatter=_FakeFrontmatter(
@@ -365,7 +365,7 @@ def test_budget_eviction_prefers_builtins_over_user_skills() -> None:
"""
registry = _FakeRegistry(skills=[
_FakeSkillWithMtime(
- name="morning-routine",
+ name="memory-save",
frontmatter=_FakeFrontmatter(description="B" * 200),
mtime=100.0, # newer than the user skill
),
@@ -382,9 +382,9 @@ def test_budget_eviction_prefers_builtins_over_user_skills() -> None:
assert out is not None
assert "- `my-own-skill`" in out
- assert "- `morning-routine` — " not in out
+ assert "- `memory-save` — " not in out
tail = next(ln for ln in out.splitlines() if ln.startswith("- …"))
- assert "`morning-routine`" in tail
+ assert "`memory-save`" in tail
# ----------------------------------------------------------------------
diff --git a/tests/unit/skills/test_trigger_matcher.py b/tests/unit/skills/test_trigger_matcher.py
index 8e6c04b045..6c9d20feb5 100644
--- a/tests/unit/skills/test_trigger_matcher.py
+++ b/tests/unit/skills/test_trigger_matcher.py
@@ -290,13 +290,13 @@ def test_user_skill_wins_tie_against_builtin_name(tmp_path: Path) -> None:
"""A voice-authored replacement must beat the bundled skill on the same phrase."""
_write_skill(
tmp_path,
- "morning-routine",
+ "deep-work-mode",
"""---
schema_version: "1"
-name: morning-routine
+name: deep-work-mode
triggers:
- type: voice
- pattern: "(morning routine|morgenroutine)"
+ pattern: "(focus mode|fokusmodus)"
language: ["de", "en"]
---
body
@@ -304,13 +304,13 @@ body
)
_write_skill(
tmp_path,
- "morning-routine-2",
+ "deep-work-mode-2",
"""---
schema_version: "1"
-name: Morning Routine 2
+name: Deep Work Mode 2
triggers:
- type: voice
- pattern: "(morning routine|morgenroutine|starte morning routine)"
+ pattern: "(focus mode|fokusmodus|starte focus mode)"
language: ["de", "en"]
---
body
@@ -319,9 +319,9 @@ body
reg = SkillRegistry(tmp_path)
reg.reload_sync()
m = TriggerMatcher(reg)
- sk = m.match_voice("Morning Routine", lang="en")
+ sk = m.match_voice("Focus Mode", lang="en")
assert sk is not None
- assert sk.name == "Morning Routine 2"
- sk2 = m.match_voice("Morgenroutine", lang="de")
+ assert sk.name == "Deep Work Mode 2"
+ sk2 = m.match_voice("Fokusmodus", lang="de")
assert sk2 is not None
- assert sk2.name == "Morning Routine 2"
+ assert sk2.name == "Deep Work Mode 2"
diff --git a/tests/unit/web/test_skills_import_local_route.py b/tests/unit/web/test_skills_import_local_route.py
index 4cd8888087..2ea98185b0 100644
--- a/tests/unit/web/test_skills_import_local_route.py
+++ b/tests/unit/web/test_skills_import_local_route.py
@@ -132,7 +132,7 @@ async def test_name_collision_is_a_409(
async def test_builtin_name_is_refused(
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
) -> None:
- content = _CLAUDE_CODE_STYLE.replace("my-own-skill", "morning-routine")
+ content = _CLAUDE_CODE_STYLE.replace("my-own-skill", "deep-work-mode")
src = _write_source(tmp_path, content)
_, _, request = _setup(tmp_path, monkeypatch)