Skip to content

Dodaios is an open-source agent OS for your desktop: it runs your coding agents, browser and apps by voice or chat, on your own machine. Formerly Personal Jarvis.

fix(wiki): hide the orbit rings — the paths stay invisible

Haraldef060de31053
diff --git a/jarvis/ui/web/frontend/src/components/wiki/WikiGraph3D.tsx b/jarvis/ui/web/frontend/src/components/wiki/WikiGraph3D.tsx
index b5ec6d7019..c9e2d1fe91 100644
--- a/jarvis/ui/web/frontend/src/components/wiki/WikiGraph3D.tsx
+++ b/jarvis/ui/web/frontend/src/components/wiki/WikiGraph3D.tsx
@@ -51,7 +51,6 @@ import {
import { carryOverPositions, pinPivotAtOrigin } from "@/lib/graphContinuity";
import {
hopsFromHub,
- occupiedShells,
seatAllOnShells,
shellRadius,
snapToShell,
@@ -224,12 +223,6 @@ export function WikiGraph3D({
}, [graphData, pivotSlug]);
const hopsRef = useRef(hops);
hopsRef.current = hops;
- const shells = useMemo(
- () => (pivotSlug ? occupiedShells(hops, pivotSlug) : []),
- [hops, pivotSlug],
- );
- const shellsRef = useRef(shells);
- shellsRef.current = shells;
const decorKeyRef = useRef("");
const reducedMotion = useMemo(
() =>
@@ -642,9 +635,9 @@ export function WikiGraph3D({
const graph = graphRef.current as unknown as { scene?: () => Scene };
const scene = graph.scene?.();
if (!scene) return;
- const key = `${themeRef.current}:${shellsRef.current.join(",")}`;
+ const key = themeRef.current;
if (decorKeyRef.current === key) return;
- syncSystemDecor(scene, themeRef.current, shellsRef.current);
+ syncSystemDecor(scene, themeRef.current);
decorKeyRef.current = key;
}}
onEngineStop={reframe}
diff --git a/jarvis/ui/web/frontend/src/components/wiki/wikiSystem.test.ts b/jarvis/ui/web/frontend/src/components/wiki/wikiSystem.test.ts
index 34c8b51d09..5566bfb203 100644
--- a/jarvis/ui/web/frontend/src/components/wiki/wikiSystem.test.ts
+++ b/jarvis/ui/web/frontend/src/components/wiki/wikiSystem.test.ts
@@ -9,6 +9,6 @@ describe("sunPalette", () => {
expect(dark.core).toBe(0xffd60a);
expect(light.core).toBe(0xa86b00);
expect(dark.core).not.toBe(light.core);
- expect(dark.ringOpacity).toBeLessThan(light.ringOpacity);
+ expect(dark.lightIntensity).toBeGreaterThan(light.lightIntensity);
});
});
diff --git a/jarvis/ui/web/frontend/src/components/wiki/wikiSystem.ts b/jarvis/ui/web/frontend/src/components/wiki/wikiSystem.ts
index 2de352805d..724f967631 100644
--- a/jarvis/ui/web/frontend/src/components/wiki/wikiSystem.ts
+++ b/jarvis/ui/web/frontend/src/components/wiki/wikiSystem.ts
@@ -1,16 +1,13 @@
/**
- * The sun, its corona, the dust rings and the light they throw.
+ * The sun, its corona, and the light they throw.
*
* Colours come from a per-appearance table — signal-yellow on dark, gold on
* light — never one hex on both grounds (CLOUD.md frontend theming).
*/
import {
AdditiveBlending,
- BufferGeometry,
CanvasTexture,
Group,
- Line,
- LineBasicMaterial,
Mesh,
MeshBasicMaterial,
NormalBlending,
@@ -18,7 +15,6 @@ import {
SphereGeometry,
Sprite,
SpriteMaterial,
- Vector3,
type Scene,
type Texture,
} from "three";
@@ -30,8 +26,6 @@ export interface SunPalette {
core: number;
glowRgb: string;
light: number;
- ring: number;
- ringOpacity: number;
lightIntensity: number;
coronaScale: number;
}
@@ -41,8 +35,6 @@ const PALETTE: Record<Theme, SunPalette> = {
core: 0xffd60a,
glowRgb: "255, 214, 10",
light: 0xffe680,
- ring: 0xffe08a,
- ringOpacity: 0.11,
lightIntensity: 2.1,
coronaScale: 6.4,
},
@@ -50,8 +42,6 @@ const PALETTE: Record<Theme, SunPalette> = {
core: 0xa86b00,
glowRgb: "168, 107, 0",
light: 0xc49214,
- ring: 0x8a5a00,
- ringOpacity: 0.2,
lightIntensity: 1.15,
coronaScale: 5.2,
},
@@ -62,6 +52,7 @@ export function sunPalette(theme: Theme): SunPalette {
}
const SUN_LIGHT_NAME = "wiki-sun-light";
+/** Leftover name from the drawn rings — still stripped so a live reload cleans them. */
const SUN_RING_NAME = "wiki-orbit-ring";
let glowCache: { theme: Theme; texture: Texture } | null = null;
@@ -131,44 +122,17 @@ export function buildSunObject(
return group;
}
-function makeRing(radius: number, tilt: number, palette: SunPalette): Line {
- const points: Vector3[] = [];
- const steps = 160;
- for (let i = 0; i <= steps; i++) {
- const angle = (i / steps) * Math.PI * 2;
- points.push(new Vector3(Math.cos(angle) * radius, 0, Math.sin(angle) * radius));
- }
- const line = new Line(
- new BufferGeometry().setFromPoints(points),
- new LineBasicMaterial({
- color: palette.ring,
- transparent: true,
- opacity: palette.ringOpacity,
- depthWrite: false,
- }),
- );
- line.name = SUN_RING_NAME;
- line.rotation.x = tilt;
- line.rotation.z = tilt * 0.35;
- return line;
-}
-
/**
- * Keep the scene's sun-light and dust rings in step with the theme and the
- * shells that currently have pages on them. Named objects are replaced, never
- * stacked, so a data refresh does not leave a trail of rings behind.
+ * Keep the scene's sun-light in step with the theme. Old dust rings (from a
+ * previous build) are stripped and never put back — the orbits stay invisible.
*/
-export function syncSystemDecor(
- scene: Scene,
- theme: Theme,
- shells: readonly number[],
-): void {
+export function syncSystemDecor(scene: Scene, theme: Theme): void {
const palette = sunPalette(theme);
- const stale: Array<Line | PointLight> = [];
+ const stale: PointLight[] = [];
scene.traverse((obj) => {
if (obj.name === SUN_LIGHT_NAME || obj.name === SUN_RING_NAME) {
- stale.push(obj as Line | PointLight);
+ stale.push(obj as PointLight);
}
});
for (const obj of stale) {
@@ -179,11 +143,4 @@ export function syncSystemDecor(
light.name = SUN_LIGHT_NAME;
light.position.set(0, 0, 0);
scene.add(light);
-
- // At most three rings — one per occupied band, nearest first. A ring per
- // page would be the railroad the seating is designed not to be.
- const tilts = [0.14, -0.09, 0.2];
- shells.slice(0, 3).forEach((radius, i) => {
- scene.add(makeRing(radius, tilts[i] ?? 0.1, palette));
- });
}