Open source CapCut alternative.
TypeScript
fix(site): authenticate cron jobs at request time
David Le69103ac978cd
diff --git a/site/package.json b/site/package.jsonindex 4a00d620..a6969fb5 100644--- a/site/package.json+++ b/site/package.json@@ -9,7 +9,7 @@],"scripts": {"dev": "next dev",- "build": "next build",+ "build": "next build && node scripts/check-cron-routes.mjs","start": "next start","lint": "node --max-old-space-size=8192 node_modules/eslint/bin/eslint.js","firewall:check": "node scripts/firewall.mjs check",diff --git a/site/scripts/check-cron-routes.mjs b/site/scripts/check-cron-routes.mjsnew file mode 100644index 00000000..3065d113--- /dev/null+++ b/site/scripts/check-cron-routes.mjs@@ -0,0 +1,14 @@+import { readFileSync } from "node:fs";++// Cron handlers must execute on every invocation, including builds without+// runtime secrets. A prerendered response would consume the scheduled call.+const readJson = path => JSON.parse(readFileSync(new URL(path, import.meta.url), "utf8"));+const { crons } = readJson("../vercel.json");+const { routes } = readJson("../.next/prerender-manifest.json");+const cached = crons.filter(({ path }) => Object.hasOwn(routes, path));++if (cached.length) {+ throw new Error(`Cron routes were prerendered: ${cached.map(({ path }) => path).join(", ")}`);+}++console.log(`Verified ${crons.length} cron routes execute at request time.`);diff --git a/site/src/app/api/analytics/run/route.ts b/site/src/app/api/analytics/run/route.tsindex 43906a51..2812f1f7 100644--- a/site/src/app/api/analytics/run/route.ts+++ b/site/src/app/api/analytics/run/route.ts@@ -11,6 +11,6 @@ export const maxDuration = 300;// bearer token; manual runs — the dashboard's Run button and per-day// {day, force} retriggers — go through POST /api/jobs.export const GET = async (request: NextRequest) => {- if (!isVercelCron(request)) return notFoundResponse();+ if (!(await isVercelCron(request))) return notFoundResponse();return NextResponse.json(await enqueueJob("analytics-daily", {}, "vercel-cron"));};diff --git a/site/src/app/api/chatgpt/gc/route.ts b/site/src/app/api/chatgpt/gc/route.tsindex 8c3c7fbe..ac3ccb3c 100644--- a/site/src/app/api/chatgpt/gc/route.ts+++ b/site/src/app/api/chatgpt/gc/route.ts@@ -4,4 +4,5 @@ import { cleanupConnections } from "@/clients/chatgpt/server/cleanup";const admin = withSuperUser(cleanupConnections);/** GET /api/chatgpt/gc: expire OAuth families and consent challenges daily. */-export const GET = (request: NextRequest) => isVercelCron(request) ? cleanupConnections() : admin(request);+export const GET = async (request: NextRequest) =>+ (await isVercelCron(request)) ? cleanupConnections() : admin(request);diff --git a/site/src/app/api/credits/expire/route.ts b/site/src/app/api/credits/expire/route.tsindex 0abb4999..eeab36ae 100644--- a/site/src/app/api/credits/expire/route.ts+++ b/site/src/app/api/credits/expire/route.ts@@ -10,6 +10,6 @@ export const maxDuration = 300;// The nightly credit-expiry sweep. Vercel's cron authenticates with the// CRON_SECRET bearer token; a manual run goes through POST /api/jobs.export const GET = async (request: NextRequest) => {- if (!isVercelCron(request)) return notFoundResponse();+ if (!(await isVercelCron(request))) return notFoundResponse();return NextResponse.json(await enqueueJob("credit-expiry", {}, "vercel-cron"));};diff --git a/site/src/app/api/credits/expiry-notices/route.ts b/site/src/app/api/credits/expiry-notices/route.tsindex 1b1180ba..4897e32b 100644--- a/site/src/app/api/credits/expiry-notices/route.ts+++ b/site/src/app/api/credits/expiry-notices/route.ts@@ -10,6 +10,6 @@ export const maxDuration = 300;// The daily credit-expiry notice. Vercel's cron authenticates with the// CRON_SECRET bearer token; a manual run goes through POST /api/jobs.export const GET = async (request: NextRequest) => {- if (!isVercelCron(request)) return notFoundResponse();+ if (!(await isVercelCron(request))) return notFoundResponse();return NextResponse.json(await enqueueJob("credit-expiry-notice", {}, "vercel-cron"));};diff --git a/site/src/app/api/cut-cloud/[[...slug]]/route.ts b/site/src/app/api/cut-cloud/[[...slug]]/route.tsindex 21cd66fd..990f1c2b 100644--- a/site/src/app/api/cut-cloud/[[...slug]]/route.ts+++ b/site/src/app/api/cut-cloud/[[...slug]]/route.ts@@ -26,8 +26,8 @@ const handle = withDonkeyAuth((request) => cutCloudCatchAll(request), {// The daily GC cron has no session; Vercel authenticates its invocations with// the CRON_SECRET bearer token. Everything else goes through auth (a superuser// can also GET /gc directly).-export const GET = (request: NextRequest) =>- new URL(request.url).pathname === "/api/cut-cloud/gc" && isVercelCron(request)+export const GET = async (request: NextRequest) =>+ new URL(request.url).pathname === "/api/cut-cloud/gc" && (await isVercelCron(request))? runGc(): handle(request);export const POST = handle;diff --git a/site/src/app/api/experiments/results/route.ts b/site/src/app/api/experiments/results/route.tsindex f1ebe624..68268513 100644--- a/site/src/app/api/experiments/results/route.ts+++ b/site/src/app/api/experiments/results/route.ts@@ -11,6 +11,6 @@ export const maxDuration = 300;// authenticates with the CRON_SECRET bearer token; a run for one experiment// starts from su through POST /api/jobs.export const GET = async (request: NextRequest) => {- if (!isVercelCron(request)) return notFoundResponse();+ if (!(await isVercelCron(request))) return notFoundResponse();return NextResponse.json(await enqueueJob("experiment-results", {}, "vercel-cron"));};diff --git a/site/src/app/api/marketing/outreach/scan/route.ts b/site/src/app/api/marketing/outreach/scan/route.tsindex 8d996094..b89e33c1 100644--- a/site/src/app/api/marketing/outreach/scan/route.ts+++ b/site/src/app/api/marketing/outreach/scan/route.ts@@ -11,6 +11,6 @@ export const maxDuration = 300;// bearer token; the Outreach tab's Scan now button goes through the super-user// POST /api/jobs instead.export const GET = async (request: NextRequest) => {- if (!isVercelCron(request)) return notFoundResponse();+ if (!(await isVercelCron(request))) return notFoundResponse();return NextResponse.json(await enqueueJob("outreach-scan", {}, "vercel-cron"));};diff --git a/site/src/lib/donkey-api-auth.ts b/site/src/lib/donkey-api-auth.tsindex 984fc4bc..aed51664 100644--- a/site/src/lib/donkey-api-auth.ts+++ b/site/src/lib/donkey-api-auth.ts@@ -1,6 +1,6 @@import { checkInMemoryRateLimit, rateLimitResponse } from "@/lib/inference/rate-limit";import { createHash, timingSafeEqual } from "node:crypto";-import { type NextRequest, NextResponse } from "next/server";+import { connection, type NextRequest, NextResponse } from "next/server";import { auth } from "@/lib/auth";import { isDonkeySuperUser } from "@/lib/super-user";@@ -72,7 +72,10 @@ export function forbiddenResponse() {// True when the request comes from Vercel's cron scheduler, which sends the// project's CRON_SECRET env var as a bearer token on every invocation.-export function isVercelCron(request: Request): boolean {+export async function isVercelCron(request: Request): Promise<boolean> {+ // Runtime secrets are absent during prebuilt deploys. Authenticate only+ // after a request arrives so a missing build secret cannot cache a 404.+ await connection();const secret = process.env.CRON_SECRET;return !!secret && request.headers.get("authorization") === `Bearer ${secret}`;}