Skip to content

Open source CapCut alternative.

TypeScript

feat(site): su gains a Product tab for the settings that shape an account

David Leef271e74abfd
diff --git a/docs/guides/config-and-experiments.md b/docs/guides/config-and-experiments.md
index e75aedbd..c432d9bc 100644
--- a/docs/guides/config-and-experiments.md
+++ b/docs/guides/config-and-experiments.md
@@ -33,7 +33,8 @@ The registry parses every default against its schema when the module loads,
so a wrong default fails the process at boot. A stored override that no longer
parses after a schema change is skipped, logged, and shown on su as invalid so
it can be reset. The su settings tab draws its form from the schema, so a new
-setting needs no form code.
+setting needs no form code. The Product tab on su shows the settings that shape
+what an account gets, such as the signup credit grant, with the same cards.
**Every tunable is a setting.** A threshold, a switch, a mode: if an operator
might want it different, it is a registry entry, and a feature that people
diff --git a/site/src/app/su/experiments/SettingCard.tsx b/site/src/app/su/experiments/SettingCard.tsx
new file mode 100644
index 00000000..a394dbf8
--- /dev/null
+++ b/site/src/app/su/experiments/SettingCard.tsx
@@ -0,0 +1,79 @@
+"use client";
+
+import { useState } from "react";
+
+import { SchemaField, type JsonSchema } from "@/app/su/experiments/SchemaField";
+import { Badge } from "@/components/ui/badge";
+import { Button } from "@/components/ui/button";
+import {
+ Card,
+ CardContent,
+ CardDescription,
+ CardHeader,
+ CardTitle,
+} from "@/components/ui/card";
+import { useResetSetting, useSaveSetting, type SettingRow } from "@/queries/settings";
+
+// One registered setting, editable. The value on screen is what the product
+// reads for everyone outside an experiment; Reset returns it to the default
+// declared in code. Every su page that shows settings draws them with this.
+export function SettingCard({ row }: { row: SettingRow }) {
+ const save = useSaveSetting();
+ const reset = useResetSetting();
+ const [draft, setDraft] = useState<unknown>(row.value);
+ const [savedFrom, setSavedFrom] = useState(() => JSON.stringify(row.value));
+ // A save or reset that lands replaces the row; the draft follows it. The
+ // comparison is by content: a refetch hands back an equal object under a
+ // new reference, and that must not throw away what is being typed.
+ const incoming = JSON.stringify(row.value);
+ if (savedFrom !== incoming) {
+ setSavedFrom(incoming);
+ setDraft(row.value);
+ }
+ const dirty = JSON.stringify(draft) !== JSON.stringify(row.value);
+
+ return (
+ <Card>
+ <CardHeader>
+ <CardTitle className="flex items-center gap-2">
+ {row.title}
+ <Badge variant="outline">{row.public ? "public" : "server"}</Badge>
+ {row.overridden ? <Badge variant="secondary">overridden</Badge> : null}
+ {row.invalid ? <Badge variant="destructive">invalid, reset</Badge> : null}
+ </CardTitle>
+ <CardDescription>{row.description}</CardDescription>
+ </CardHeader>
+ <CardContent className="space-y-4">
+ <SchemaField
+ id={`setting-${row.key}`}
+ schema={row.schema as JsonSchema}
+ value={draft}
+ onChange={setDraft}
+ />
+ <div className="flex items-center gap-2">
+ <Button
+ disabled={!dirty || save.isPending}
+ onClick={() => save.mutate({ key: row.key, value: draft })}
+ >
+ {save.isPending ? "Saving…" : "Save"}
+ </Button>
+ <Button
+ variant="outline"
+ disabled={!row.overridden || reset.isPending}
+ onClick={() => reset.mutate(row.key)}
+ >
+ Reset to default
+ </Button>
+ {row.updatedAt ? (
+ <span className="text-xs text-muted-foreground">
+ changed {new Date(row.updatedAt).toLocaleString()}
+ </span>
+ ) : null}
+ </div>
+ {save.isError ? (
+ <p className="text-sm text-destructive">The value was rejected. Check each field.</p>
+ ) : null}
+ </CardContent>
+ </Card>
+ );
+}
diff --git a/site/src/app/su/experiments/settings/page.tsx b/site/src/app/su/experiments/settings/page.tsx
index 89cc2fa4..acc21bcb 100644
--- a/site/src/app/su/experiments/settings/page.tsx
+++ b/site/src/app/su/experiments/settings/page.tsx
@@ -1,23 +1,10 @@
"use client";
-import { useState } from "react";
-
-import { SchemaField, type JsonSchema } from "@/app/su/experiments/SchemaField";
-import { Badge } from "@/components/ui/badge";
-import { Button } from "@/components/ui/button";
-import {
- Card,
- CardContent,
- CardDescription,
- CardHeader,
- CardTitle,
-} from "@/components/ui/card";
+import { SettingCard } from "@/app/su/experiments/SettingCard";
import { SuStandIn } from "@/app/su/SuStandIn";
-import { useResetSetting, useSaveSetting, useSettings, type SettingRow } from "@/queries/settings";
+import { useSettings } from "@/queries/settings";
-// Every registered setting, editable. The value on screen is what the product
-// reads for everyone outside an experiment; Reset returns it to the default
-// declared in code.
+// Every registered setting, editable.
export default function SuSettingsPage() {
const settings = useSettings();
if (!settings.data) {
@@ -39,64 +26,3 @@ export default function SuSettingsPage() {
</div>
);
}
-
-function SettingCard({ row }: { row: SettingRow }) {
- const save = useSaveSetting();
- const reset = useResetSetting();
- const [draft, setDraft] = useState<unknown>(row.value);
- const [savedFrom, setSavedFrom] = useState(() => JSON.stringify(row.value));
- // A save or reset that lands replaces the row; the draft follows it. The
- // comparison is by content: a refetch hands back an equal object under a
- // new reference, and that must not throw away what is being typed.
- const incoming = JSON.stringify(row.value);
- if (savedFrom !== incoming) {
- setSavedFrom(incoming);
- setDraft(row.value);
- }
- const dirty = JSON.stringify(draft) !== JSON.stringify(row.value);
-
- return (
- <Card>
- <CardHeader>
- <CardTitle className="flex items-center gap-2">
- {row.title}
- <Badge variant="outline">{row.public ? "public" : "server"}</Badge>
- {row.overridden ? <Badge variant="secondary">overridden</Badge> : null}
- {row.invalid ? <Badge variant="destructive">invalid, reset</Badge> : null}
- </CardTitle>
- <CardDescription>{row.description}</CardDescription>
- </CardHeader>
- <CardContent className="space-y-4">
- <SchemaField
- id={`setting-${row.key}`}
- schema={row.schema as JsonSchema}
- value={draft}
- onChange={setDraft}
- />
- <div className="flex items-center gap-2">
- <Button
- disabled={!dirty || save.isPending}
- onClick={() => save.mutate({ key: row.key, value: draft })}
- >
- {save.isPending ? "Saving…" : "Save"}
- </Button>
- <Button
- variant="outline"
- disabled={!row.overridden || reset.isPending}
- onClick={() => reset.mutate(row.key)}
- >
- Reset to default
- </Button>
- {row.updatedAt ? (
- <span className="text-xs text-muted-foreground">
- changed {new Date(row.updatedAt).toLocaleString()}
- </span>
- ) : null}
- </div>
- {save.isError ? (
- <p className="text-sm text-destructive">The value was rejected. Check each field.</p>
- ) : null}
- </CardContent>
- </Card>
- );
-}
diff --git a/site/src/app/su/nav.ts b/site/src/app/su/nav.ts
index 67a08a36..3a450981 100644
--- a/site/src/app/su/nav.ts
+++ b/site/src/app/su/nav.ts
@@ -1,4 +1,12 @@
-import { ChartColumn, CreditCard, FlaskConical, ListChecks, Mail, UserRound } from "lucide-react";
+import {
+ ChartColumn,
+ CreditCard,
+ FlaskConical,
+ ListChecks,
+ Mail,
+ Package,
+ UserRound,
+} from "lucide-react";
import type { ComponentType } from "react";
import { RunAnalyticsButton } from "@/app/su/analytics/RunAnalyticsButton";
@@ -51,6 +59,13 @@ export const SU_NAV: SuSurface[] = [
title: "Credits",
description: "Grant credits to a user.",
},
+ {
+ href: "/product",
+ label: "Product",
+ icon: Package,
+ title: "Product",
+ description: "What a new account starts with.",
+ },
{
href: "/outreach",
label: "Outreach",
diff --git a/site/src/app/su/product/page.tsx b/site/src/app/su/product/page.tsx
new file mode 100644
index 00000000..4db1987c
--- /dev/null
+++ b/site/src/app/su/product/page.tsx
@@ -0,0 +1,26 @@
+"use client";
+
+import { SettingCard } from "@/app/su/experiments/SettingCard";
+import { SuStandIn } from "@/app/su/SuStandIn";
+import { PRODUCT_SETTING_KEYS } from "@/lib/config/registry";
+import { useSettings } from "@/queries/settings";
+
+// The settings that shape what an account gets, drawn with the same cards as
+// the settings tab under Experiments.
+const productKeys: ReadonlySet<string> = new Set(PRODUCT_SETTING_KEYS);
+
+export default function SuProductPage() {
+ const settings = useSettings();
+ if (!settings.data) {
+ return <SuStandIn />;
+ }
+ return (
+ <div className="max-w-2xl space-y-6 pb-9">
+ {settings.data.settings
+ .filter((row) => productKeys.has(row.key))
+ .map((row) => (
+ <SettingCard key={row.key} row={row} />
+ ))}
+ </div>
+ );
+}