Skip to content

armgit / E2B

Public Imported from GitHub
0

Open-source, secure environment with real-world tools for enterprise-grade agents.

chore(sdk): remove dead empty-chunk guards from command handles (#1962)

devin-ai-integration[bot]08945952ccef
diff --git a/.changeset/remove-empty-chunk-guards.md b/.changeset/remove-empty-chunk-guards.md
new file mode 100644
index 000000000..d0c928773
--- /dev/null
+++ b/.changeset/remove-empty-chunk-guards.md
@@ -0,0 +1,6 @@
+---
+'e2b': patch
+'@e2b/python-sdk': patch
+---
+
+Remove dead empty-chunk guards from command output handling; envd never sends empty output chunks, so behavior is unchanged.
diff --git a/packages/js-sdk/src/sandbox/commands/commandHandle.ts b/packages/js-sdk/src/sandbox/commands/commandHandle.ts
index 759d17fe5..3110d14f3 100644
--- a/packages/js-sdk/src/sandbox/commands/commandHandle.ts
+++ b/packages/js-sdk/src/sandbox/commands/commandHandle.ts
@@ -321,7 +321,6 @@ export class CommandHandle
break
}
}
- // TODO: Handle empty events like in python SDK
}
} catch (e) {
// The stream raised before an `end` event (e.g. disconnect or RPC
diff --git a/packages/python-sdk/e2b/sandbox_async/commands/command_handle.py b/packages/python-sdk/e2b/sandbox_async/commands/command_handle.py
index 4168cfe63..2a68bdc84 100644
--- a/packages/python-sdk/e2b/sandbox_async/commands/command_handle.py
+++ b/packages/python-sdk/e2b/sandbox_async/commands/command_handle.py
@@ -156,17 +156,17 @@ class AsyncCommandHandle:
match oneof:
case Oneof(field="data", value=data):
match data.output:
- case Oneof(field="stdout", value=chunk) if chunk:
+ case Oneof(field="stdout", value=chunk):
out = self._stdout_decoder.decode(chunk)
if out:
self._stdout_chunks.append(out)
yield out, None, None
- case Oneof(field="stderr", value=chunk) if chunk:
+ case Oneof(field="stderr", value=chunk):
out = self._stderr_decoder.decode(chunk)
if out:
self._stderr_chunks.append(out)
yield None, out, None
- case Oneof(field="pty", value=chunk) if chunk:
+ case Oneof(field="pty", value=chunk):
yield None, None, chunk
case Oneof(field="end", value=end):
# Flush trailing decoder bytes into the accumulators and
diff --git a/packages/python-sdk/e2b/sandbox_sync/commands/command_handle.py b/packages/python-sdk/e2b/sandbox_sync/commands/command_handle.py
index ea2b3fdad..d1edb9e62 100644
--- a/packages/python-sdk/e2b/sandbox_sync/commands/command_handle.py
+++ b/packages/python-sdk/e2b/sandbox_sync/commands/command_handle.py
@@ -106,17 +106,17 @@ class CommandHandle:
match oneof:
case Oneof(field="data", value=data):
match data.output:
- case Oneof(field="stdout", value=chunk) if chunk:
+ case Oneof(field="stdout", value=chunk):
out = self._stdout_decoder.decode(chunk)
if out:
self._stdout_chunks.append(out)
yield out, None, None
- case Oneof(field="stderr", value=chunk) if chunk:
+ case Oneof(field="stderr", value=chunk):
out = self._stderr_decoder.decode(chunk)
if out:
self._stderr_chunks.append(out)
yield None, out, None
- case Oneof(field="pty", value=chunk) if chunk:
+ case Oneof(field="pty", value=chunk):
yield None, None, chunk
case Oneof(field="end", value=end):
# Flush trailing decoder bytes into the accumulators and