Skip to content

armgit / E2B

Public Imported from GitHub
0

Open-source, secure environment with real-world tools for enterprise-grade agents.

Fix models' args parsing

Tomas Valenta3fb657a674d7
diff --git a/components/Editor/Sidebar/Model/ModelCard.tsx b/components/Editor/Sidebar/Model/ModelCard.tsx
index 6b1046c83..eae8c9b8f 100644
--- a/components/Editor/Sidebar/Model/ModelCard.tsx
+++ b/components/Editor/Sidebar/Model/ModelCard.tsx
@@ -6,6 +6,7 @@ import React from 'react'
import { ModelConfigTemplate } from 'state/model'
import { SelectedModel } from 'state/store'
+import { parseInput } from 'utils/parseInput'
interface Props {
isSelected?: boolean
@@ -87,12 +88,17 @@ function ModelCard({
>
<Input
value={selectedModel?.args[key]?.toString() || ''}
+ type={value.type === 'number' ? 'number' : 'text'}
onChange={v => updateSelectedModel({
args: {
...selectedModel?.args,
- [key]: value.type === 'number' ? parseFloat(v) : v,
+ [key]: parseInput(value, v),
}
})}
+ max={value.max}
+ min={value.min}
+ step={value.step}
+ placeholder={value.value?.toString()}
label={value.label || key}
/>
</div>
diff --git a/components/Input.tsx b/components/Input.tsx
index 0cf14a7b6..1aa780c86 100644
--- a/components/Input.tsx
+++ b/components/Input.tsx
@@ -1,5 +1,6 @@
import clsx from 'clsx'
import {
+ HTMLInputTypeAttribute,
useEffect,
useRef,
} from 'react'
@@ -17,6 +18,10 @@ export interface Props {
title?: string
required?: boolean
isDisabled?: boolean
+ type?: HTMLInputTypeAttribute
+ min?: number
+ max?: number
+ step?: number
}
function Input({
@@ -30,6 +35,10 @@ function Input({
onChange,
placeholder,
label,
+ min,
+ max,
+ step,
+ type = 'text',
}: Props) {
const ref = useRef<HTMLInputElement>(null)
@@ -52,6 +61,9 @@ function Input({
<Text text={label} size={Text.size.S3} />
}
<input
+ min={min?.toString()}
+ max={max?.toString()}
+ step={step?.toString()}
required={required}
autoCapitalize="off"
autoCorrect="off"
@@ -64,7 +76,7 @@ function Input({
ref={ref}
disabled={isDisabled}
pattern={pattern}
- type="text"
+ type={type}
className={clsx(
{ 'bg-transparent': isTransparent },
'w-full',
diff --git a/state/model.ts b/state/model.ts
index 428f10a7b..4a71f9b14 100644
--- a/state/model.ts
+++ b/state/model.ts
@@ -19,6 +19,9 @@ export interface ModelArgTemplate {
type: 'string' | 'number'
// If this property is defined it is used as a default value.
value?: ArgValue
+ min?: number
+ max?: number
+ step?: number
}
export interface ModelConfigTemplate {
@@ -71,23 +74,40 @@ export const models: {
model: {
editable: true,
type: 'string',
- label: 'Model name'
+ label: 'Model'
},
max_length: {
type: 'number',
- value: 5000,
+ value: 4096,
+ step: 1,
+ min: 1,
},
temperature: {
+ label: 'Temperature',
+ editable: true,
type: 'number',
value: 0.4,
+ min: 0.01,
+ max: 5,
+ step: 0.01,
},
top_p: {
+ label: 'Top P',
+ editable: true,
type: 'number',
value: 0.9,
+ min: 0.01,
+ max: 1,
+ step: 0.01,
},
repetition_penalty: {
+ label: 'Repetition penalty',
+ editable: true,
type: 'number',
value: 1.1,
+ min: 0.01,
+ max: 5,
+ step: 0.01,
},
},
},
diff --git a/utils/parseInput.ts b/utils/parseInput.ts
new file mode 100644
index 000000000..e5b01be08
--- /dev/null
+++ b/utils/parseInput.ts
@@ -0,0 +1,14 @@
+import { ModelArgTemplate } from 'state/model'
+
+export function parseInput(argTemplate: ModelArgTemplate, value: string) {
+ if (argTemplate.type === 'number') {
+ try {
+ const result = parseFloat(value)
+ return isNaN(result) ? undefined : result
+ } catch {
+ return
+ }
+ }
+
+ return value
+}