Skip to content

armgit / E2B

Public Imported from GitHub
0

Open-source, secure environment with real-world tools for enterprise-grade agents.

Improve handler contrav typing

Tomas Valenta610704221b5a
diff --git a/.changeset/real-poems-matter.md b/.changeset/real-poems-matter.md
new file mode 100644
index 000000000..c03e9fb34
--- /dev/null
+++ b/.changeset/real-poems-matter.md
@@ -0,0 +1,5 @@
+---
+"@e2b/python-sdk": patch
+---
+
+Improve types
diff --git a/packages/python-sdk/e2b/sandbox/main.py b/packages/python-sdk/e2b/sandbox/main.py
index 91e39e65d..8ee2594bd 100644
--- a/packages/python-sdk/e2b/sandbox/main.py
+++ b/packages/python-sdk/e2b/sandbox/main.py
@@ -62,7 +62,7 @@ class Sandbox(SandboxConnection):
on_scan_ports: Optional[Callable[[List[OpenPort]], Any]] = None,
on_stdout: Optional[Callable[[ProcessMessage], Any]] = None,
on_stderr: Optional[Callable[[ProcessMessage], Any]] = None,
- on_exit: Optional[Callable[[int], Any]] = None,
+ on_exit: Optional[Union[Callable[[int], Any], Callable[[], Any]]] = None,
timeout: Optional[float] = TIMEOUT,
_sandbox: Optional[models.Instance] = None,
_debug_hostname: Optional[str] = None,
diff --git a/packages/python-sdk/e2b/sandbox/process.py b/packages/python-sdk/e2b/sandbox/process.py
index 486023729..7e02984e4 100644
--- a/packages/python-sdk/e2b/sandbox/process.py
+++ b/packages/python-sdk/e2b/sandbox/process.py
@@ -8,6 +8,7 @@ from typing import (
Dict,
List,
Optional,
+ Union,
)
from pydantic import BaseModel
@@ -213,7 +214,7 @@ class ProcessManager:
sandbox: SandboxConnection,
on_stdout: Optional[Callable[[ProcessMessage], Any]] = None,
on_stderr: Optional[Callable[[ProcessMessage], Any]] = None,
- on_exit: Optional[Callable[[int], Any]] = None,
+ on_exit: Optional[Union[Callable[[int], Any], Callable[[], Any]]] = None,
):
self._sandbox = sandbox
self._process_cleanup: List[Callable[[], Any]] = []
@@ -232,7 +233,7 @@ class ProcessManager:
cmd: str,
on_stdout: Optional[Callable[[ProcessMessage], Any]] = None,
on_stderr: Optional[Callable[[ProcessMessage], Any]] = None,
- on_exit: Optional[Callable[[int], Any]] = None,
+ on_exit: Optional[Union[Callable[[int], Any], Callable[[], Any]]] = None,
env_vars: Optional[EnvVars] = None,
cwd: str = "",
rootdir: str = "", # DEPRECATED
@@ -326,7 +327,7 @@ class ProcessManager:
unsub_all()
if on_exit:
try:
- on_exit(output.exit_code or 0)
+ on_exit(*[output.exit_code or 0])
except TypeError as error:
logger.exception(f"Error in on_exit callback: {error}")
future_exit_handler_finish(output)