Skip to content

armgit / E2B

Public Imported from GitHub
0

Open-source, secure environment with real-world tools for enterprise-grade agents.

Change `isRunning` logic

Jakub Novak99cc090063ba
diff --git a/packages/js-sdk/src/sandbox/index.ts b/packages/js-sdk/src/sandbox/index.ts
index 62a93e972..432da5b0c 100644
--- a/packages/js-sdk/src/sandbox/index.ts
+++ b/packages/js-sdk/src/sandbox/index.ts
@@ -100,11 +100,15 @@ export class Sandbox extends SandboxApi {
return url.toString()
}
- async isRunning(opts?: Pick<ConnectionOpts, 'requestTimeoutMs'>): Promise<true> {
+ async isRunning(opts?: Pick<ConnectionOpts, 'requestTimeoutMs'>): Promise<boolean> {
const res = await this.envdApi.api.GET('/health', {
signal: this.connectionConfig.getSignal(opts?.requestTimeoutMs),
})
+ if (res.response.status == 502) {
+ return false
+ }
+
const err = await handleEnvdApiError(res)
if (err) {
throw err
diff --git a/packages/js-sdk/tests/sandbox/timeout.test.ts b/packages/js-sdk/tests/sandbox/timeout.test.ts
index 2e6bbadfd..6fab68f93 100644
--- a/packages/js-sdk/tests/sandbox/timeout.test.ts
+++ b/packages/js-sdk/tests/sandbox/timeout.test.ts
@@ -2,13 +2,12 @@ import { expect } from 'vitest'
import { sandboxTest, isDebug, wait } from '../setup.js'
-// SKIPPED: isRunning takes too long if the sandbox was just killed
-sandboxTest.skipIf(isDebug).skip('shorten timeout', async ({ sandbox }) => {
+sandboxTest.skipIf(isDebug)('shorten timeout', async ({ sandbox }) => {
await sandbox.setTimeout(5000)
await wait(6000)
- await expect(sandbox.isRunning({ requestTimeoutMs: 1000 })).rejects.toThrowError()
+ expect(await sandbox.isRunning({ requestTimeoutMs: 1000 })).toBeFalsy()
})
sandboxTest.skipIf(isDebug)('shorten then lenghten timeout', async ({ sandbox }) => {