Open-source, secure environment with real-world tools for enterprise-grade agents.
Python agentaiai-agentai-agentscode-interpretercopilotdevelopmentdevtoolsgptgpt-4javascriptllmnextjsopenaipythonreactsoftwaretypescript
test: reduce test_sbx_metrics flakiness by extending polling window (#1291)
Mish Ushakovc2d6eef78dfc
diff --git a/packages/js-sdk/tests/sandbox/metrics.test.ts b/packages/js-sdk/tests/sandbox/metrics.test.tsindex 35445f91b..e3f125ff2 100644--- a/packages/js-sdk/tests/sandbox/metrics.test.ts+++ b/packages/js-sdk/tests/sandbox/metrics.test.ts@@ -3,26 +3,30 @@ import { expect } from 'vitest'import { SandboxMetrics } from '../../src'import { sandboxTest, isDebug, wait } from '../setup.js'-sandboxTest.skipIf(isDebug)('sbx metrics', async ({ sandbox }) => {- const now = new Date()- let metrics: SandboxMetrics[]- for (let i = 0; i < 15; i++) {- metrics = await sandbox.getMetrics()- if (metrics.length > 0) {- break+sandboxTest.skipIf(isDebug)(+ 'sbx metrics',+ { timeout: 60_000 },+ async ({ sandbox }) => {+ const now = new Date()+ let metrics: SandboxMetrics[]+ for (let i = 0; i < 60; i++) {+ metrics = await sandbox.getMetrics()+ if (metrics.length > 0) {+ break+ }+ await wait(500)}- await wait(1_000)- }- expect(metrics.length).toBeGreaterThan(0)- const metric = metrics[0]- expect(metric.diskTotal).toBeDefined()- expect(metric.diskUsed).toBeDefined()- expect(metric.memTotal).toBeDefined()- expect(metric.memUsed).toBeDefined()- expect(metric.cpuUsedPct).toBeDefined()- expect(metric.cpuCount).toBeDefined()+ expect(metrics.length).toBeGreaterThan(0)+ const metric = metrics[0]+ expect(metric.diskTotal).toBeDefined()+ expect(metric.diskUsed).toBeDefined()+ expect(metric.memTotal).toBeDefined()+ expect(metric.memUsed).toBeDefined()+ expect(metric.cpuUsedPct).toBeDefined()+ expect(metric.cpuCount).toBeDefined()- metrics = await sandbox.getMetrics({ start: now, end: new Date() })- expect(metrics.length).toBeGreaterThan(0)-})+ metrics = await sandbox.getMetrics({ start: now, end: new Date() })+ expect(metrics.length).toBeGreaterThan(0)+ }+)diff --git a/packages/python-sdk/tests/async/sandbox_async/test_metrics.py b/packages/python-sdk/tests/async/sandbox_async/test_metrics.pyindex 069733907..f3b07a914 100644--- a/packages/python-sdk/tests/async/sandbox_async/test_metrics.py+++ b/packages/python-sdk/tests/async/sandbox_async/test_metrics.py@@ -5,17 +5,18 @@ import pytest@pytest.mark.skip_debug()async def test_sbx_metrics(async_sandbox_factory):start_time = datetime.datetime.now()- sbx = await async_sandbox_factory(timeout=20)+ sbx = await async_sandbox_factory(timeout=60)# Wait for the sandbox to have some metricsmetrics = []- for _ in range(15):+ for _ in range(60):metrics = await sbx.get_metrics()if len(metrics) > 0:break- await asyncio.sleep(1)+ await asyncio.sleep(0.5)assert len(metrics) > 0diff --git a/packages/python-sdk/tests/sync/sandbox_sync/test_metrics.py b/packages/python-sdk/tests/sync/sandbox_sync/test_metrics.pyindex d4895c544..e6cb55faa 100644--- a/packages/python-sdk/tests/sync/sandbox_sync/test_metrics.py+++ b/packages/python-sdk/tests/sync/sandbox_sync/test_metrics.py@@ -5,16 +5,17 @@ import pytest@pytest.mark.skip_debug()def test_sbx_metrics(sandbox_factory) -> None:start_time = datetime.datetime.now()sbx = sandbox_factory(timeout=60)# Wait for the sandbox to have some metricsmetrics = []- for _ in range(15):+ for _ in range(60):metrics = sbx.get_metrics()if len(metrics) > 0:break- time.sleep(1)+ time.sleep(0.5)assert len(metrics) > 0