Skip to content

armgit / E2B

Public Imported from GitHub
0

Open-source, secure environment with real-world tools for enterprise-grade agents.

Add warning for create method in Python SDK

Jakub Novakc7a39ffe83aa
diff --git a/.changeset/real-timers-jam.md b/.changeset/real-timers-jam.md
new file mode 100644
index 000000000..381f6d81e
--- /dev/null
+++ b/.changeset/real-timers-jam.md
@@ -0,0 +1,5 @@
+---
+'@e2b/python-sdk': patch
+---
+
+Add warning to .create() in Python SDK
diff --git a/packages/python-sdk/e2b/session/process.py b/packages/python-sdk/e2b/session/process.py
index fb4b7cd90..43b738358 100644
--- a/packages/python-sdk/e2b/session/process.py
+++ b/packages/python-sdk/e2b/session/process.py
@@ -234,7 +234,7 @@ class ProcessManager:
process_id: Optional[str] = None,
timeout: Optional[float] = TIMEOUT,
) -> Process:
- logger.info(f"Starting process (id: {process_id}): {cmd}")
+ logger.info(f"Starting process: {cmd}")
env_vars = env_vars or {}
env_vars = {**self._session.env_vars, **env_vars}
@@ -251,6 +251,7 @@ class ProcessManager:
def handle_exit(exit_code: int):
output.exit_code = exit_code
+ logger.info(f"Process {process_id} exited with exit code {exit_code}")
future_exit(True)
def handle_stdout(data: Dict[Any, Any]):
diff --git a/packages/python-sdk/e2b/session/session_connection.py b/packages/python-sdk/e2b/session/session_connection.py
index e444171f3..f1d6a6e31 100644
--- a/packages/python-sdk/e2b/session/session_connection.py
+++ b/packages/python-sdk/e2b/session/session_connection.py
@@ -2,13 +2,14 @@ import asyncio
import functools
import logging
import traceback
+import warnings
from concurrent.futures import ThreadPoolExecutor, TimeoutError
from os import getenv
from time import sleep
from typing import Any, Callable, List, Literal, Optional, Union
from pydantic import BaseModel
-from urllib3.exceptions import ReadTimeoutError
+from urllib3.exceptions import MaxRetryError, ConnectTimeoutError
from e2b.api import client, configuration, exceptions, models
from e2b.constants import (
@@ -96,6 +97,11 @@ class SessionConnection:
self._open(timeout=timeout)
+ @classmethod
+ def create(cls, *args, **kwargs):
+ warnings.warn("Session.create() is deprecated, use Session() instead")
+ return cls(*args, **kwargs)
+
def get_hostname(self, port: Optional[int] = None):
"""
Get the hostname for the session or for the specified session's port.
@@ -182,12 +188,14 @@ class SessionConnection:
self._process_cleanup.append(self._refreshing_task.cancel)
self._process_cleanup.append(lambda: shutdown_executor(executor))
- except ReadTimeoutError as e:
- logger.error(f"Failed to acquire session: {e}")
+ except MaxRetryError as e:
+ logger.error(f"Failed to acquire session")
self._close()
- raise TimeoutException(
- f"Failed to acquire session: {e}",
- ) from e
+ if isinstance(e.reason, ConnectTimeoutError):
+ raise TimeoutException(
+ f"Failed to acquire session: {e}",
+ ) from e
+ raise e
except Exception as e:
logger.error(f"Failed to acquire session")
self._close()
@@ -238,11 +246,7 @@ class SessionConnection:
def unsub_all():
return lambda: functools.reduce(
lambda _, f: f(),
- [
- unsub
- for unsub in results
- if not isinstance(unsub, Exception) and unsub
- ],
+ [unsub for unsub in results if not isinstance(unsub, Exception)],
)
if len(exceptions) > 0:
@@ -286,7 +290,9 @@ class SessionConnection:
self._subscribers[sub_id] = Subscription(
service=service, id=sub_id, handler=handler
)
- logger.info(f"Subscribed to {service} {camel_case_to_snake_case(method)}")
+ logger.debug(
+ f"Subscribed to {service} {camel_case_to_snake_case(method)} (sub id: {sub_id})"
+ )
def unsub():
self._unsubscribe(sub_id, timeout=timeout)
diff --git a/packages/python-sdk/e2b/session/session_rpc.py b/packages/python-sdk/e2b/session/session_rpc.py
index f281d5589..0dd23a6cc 100644
--- a/packages/python-sdk/e2b/session/session_rpc.py
+++ b/packages/python-sdk/e2b/session/session_rpc.py
@@ -67,6 +67,7 @@ class SessionRpc(BaseModel):
while True:
data = self._queue_out.get()
if data == STOP_SIGN:
+ logger.debug("WebSocket received sign to stop.")
break
logger.debug(f"WebSocket received message: {data}".strip())
self._receive_message(data)
diff --git a/packages/python-sdk/e2b/session/websocket_client.py b/packages/python-sdk/e2b/session/websocket_client.py
index 8cd86f72b..abeb66b50 100644
--- a/packages/python-sdk/e2b/session/websocket_client.py
+++ b/packages/python-sdk/e2b/session/websocket_client.py
@@ -62,7 +62,7 @@ class WebSocket:
websocket_connector = connect(self.url, max_size=None, max_queue=None)
websocket_connector.BACKOFF_MIN = 1
websocket_connector.BACKOFF_FACTOR = 1
- websocket_connector.BACKOFF_INITIAL = 1
+ websocket_connector.BACKOFF_INITIAL = 0.4
async for websocket in websocket_connector:
try:
self._ws = websocket
diff --git a/packages/python-sdk/example.py b/packages/python-sdk/example.py
index 71cf36064..1e7f0185e 100644
--- a/packages/python-sdk/example.py
+++ b/packages/python-sdk/example.py
@@ -13,7 +13,7 @@ logging.basicConfig(level=logging.ERROR)
def main():
- s = Session("Nodejs", api_key=E2B_API_KEY, timeout=0.0001)
+ s = Session("Nodejs", api_key=E2B_API_KEY)
a = s.process.start("ls -la /var ")
a.wait()
print(a.stdout)