Open-source, secure environment with real-world tools for enterprise-grade agents.
Python agentaiai-agentai-agentscode-interpretercopilotdevelopmentdevtoolsgptgpt-4javascriptllmnextjsopenaipythonreactsoftwaretypescript
fix(python-sdk): anchor file-metadata validation regexes with \A/\Z (#1438)
Mish Ushakove0ed07144340
diff --git a/.changeset/tidy-knees-attach.md b/.changeset/tidy-knees-attach.mdnew file mode 100644index 000000000..ede29189b--- /dev/null+++ b/.changeset/tidy-knees-attach.md@@ -0,0 +1,5 @@+---+"@e2b/python-sdk": patch+---++Anchor file-metadata validation regexes with `\A`/`\Z` instead of `^`/`$`. In Python, `$` also matches just before a trailing newline, so metadata keys or values ending in `\n` passed client-side validation (unlike the JS SDK) and then failed later with an opaque low-level HTTP "illegal header value" error. They are now rejected upfront with `InvalidArgumentException`.diff --git a/packages/js-sdk/tests/sandbox/files/metadata.test.ts b/packages/js-sdk/tests/sandbox/files/metadata.test.tsindex f6ff5d533..025f7cd9f 100644--- a/packages/js-sdk/tests/sandbox/files/metadata.test.ts+++ b/packages/js-sdk/tests/sandbox/files/metadata.test.ts@@ -181,6 +181,14 @@ sandboxTest('rejects invalid metadata', async ({ sandbox }) => {sandbox.files.write(filename, 'x', { metadata: { good: 'bad\nvalue' } })).rejects.toThrow(InvalidArgumentError)+ // Trailing newline in value or key.+ await expect(+ sandbox.files.write(filename, 'x', { metadata: { good: 'value\n' } })+ ).rejects.toThrow(InvalidArgumentError)+ await expect(+ sandbox.files.write(filename, 'x', { metadata: { 'key\n': 'value' } })+ ).rejects.toThrow(InvalidArgumentError)+// The file must not have been created by a rejected write.assert.isFalse(await sandbox.files.exists(filename))})diff --git a/packages/python-sdk/e2b/sandbox/filesystem/filesystem.py b/packages/python-sdk/e2b/sandbox/filesystem/filesystem.pyindex 6337fafaa..71893ee07 100644--- a/packages/python-sdk/e2b/sandbox/filesystem/filesystem.py+++ b/packages/python-sdk/e2b/sandbox/filesystem/filesystem.py@@ -170,8 +170,8 @@ METADATA_HEADER_PREFIX = "X-Metadata-"# Metadata keys travel as `X-Metadata-<key>` HTTP header names, so they must be# valid header tokens (RFC 7230); values travel as header values, restricted to# printable US-ASCII.-_METADATA_KEY_REGEX = re.compile(r"^[A-Za-z0-9!#$%&'*+\-.^_`|~]+$")-_METADATA_VALUE_REGEX = re.compile(r"^[\x20-\x7e]*$")+_METADATA_KEY_REGEX = re.compile(r"\A[A-Za-z0-9!#$%&'*+\-.^_`|~]+\Z")+_METADATA_VALUE_REGEX = re.compile(r"\A[\x20-\x7e]*\Z")def validate_metadata(metadata: Optional[Dict[str, str]]) -> None:diff --git a/packages/python-sdk/tests/async/sandbox_async/files/test_metadata.py b/packages/python-sdk/tests/async/sandbox_async/files/test_metadata.pyindex 11230c3de..99c7060fd 100644--- a/packages/python-sdk/tests/async/sandbox_async/files/test_metadata.py+++ b/packages/python-sdk/tests/async/sandbox_async/files/test_metadata.py@@ -162,5 +162,11 @@ async def test_write_rejects_invalid_metadata(async_sandbox: AsyncSandbox):with pytest.raises(InvalidArgumentException):await async_sandbox.files.write(filename, "x", metadata={"good": "bad\nvalue"})+ # Trailing newline (Python's `$` would accept it; `\Z` must not).+ with pytest.raises(InvalidArgumentException):+ await async_sandbox.files.write(filename, "x", metadata={"good": "value\n"})+ with pytest.raises(InvalidArgumentException):+ await async_sandbox.files.write(filename, "x", metadata={"key\n": "value"})+# The file must not have been created by a rejected write.assert not await async_sandbox.files.exists(filename)diff --git a/packages/python-sdk/tests/sync/sandbox_sync/files/test_metadata.py b/packages/python-sdk/tests/sync/sandbox_sync/files/test_metadata.pyindex 4a393bcc7..6ed6d8ed5 100644--- a/packages/python-sdk/tests/sync/sandbox_sync/files/test_metadata.py+++ b/packages/python-sdk/tests/sync/sandbox_sync/files/test_metadata.py@@ -153,5 +153,11 @@ def test_write_rejects_invalid_metadata(sandbox):with pytest.raises(InvalidArgumentException):sandbox.files.write(filename, "x", metadata={"good": "bad\nvalue"})+ # Trailing newline (Python's `$` would accept it; `\Z` must not).+ with pytest.raises(InvalidArgumentException):+ sandbox.files.write(filename, "x", metadata={"good": "value\n"})+ with pytest.raises(InvalidArgumentException):+ sandbox.files.write(filename, "x", metadata={"key\n": "value"})+# The file must not have been created by a rejected write.assert not sandbox.files.exists(filename)