Skip to content

armgit / E2B

Public Imported from GitHub
0

Open-source, secure environment with real-world tools for enterprise-grade agents.

Skip cache before image in TypeScript (#937)

Mish Ushakovfaeeb78a3c0d
diff --git a/.changeset/selfish-poets-heal.md b/.changeset/selfish-poets-heal.md
new file mode 100644
index 000000000..6a4f12751
--- /dev/null
+++ b/.changeset/selfish-poets-heal.md
@@ -0,0 +1,5 @@
+---
+'e2b': patch
+---
+
+fixes skipCache type
diff --git a/packages/js-sdk/src/template/index.ts b/packages/js-sdk/src/template/index.ts
index 4954079ea..a249ef572 100644
--- a/packages/js-sdk/src/template/index.ts
+++ b/packages/js-sdk/src/template/index.ts
@@ -498,7 +498,7 @@ export class TemplateBase
return this
}
- skipCache(): TemplateBuilder {
+ skipCache(): this {
this.forceNextLayer = true
return this
}
diff --git a/packages/js-sdk/src/template/types.ts b/packages/js-sdk/src/template/types.ts
index 45652fe3f..a7f4472ad 100644
--- a/packages/js-sdk/src/template/types.ts
+++ b/packages/js-sdk/src/template/types.ts
@@ -46,7 +46,7 @@ export interface TemplateFromImage {
fromTemplate(template: string): TemplateBuilder
- fromDockerfile(dockerfileContent: string): TemplateBuilder
+ fromDockerfile(dockerfileContentOrPath: string): TemplateBuilder
fromAWSRegistry(
image: string,
@@ -64,7 +64,7 @@ export interface TemplateFromImage {
}
): TemplateBuilder
- skipCache(): TemplateBuilder
+ skipCache(): this
}
// Interface for the main builder state
@@ -130,7 +130,7 @@ export interface TemplateBuilder {
setEnvs(envs: Record<string, string>): TemplateBuilder
- skipCache(): TemplateBuilder
+ skipCache(): this
setStartCmd(
startCommand: string,
diff --git a/packages/js-sdk/tests/template/build.test.ts b/packages/js-sdk/tests/template/build.test.ts
index b7465ded6..c4580e4fb 100644
--- a/packages/js-sdk/tests/template/build.test.ts
+++ b/packages/js-sdk/tests/template/build.test.ts
@@ -70,3 +70,12 @@ buildTemplateTest(
await buildTemplate(template)
}
)
+
+buildTemplateTest(
+ 'build template with skipCache',
+ { timeout: 180000 },
+ async ({ buildTemplate }) => {
+ const template = Template().skipCache().fromImage('ubuntu:22.04')
+ await buildTemplate(template)
+ }
+)
diff --git a/packages/python-sdk/tests/async/template_async/test_build.py b/packages/python-sdk/tests/async/template_async/test_build.py
index 1e334e32a..781321fa6 100644
--- a/packages/python-sdk/tests/async/template_async/test_build.py
+++ b/packages/python-sdk/tests/async/template_async/test_build.py
@@ -81,3 +81,14 @@ async def test_build_template_with_resolve_symlinks(async_build, setup_test_fold
)
await async_build(template)
+
+
+async def test_build_template_with_skip_cache(async_build, setup_test_folder):
+ template = (
+ AsyncTemplate(file_context_path=setup_test_folder)
+ .skip_cache()
+ .from_image("ubuntu:22.04")
+ )
+
+ await async_build(template)
diff --git a/packages/python-sdk/tests/sync/template_sync/test_build.py b/packages/python-sdk/tests/sync/template_sync/test_build.py
index cf854b121..21943f793 100644
--- a/packages/python-sdk/tests/sync/template_sync/test_build.py
+++ b/packages/python-sdk/tests/sync/template_sync/test_build.py
@@ -81,3 +81,14 @@ def test_build_template_with_resolve_symlinks(build, setup_test_folder):
)
build(template)
+
+
+def test_build_template_with_skip_cache(build, setup_test_folder):
+ template = (
+ Template(file_context_path=setup_test_folder)
+ .skip_cache()
+ .from_image("ubuntu:22.04")
+ )
+
+ build(template)