The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.
Update print statement from 'Hfix: update package manager tests and add summaryello' to 'Goodbye'
Pangerkumzuk Longkumer0bf47bbb41c4
diff --git a/tests/lib/package-manager.test.js b/tests/lib/package-manager.test.jsindex a9b32f7b0..58818e933 100644--- a/tests/lib/package-manager.test.js+++ b/tests/lib/package-manager.test.js@@ -16,11 +16,11 @@ const pm = require('../../scripts/lib/package-manager');function test(name, fn) {try {fn();- console.log(` ✓ ${name}`);+ console.log(` ✓ ${name}`);return true;} catch (err) {- console.log(` ✗ ${name}`);- console.log(` Error: ${err.message}`);+ console.log(` ✗ ${name}`);+ console.log(` Error: ${err.message}`);return false;}}@@ -39,7 +39,9 @@ function cleanupTestDir(testDir) {// Test suitefunction runTests() {- console.log('\n=== Testing package-manager.js ===\n');+ console.log('+=== Testing package-manager.js ===+');let passed = 0;let failed = 0;@@ -52,7 +54,8 @@ function runTests() {assert.ok(pm.PACKAGE_MANAGERS.pnpm, 'Should have pnpm');assert.ok(pm.PACKAGE_MANAGERS.yarn, 'Should have yarn');assert.ok(pm.PACKAGE_MANAGERS.bun, 'Should have bun');- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('Each manager has required properties', () => {const requiredProps = ['name', 'lockFile', 'installCmd', 'runCmd', 'execCmd', 'testCmd', 'buildCmd', 'devCmd'];@@ -61,10 +64,12 @@ function runTests() {assert.ok(config[prop], `${name} should have ${prop}`);}}- })) passed++; else failed++;+ })) passed++;+ else failed++;// detectFromLockFile tests- console.log('\ndetectFromLockFile:');+ console.log('+detectFromLockFile:');if (test('detects npm from package-lock.json', () => {const testDir = createTestDir();@@ -75,7 +80,8 @@ function runTests() {} finally {cleanupTestDir(testDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('detects pnpm from pnpm-lock.yaml', () => {const testDir = createTestDir();@@ -86,7 +92,8 @@ function runTests() {} finally {cleanupTestDir(testDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('detects yarn from yarn.lock', () => {const testDir = createTestDir();@@ -97,7 +104,8 @@ function runTests() {} finally {cleanupTestDir(testDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('detects bun from bun.lockb', () => {const testDir = createTestDir();@@ -108,7 +116,8 @@ function runTests() {} finally {cleanupTestDir(testDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('returns null when no lock file exists', () => {const testDir = createTestDir();@@ -118,7 +127,8 @@ function runTests() {} finally {cleanupTestDir(testDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('respects detection priority (pnpm > npm)', () => {const testDir = createTestDir();@@ -132,51 +142,48 @@ function runTests() {} finally {cleanupTestDir(testDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;// detectFromPackageJson tests- console.log('\ndetectFromPackageJson:');+ console.log('+detectFromPackageJson:');if (test('detects package manager from packageManager field', () => {const testDir = createTestDir();try {- fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({- name: 'test',- packageManager: '[email protected]'- }));+ fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({ name: 'test', packageManager: '[email protected]' }));const result = pm.detectFromPackageJson(testDir);assert.strictEqual(result, 'pnpm');} finally {cleanupTestDir(testDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('handles packageManager without version', () => {const testDir = createTestDir();try {- fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({- name: 'test',- packageManager: 'yarn'- }));+ fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({ name: 'test', packageManager: 'yarn' }));const result = pm.detectFromPackageJson(testDir);assert.strictEqual(result, 'yarn');} finally {cleanupTestDir(testDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('returns null when no packageManager field', () => {const testDir = createTestDir();try {- fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({- name: 'test'- }));+ fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({ name: 'test' }));const result = pm.detectFromPackageJson(testDir);assert.strictEqual(result, null);} finally {cleanupTestDir(testDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('returns null when no package.json exists', () => {const testDir = createTestDir();@@ -186,27 +193,32 @@ function runTests() {} finally {cleanupTestDir(testDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;// getAvailablePackageManagers tests- console.log('\ngetAvailablePackageManagers:');+ console.log('+getAvailablePackageManagers:');if (test('returns array of available managers', () => {const available = pm.getAvailablePackageManagers();assert.ok(Array.isArray(available), 'Should return array');// npm should always be available with Node.jsassert.ok(available.includes('npm'), 'npm should be available');- })) passed++; else failed++;+ })) passed++;+ else failed++;// getPackageManager tests- console.log('\ngetPackageManager:');+ console.log('+getPackageManager:');if (test('returns object with name, config, and source', () => {const result = pm.getPackageManager();assert.ok(result.name, 'Should have name');assert.ok(result.config, 'Should have config');assert.ok(result.source, 'Should have source');- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('respects environment variable', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -222,12 +234,12 @@ function runTests() {delete process.env.CLAUDE_PACKAGE_MANAGER;}}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('detects from lock file in project', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;delete process.env.CLAUDE_PACKAGE_MANAGER;-const testDir = createTestDir();try {fs.writeFileSync(path.join(testDir, 'bun.lockb'), '');@@ -240,10 +252,12 @@ function runTests() {process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;}}- })) passed++; else failed++;+ })) passed++;+ else failed++;// getRunCommand tests- console.log('\ngetRunCommand:');+ console.log('+getRunCommand:');if (test('returns correct install command', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -258,7 +272,8 @@ function runTests() {delete process.env.CLAUDE_PACKAGE_MANAGER;}}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('returns correct test command', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -273,10 +288,12 @@ function runTests() {delete process.env.CLAUDE_PACKAGE_MANAGER;}}- })) passed++; else failed++;+ })) passed++;+ else failed++;// getExecCommand tests- console.log('\ngetExecCommand:');+ console.log('+getExecCommand:');if (test('returns correct exec command for npm', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -291,7 +308,8 @@ function runTests() {delete process.env.CLAUDE_PACKAGE_MANAGER;}}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('returns correct exec command for pnpm', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -306,10 +324,12 @@ function runTests() {delete process.env.CLAUDE_PACKAGE_MANAGER;}}- })) passed++; else failed++;+ })) passed++;+ else failed++;// getCommandPattern tests- console.log('\ngetCommandPattern:');+ console.log('+getCommandPattern:');if (test('generates pattern for dev command', () => {const pattern = pm.getCommandPattern('dev');@@ -317,31 +337,35 @@ function runTests() {assert.ok(pattern.includes('pnpm'), 'Should include pnpm');assert.ok(pattern.includes('yarn dev'), 'Should include yarn');assert.ok(pattern.includes('bun run dev'), 'Should include bun');- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('pattern matches actual commands', () => {const pattern = pm.getCommandPattern('test');const regex = new RegExp(pattern);-assert.ok(regex.test('npm test'), 'Should match npm test');assert.ok(regex.test('pnpm test'), 'Should match pnpm test');assert.ok(regex.test('yarn test'), 'Should match yarn test');assert.ok(regex.test('bun test'), 'Should match bun test');assert.ok(!regex.test('cargo test'), 'Should not match cargo test');- })) passed++; else failed++;+ })) passed++;+ else failed++;// getSelectionPrompt tests- console.log('\ngetSelectionPrompt:');+ console.log('+getSelectionPrompt:');if (test('returns informative prompt', () => {const prompt = pm.getSelectionPrompt();assert.ok(prompt.includes('Supported package managers'), 'Should list supported managers');assert.ok(prompt.includes('CLAUDE_PACKAGE_MANAGER'), 'Should mention env var');assert.ok(prompt.includes('lock file'), 'Should mention lock file option');- })) passed++; else failed++;+ })) passed++;+ else failed++;// setProjectPackageManager tests- console.log('\nsetProjectPackageManager:');+ console.log('+setProjectPackageManager:');if (test('sets project package manager', () => {const testDir = createTestDir();@@ -349,7 +373,6 @@ function runTests() {const result = pm.setProjectPackageManager('pnpm', testDir);assert.strictEqual(result.packageManager, 'pnpm');assert.ok(result.setAt, 'Should have setAt timestamp');-// Verify file was createdconst configPath = path.join(testDir, '.claude', 'package-manager.json');assert.ok(fs.existsSync(configPath), 'Config file should exist');@@ -358,25 +381,30 @@ function runTests() {} finally {cleanupTestDir(testDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('rejects unknown package manager', () => {assert.throws(() => {pm.setProjectPackageManager('cargo');}, /Unknown package manager/);- })) passed++; else failed++;+ })) passed++;+ else failed++;// setPreferredPackageManager tests- console.log('\nsetPreferredPackageManager:');+ console.log('+setPreferredPackageManager:');if (test('rejects unknown package manager', () => {assert.throws(() => {pm.setPreferredPackageManager('pip');}, /Unknown package manager/);- })) passed++; else failed++;+ })) passed++;+ else failed++;// detectFromPackageJson edge cases- console.log('\ndetectFromPackageJson (edge cases):');+ console.log('+detectFromPackageJson (edge cases):');if (test('handles invalid JSON in package.json', () => {const testDir = createTestDir();@@ -387,24 +415,24 @@ function runTests() {} finally {cleanupTestDir(testDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('returns null for unknown package manager in packageManager field', () => {const testDir = createTestDir();try {- fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({- name: 'test',- packageManager: '[email protected]'- }));+ fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({ name: 'test', packageManager: '[email protected]' }));const result = pm.detectFromPackageJson(testDir);assert.strictEqual(result, null);} finally {cleanupTestDir(testDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;// getExecCommand edge cases- console.log('\ngetExecCommand (edge cases):');+ console.log('+getExecCommand (edge cases):');if (test('returns exec command without args', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -419,10 +447,12 @@ function runTests() {delete process.env.CLAUDE_PACKAGE_MANAGER;}}- })) passed++; else failed++;+ })) passed++;+ else failed++;// getRunCommand additional cases- console.log('\ngetRunCommand (additional):');+ console.log('+getRunCommand (additional):');if (test('returns correct build command', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -436,7 +466,8 @@ function runTests() {delete process.env.CLAUDE_PACKAGE_MANAGER;}}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('returns correct dev command', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -450,7 +481,8 @@ function runTests() {delete process.env.CLAUDE_PACKAGE_MANAGER;}}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('returns correct custom script command', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -464,21 +496,26 @@ function runTests() {delete process.env.CLAUDE_PACKAGE_MANAGER;}}- })) passed++; else failed++;+ })) passed++;+ else failed++;// DETECTION_PRIORITY tests- console.log('\nDETECTION_PRIORITY:');+ console.log('+DETECTION_PRIORITY:');if (test('has pnpm first', () => {assert.strictEqual(pm.DETECTION_PRIORITY[0], 'pnpm');- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('has npm last', () => {assert.strictEqual(pm.DETECTION_PRIORITY[pm.DETECTION_PRIORITY.length - 1], 'npm');- })) passed++; else failed++;+ })) passed++;+ else failed++;// getCommandPattern additional cases- console.log('\ngetCommandPattern (additional):');+ console.log('+getCommandPattern (additional):');if (test('generates pattern for install command', () => {const pattern = pm.getCommandPattern('install');@@ -487,7 +524,8 @@ function runTests() {assert.ok(regex.test('pnpm install'), 'Should match pnpm install');assert.ok(regex.test('yarn'), 'Should match yarn (install implicit)');assert.ok(regex.test('bun install'), 'Should match bun install');- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('generates pattern for custom action', () => {const pattern = pm.getCommandPattern('lint');@@ -496,17 +534,18 @@ function runTests() {assert.ok(regex.test('pnpm lint'), 'Should match pnpm lint');assert.ok(regex.test('yarn lint'), 'Should match yarn lint');assert.ok(regex.test('bun run lint'), 'Should match bun run lint');- })) passed++; else failed++;+ })) passed++;+ else failed++;// getPackageManager robustness tests- console.log('\ngetPackageManager (robustness):');+ console.log('+getPackageManager (robustness):');if (test('falls through on corrupted project config JSON', () => {const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pm-robust-'));const claudeDir = path.join(testDir, '.claude');fs.mkdirSync(claudeDir, { recursive: true });fs.writeFileSync(path.join(claudeDir, 'package-manager.json'), '{not valid json!!!');-const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;try {delete process.env.CLAUDE_PACKAGE_MANAGER;@@ -520,15 +559,14 @@ function runTests() {}fs.rmSync(testDir, { recursive: true, force: true });}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('falls through on project config with unknown PM', () => {const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pm-robust-'));const claudeDir = path.join(testDir, '.claude');fs.mkdirSync(claudeDir, { recursive: true });- fs.writeFileSync(path.join(claudeDir, 'package-manager.json'),- JSON.stringify({ packageManager: 'nonexistent-pm' }));-+ fs.writeFileSync(path.join(claudeDir, 'package-manager.json'), JSON.stringify({ packageManager: 'nonexistent-pm' }));const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;try {delete process.env.CLAUDE_PACKAGE_MANAGER;@@ -541,26 +579,32 @@ function runTests() {}fs.rmSync(testDir, { recursive: true, force: true });}- })) passed++; else failed++;+ })) passed++;+ else failed++;// getRunCommand validation tests- console.log('\ngetRunCommand (validation):');+ console.log('+getRunCommand (validation):');if (test('rejects empty script name', () => {assert.throws(() => pm.getRunCommand(''), /non-empty string/);- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('rejects null script name', () => {assert.throws(() => pm.getRunCommand(null), /non-empty string/);- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('rejects script name with shell metacharacters', () => {assert.throws(() => pm.getRunCommand('test; rm -rf /'), /unsafe characters/);- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('rejects script name with backticks', () => {assert.throws(() => pm.getRunCommand('test`whoami`'), /unsafe characters/);- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('accepts scoped package names', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -575,22 +619,27 @@ function runTests() {delete process.env.CLAUDE_PACKAGE_MANAGER;}}- })) passed++; else failed++;+ })) passed++;+ else failed++;// getExecCommand validation tests- console.log('\ngetExecCommand (validation):');+ console.log('+getExecCommand (validation):');if (test('rejects empty binary name', () => {assert.throws(() => pm.getExecCommand(''), /non-empty string/);- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('rejects null binary name', () => {assert.throws(() => pm.getExecCommand(null), /non-empty string/);- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('rejects binary name with shell metacharacters', () => {assert.throws(() => pm.getExecCommand('prettier; cat /etc/passwd'), /unsafe characters/);- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('accepts dotted binary names like tsc', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -605,18 +654,18 @@ function runTests() {delete process.env.CLAUDE_PACKAGE_MANAGER;}}- })) passed++; else failed++;+ })) passed++;+ else failed++;// getPackageManager source detection tests- console.log('\ngetPackageManager (source detection):');+ console.log('+getPackageManager (source detection):');if (test('detects from valid project-config (.claude/package-manager.json)', () => {const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pm-projcfg-'));const claudeDir = path.join(testDir, '.claude');fs.mkdirSync(claudeDir, { recursive: true });- fs.writeFileSync(path.join(claudeDir, 'package-manager.json'),- JSON.stringify({ packageManager: 'pnpm' }));-+ fs.writeFileSync(path.join(claudeDir, 'package-manager.json'), JSON.stringify({ packageManager: 'pnpm' }));const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;try {delete process.env.CLAUDE_PACKAGE_MANAGER;@@ -629,22 +678,19 @@ function runTests() {}fs.rmSync(testDir, { recursive: true, force: true });}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('project-config takes priority over package.json', () => {const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pm-priority-'));const claudeDir = path.join(testDir, '.claude');fs.mkdirSync(claudeDir, { recursive: true });-// Project config says bun- fs.writeFileSync(path.join(claudeDir, 'package-manager.json'),- JSON.stringify({ packageManager: 'bun' }));+ fs.writeFileSync(path.join(claudeDir, 'package-manager.json'), JSON.stringify({ packageManager: 'bun' }));// package.json says yarn- fs.writeFileSync(path.join(testDir, 'package.json'),- JSON.stringify({ packageManager: '[email protected]' }));+ fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({ packageManager: '[email protected]' }));// Lock file says npmfs.writeFileSync(path.join(testDir, 'package-lock.json'), '{}');-const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;try {delete process.env.CLAUDE_PACKAGE_MANAGER;@@ -657,16 +703,15 @@ function runTests() {}fs.rmSync(testDir, { recursive: true, force: true });}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('package.json takes priority over lock file', () => {const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pm-pj-lock-'));// package.json says yarn- fs.writeFileSync(path.join(testDir, 'package.json'),- JSON.stringify({ packageManager: '[email protected]' }));+ fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({ packageManager: '[email protected]' }));// Lock file says npmfs.writeFileSync(path.join(testDir, 'package-lock.json'), '{}');-const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;try {delete process.env.CLAUDE_PACKAGE_MANAGER;@@ -679,7 +724,8 @@ function runTests() {}fs.rmSync(testDir, { recursive: true, force: true });}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('defaults to npm when no config found', () => {const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pm-default-'));@@ -695,10 +741,12 @@ function runTests() {}fs.rmSync(testDir, { recursive: true, force: true });}- })) passed++; else failed++;+ })) passed++;+ else failed++;// setPreferredPackageManager success- console.log('\nsetPreferredPackageManager (success):');+ console.log('+setPreferredPackageManager (success):');if (test('successfully saves preferred package manager', () => {// This writes to ~/.claude/package-manager.json — read original to restore@@ -717,31 +765,40 @@ function runTests() {if (original) {fs.writeFileSync(configPath, original, 'utf8');} else {- try { fs.unlinkSync(configPath); } catch {}+ try {+ fs.unlinkSync(configPath);+ } catch (err) {+ // ignore+ }}}- })) passed++; else failed++;+ })) passed++;+ else failed++;// getCommandPattern completeness- console.log('\ngetCommandPattern (completeness):');+ console.log('+getCommandPattern (completeness):');if (test('generates pattern for test command', () => {const pattern = pm.getCommandPattern('test');assert.ok(pattern.includes('npm test'), 'Should include npm test');assert.ok(pattern.includes('pnpm test'), 'Should include pnpm test');assert.ok(pattern.includes('bun test'), 'Should include bun test');- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('generates pattern for build command', () => {const pattern = pm.getCommandPattern('build');assert.ok(pattern.includes('npm run build'), 'Should include npm run build');assert.ok(pattern.includes('yarn build'), 'Should include yarn build');- })) passed++; else failed++;+ })) passed++;+ else failed++;// getRunCommand PM-specific format tests- console.log('\ngetRunCommand (PM-specific formats):');+ console.log('+getRunCommand (PM-specific formats):');- if (test('pnpm custom script: pnpm <script> (no run keyword)', () => {+ if (test('pnpm custom script: pnpm (no run keyword)', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;try {process.env.CLAUDE_PACKAGE_MANAGER = 'pnpm';@@ -751,7 +808,8 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('yarn custom script: yarn <script>', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -763,7 +821,8 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('bun custom script: bun run <script>', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -775,7 +834,8 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('npm custom script: npm run <script>', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -787,7 +847,8 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('pnpm install returns pnpm install', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -798,7 +859,8 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('yarn install returns yarn (no install keyword)', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -809,7 +871,8 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('bun test returns bun test', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -820,10 +883,12 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;// getExecCommand PM-specific format tests- console.log('\ngetExecCommand (PM-specific formats):');+ console.log('+getExecCommand (PM-specific formats):');if (test('pnpm exec: pnpm dlx <binary>', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -834,7 +899,8 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('yarn exec: yarn dlx <binary>', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -845,7 +911,8 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('bun exec: bunx <binary>', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -856,7 +923,8 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('ignores unknown env var package manager', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -872,110 +940,134 @@ function runTests() {delete process.env.CLAUDE_PACKAGE_MANAGER;}}- })) passed++; else failed++;+ })) passed++;+ else failed++;// ─── Round 21: getExecCommand args validation ───- console.log('\ngetExecCommand (args validation):');+ console.log('+getExecCommand (args validation):');if (test('rejects args with shell metacharacter semicolon', () => {assert.throws(() => pm.getExecCommand('prettier', '; rm -rf /'), /unsafe characters/);- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('rejects args with pipe character', () => {assert.throws(() => pm.getExecCommand('prettier', '--write . | cat'), /unsafe characters/);- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('rejects args with backtick injection', () => {assert.throws(() => pm.getExecCommand('prettier', '`whoami`'), /unsafe characters/);- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('rejects args with dollar sign', () => {assert.throws(() => pm.getExecCommand('prettier', '$HOME'), /unsafe characters/);- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('rejects args with ampersand', () => {assert.throws(() => pm.getExecCommand('prettier', '--write . && echo pwned'), /unsafe characters/);- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('allows safe args like --write .', () => {const cmd = pm.getExecCommand('prettier', '--write .');assert.ok(cmd.includes('--write .'), 'Should include safe args');- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('allows empty args without trailing space', () => {const cmd = pm.getExecCommand('prettier', '');assert.ok(!cmd.endsWith(' '), 'Should not have trailing space for empty args');- })) passed++; else failed++;+ })) passed++;+ else failed++;// ─── Round 21: getCommandPattern regex escaping ───- console.log('\ngetCommandPattern (regex escaping):');+ console.log('+getCommandPattern (regex escaping):');if (test('escapes dot in action name for regex safety', () => {const pattern = pm.getCommandPattern('test.all');- // The dot should be escaped to \\. in the pattern+ // The dot should be escaped to \. in the patternconst regex = new RegExp(pattern);assert.ok(regex.test('npm run test.all'), 'Should match literal dot');assert.ok(!regex.test('npm run testXall'), 'Should NOT match arbitrary character in place of dot');- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('escapes brackets in action name', () => {const pattern = pm.getCommandPattern('build[prod]');const regex = new RegExp(pattern);assert.ok(regex.test('npm run build[prod]'), 'Should match literal brackets');- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('escapes parentheses in action name', () => {// Should not throw when compiled as regexconst pattern = pm.getCommandPattern('foo(bar)');assert.doesNotThrow(() => new RegExp(pattern), 'Should produce valid regex with escaped parens');- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 27: input validation and escapeRegex edge cases ──- console.log('\ngetRunCommand (non-string input):');+ console.log('+getRunCommand (non-string input):');if (test('rejects undefined script name', () => {assert.throws(() => pm.getRunCommand(undefined), /non-empty string/);- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('rejects numeric script name', () => {assert.throws(() => pm.getRunCommand(123), /non-empty string/);- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('rejects boolean script name', () => {assert.throws(() => pm.getRunCommand(true), /non-empty string/);- })) passed++; else failed++;+ })) passed++;+ else failed++;- console.log('\ngetExecCommand (non-string binary):');+ console.log('+getExecCommand (non-string binary):');if (test('rejects undefined binary name', () => {assert.throws(() => pm.getExecCommand(undefined), /non-empty string/);- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('rejects numeric binary name', () => {assert.throws(() => pm.getExecCommand(42), /non-empty string/);- })) passed++; else failed++;+ })) passed++;+ else failed++;- console.log('\ngetCommandPattern (escapeRegex completeness):');+ console.log('+getCommandPattern (escapeRegex completeness):');if (test('escapes all regex metacharacters in action', () => {// All regex metacharacters: . * + ? ^ $ { } ( ) | [ ] \- const action = 'test.*+?^${}()|[]\\';+ const action = 'test.*+?^${}()|[]\\\\';const pattern = pm.getCommandPattern(action);// Should produce a valid regex without throwingassert.doesNotThrow(() => new RegExp(pattern), 'Should produce valid regex');// Should match the literal stringconst regex = new RegExp(pattern);assert.ok(regex.test(`npm run ${action}`), 'Should match literal metacharacters');- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('escapeRegex preserves alphanumeric chars', () => {const pattern = pm.getCommandPattern('simple-test');const regex = new RegExp(pattern);assert.ok(regex.test('npm run simple-test'), 'Should match simple action name');assert.ok(!regex.test('npm run simpleXtest'), 'Dash should not match arbitrary char');- })) passed++; else failed++;+ })) passed++;+ else failed++;- console.log('\ngetPackageManager (global config edge cases):');+ console.log('+getPackageManager (global config edge cases):');if (test('ignores global config with non-string packageManager', () => {// This tests the path through loadConfig where packageManager is not a valid PM name@@ -991,41 +1083,48 @@ function runTests() {process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;}}- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 30: getCommandPattern with special action patterns ──- console.log('\nRound 30: getCommandPattern edge cases:');+ console.log('+Round 30: getCommandPattern edge cases:');if (test('escapes pipe character in action name', () => {const pattern = pm.getCommandPattern('lint|fix');const regex = new RegExp(pattern);assert.ok(regex.test('npm run lint|fix'), 'Should match literal pipe');assert.ok(!regex.test('npm run lint'), 'Pipe should be literal, not regex OR');- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('escapes dollar sign in action name', () => {const pattern = pm.getCommandPattern('deploy$prod');const regex = new RegExp(pattern);assert.ok(regex.test('npm run deploy$prod'), 'Should match literal dollar sign');- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('handles action with leading/trailing spaces gracefully', () => {// Spaces aren't special in regex but good to test the full patternconst pattern = pm.getCommandPattern(' dev ');const regex = new RegExp(pattern);- assert.ok(regex.test('npm run dev '), 'Should match action with spaces');- })) passed++; else failed++;+ assert.ok(regex.test('npm run dev '), 'Should match action with spaces');+ })) passed++;+ else failed++;- if (test('known action "dev" does NOT use escapeRegex path', () => {- // "dev" is a known action with hardcoded patterns, not the generic path+ if (test('known action \"dev\" does NOT use escapeRegex path', () => {+ // \"dev\" is a known action with hardcoded patterns, not the generic pathconst pattern = pm.getCommandPattern('dev');- // Should match pnpm dev (without "run")+ // Should match pnpm dev (without \"run\")const regex = new RegExp(pattern);assert.ok(regex.test('pnpm dev'), 'Known action pnpm dev should match');- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 31: setProjectPackageManager write verification ──- console.log('\nsetProjectPackageManager (write verification, Round 31):');+ console.log('+setProjectPackageManager (write verification, Round 31):');if (test('setProjectPackageManager creates .claude directory if missing', () => {const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pm-mkdir-'));@@ -1039,7 +1138,8 @@ function runTests() {} finally {fs.rmSync(testDir, { recursive: true, force: true });}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('setProjectPackageManager includes setAt timestamp', () => {const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pm-ts-'));@@ -1052,10 +1152,12 @@ function runTests() {} finally {fs.rmSync(testDir, { recursive: true, force: true });}- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 31: getExecCommand safe argument edge cases ──- console.log('\ngetExecCommand (safe argument edge cases, Round 31):');+ console.log('+getExecCommand (safe argument edge cases, Round 31):');if (test('allows colons in args (e.g. --fix:all)', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -1067,7 +1169,8 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('allows at-sign in args (e.g. @latest)', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -1079,7 +1182,8 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('allows equals in args (e.g. --config=path)', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -1091,10 +1195,12 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 34: getExecCommand non-string args & packageManager type ──- console.log('\nRound 34: getExecCommand non-string args:');+ console.log('+Round 34: getExecCommand non-string args:');if (test('getExecCommand with args=0 produces command without extra args', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -1108,7 +1214,8 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('getExecCommand with args=false produces command without extra args', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -1121,7 +1228,8 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('getExecCommand with args=null produces command without extra args', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -1134,88 +1242,92 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;- console.log('\nRound 34: detectFromPackageJson with non-string packageManager:');+ console.log('+Round 34: detectFromPackageJson with non-string packageManager:');if (test('detectFromPackageJson handles array packageManager field gracefully', () => {const tmpDir = createTestDir();try {// Write a malformed package.json with array instead of string- fs.writeFileSync(path.join(tmpDir, 'package.json'),- JSON.stringify({ packageManager: ['pnpm@8', 'yarn@3'] }));+ fs.writeFileSync(path.join(tmpDir, 'package.json'), JSON.stringify({ packageManager: ['pnpm@8', 'yarn@3'] }));// Should not crash — try/catch in detectFromPackageJson catches TypeErrorconst result = pm.getPackageManager({ projectDir: tmpDir });assert.ok(result.name, 'Should fallback to a valid package manager');} finally {fs.rmSync(tmpDir, { recursive: true, force: true });}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('detectFromPackageJson handles numeric packageManager field gracefully', () => {const tmpDir = createTestDir();try {- fs.writeFileSync(path.join(tmpDir, 'package.json'),- JSON.stringify({ packageManager: 42 }));+ fs.writeFileSync(path.join(tmpDir, 'package.json'), JSON.stringify({ packageManager: 42 }));const result = pm.getPackageManager({ projectDir: tmpDir });assert.ok(result.name, 'Should fallback to a valid package manager');} finally {fs.rmSync(tmpDir, { recursive: true, force: true });}- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 48: detectFromPackageJson format edge cases ──- console.log('\nRound 48: detectFromPackageJson (version format edge cases):');+ console.log('+Round 48: detectFromPackageJson (version format edge cases):');if (test('returns null for packageManager with non-@ separator', () => {const testDir = createTestDir();try {- fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({- name: 'test',- packageManager: 'pnpm+8.6.0'- }));+ fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({ name: 'test', packageManager: 'pnpm+8.6.0' }));const result = pm.detectFromPackageJson(testDir);// split('@') on 'pnpm+8.6.0' returns ['pnpm+8.6.0'], which doesn't match PACKAGE_MANAGERSassert.strictEqual(result, null, 'Non-@ format should not match any package manager');} finally {cleanupTestDir(testDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;if (test('extracts package manager from caret version like yarn@^4.0.0', () => {const testDir = createTestDir();try {- fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({- name: 'test',- packageManager: 'yarn@^4.0.0'- }));+ fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({ name: 'test', packageManager: 'yarn@^4.0.0' }));const result = pm.detectFromPackageJson(testDir);assert.strictEqual(result, 'yarn', 'Caret version should still extract PM name');} finally {cleanupTestDir(testDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;// getPackageManager falls through corrupted global config to npm defaultif (test('getPackageManager falls through corrupted global config to npm default', () => {const tmpDir = createTestDir();const projDir = path.join(tmpDir, 'proj');fs.mkdirSync(projDir, { recursive: true });+const origHome = process.env.HOME;const origUserProfile = process.env.USERPROFILE;const origPM = process.env.CLAUDE_PACKAGE_MANAGER;+try {// Create corrupted global config fileconst claudeDir = path.join(tmpDir, '.claude');fs.mkdirSync(claudeDir, { recursive: true });fs.writeFileSync(path.join(claudeDir, 'package-manager.json'), '{ invalid json !!!', 'utf8');+process.env.HOME = tmpDir;process.env.USERPROFILE = tmpDir;delete process.env.CLAUDE_PACKAGE_MANAGER;+// Re-require to pick up new HOMEdelete require.cache[require.resolve('../../scripts/lib/package-manager')];delete require.cache[require.resolve('../../scripts/lib/utils')];const freshPM = require('../../scripts/lib/package-manager');+// Empty project dir: no lock file, no package.json, no project configconst result = freshPM.getPackageManager({ projectDir: projDir });assert.strictEqual(result.name, 'npm', 'Should fall through to npm default');@@ -1224,35 +1336,42 @@ function runTests() {process.env.HOME = origHome;process.env.USERPROFILE = origUserProfile;if (origPM !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = origPM;+delete require.cache[require.resolve('../../scripts/lib/package-manager')];delete require.cache[require.resolve('../../scripts/lib/utils')];cleanupTestDir(tmpDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 69: getPackageManager global-config success path ──- console.log('\nRound 69: getPackageManager (global-config success):');+ console.log('+Round 69: getPackageManager (global-config success):');if (test('getPackageManager returns source global-config when valid global config exists', () => {const tmpDir = createTestDir();const projDir = path.join(tmpDir, 'proj');fs.mkdirSync(projDir, { recursive: true });+const origHome = process.env.HOME;const origUserProfile = process.env.USERPROFILE;const origPM = process.env.CLAUDE_PACKAGE_MANAGER;+try {// Create valid global config with pnpm preferenceconst claudeDir = path.join(tmpDir, '.claude');fs.mkdirSync(claudeDir, { recursive: true });- fs.writeFileSync(path.join(claudeDir, 'package-manager.json'),- JSON.stringify({ packageManager: 'pnpm', setAt: '2026-01-01T00:00:00Z' }), 'utf8');+ fs.writeFileSync(path.join(claudeDir, 'package-manager.json'), JSON.stringify({ packageManager: 'pnpm', setAt: '2026-01-01T00:00:00Z' }), 'utf8');+process.env.HOME = tmpDir;process.env.USERPROFILE = tmpDir;delete process.env.CLAUDE_PACKAGE_MANAGER;+// Re-require to pick up new HOMEdelete require.cache[require.resolve('../../scripts/lib/package-manager')];delete require.cache[require.resolve('../../scripts/lib/utils')];const freshPM = require('../../scripts/lib/package-manager');+// Empty project dir: no lock file, no package.json, no project configconst result = freshPM.getPackageManager({ projectDir: projDir });assert.strictEqual(result.name, 'pnpm', 'Should detect pnpm from global config');@@ -1263,24 +1382,26 @@ function runTests() {process.env.HOME = origHome;process.env.USERPROFILE = origUserProfile;if (origPM !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = origPM;+delete require.cache[require.resolve('../../scripts/lib/package-manager')];delete require.cache[require.resolve('../../scripts/lib/utils')];cleanupTestDir(tmpDir);}- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 71: setPreferredPackageManager save failure wraps error ──- console.log('\nRound 71: setPreferredPackageManager (save failure):');+ console.log('+Round 71: setPreferredPackageManager (save failure):');if (test('setPreferredPackageManager throws wrapped error when save fails', () => {if (process.platform === 'win32' || process.getuid?.() === 0) {- console.log(' (skipped — chmod ineffective on Windows/root)');+ console.log(' (skipped — chmod ineffective on Windows/root)');return;}const isoHome = path.join(os.tmpdir(), `ecc-pm-r71-${Date.now()}`);const claudeDir = path.join(isoHome, '.claude');fs.mkdirSync(claudeDir, { recursive: true });-const savedHome = process.env.HOME;const savedProfile = process.env.USERPROFILE;try {@@ -1289,38 +1410,40 @@ function runTests() {delete require.cache[require.resolve('../../scripts/lib/package-manager')];delete require.cache[require.resolve('../../scripts/lib/utils')];const freshPm = require('../../scripts/lib/package-manager');-// Make .claude directory read-only — can't create new files (package-manager.json)fs.chmodSync(claudeDir, 0o555);-assert.throws(() => {freshPm.setPreferredPackageManager('npm');}, /Failed to save package manager preference/);} finally {- try { fs.chmodSync(claudeDir, 0o755); } catch { /* best-effort */ }+ try {+ fs.chmodSync(claudeDir, 0o755);+ } catch (err) {+ /* best-effort */+ }process.env.HOME = savedHome;process.env.USERPROFILE = savedProfile;delete require.cache[require.resolve('../../scripts/lib/package-manager')];delete require.cache[require.resolve('../../scripts/lib/utils')];fs.rmSync(isoHome, { recursive: true, force: true });}- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 72: setProjectPackageManager save failure wraps error ──- console.log('\nRound 72: setProjectPackageManager (save failure):');+ console.log('+Round 72: setProjectPackageManager (save failure):');if (test('setProjectPackageManager throws wrapped error when write fails', () => {if (process.platform === 'win32' || process.getuid?.() === 0) {- console.log(' (skipped — chmod ineffective on Windows/root)');+ console.log(' (skipped — chmod ineffective on Windows/root)');return;}const isoProject = path.join(os.tmpdir(), `ecc-pm-proj-r72-${Date.now()}`);const claudeDir = path.join(isoProject, '.claude');fs.mkdirSync(claudeDir, { recursive: true });-// Make .claude directory read-only — can't create new filesfs.chmodSync(claudeDir, 0o555);-try {assert.throws(() => {pm.setProjectPackageManager('npm', isoProject);@@ -1329,10 +1452,12 @@ function runTests() {fs.chmodSync(claudeDir, 0o755);fs.rmSync(isoProject, { recursive: true, force: true });}- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 80: getExecCommand with truthy non-string args ──- console.log('\nRound 80: getExecCommand (truthy non-string args):');+ console.log('+Round 80: getExecCommand (truthy non-string args):');if (test('getExecCommand with args=42 (truthy number) appends stringified value', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;@@ -1340,7 +1465,7 @@ function runTests() {process.env.CLAUDE_PACKAGE_MANAGER = 'npm';// args=42: truthy, so typeof check at line 334 short-circuits// (typeof 42 !== 'string'), skipping validation. Line 339:- // 42 ? ' ' + 42 → ' 42' → appended.+ // 42 ? ' ' + 42 -> ' 42' -> appended.const cmd = pm.getExecCommand('prettier', 42);assert.ok(cmd.includes('prettier'), 'Should include binary name');assert.ok(cmd.includes('42'), 'Truthy number should be stringified and appended');@@ -1348,23 +1473,27 @@ function runTests() {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 86: detectFromPackageJson with empty (0-byte) package.json ──- console.log('\nRound 86: detectFromPackageJson (empty package.json):');+ console.log('+Round 86: detectFromPackageJson (empty package.json):');if (test('detectFromPackageJson returns null for empty (0-byte) package.json', () => {// package-manager.js line 109-111: readFile returns "" for empty file.- // "" is falsy → if (content) is false → skips JSON.parse → returns null.+ // "" is falsy -> if (content) is false -> skips JSON.parse -> returns null.const testDir = createTestDir();fs.writeFileSync(path.join(testDir, 'package.json'), '');const result = pm.detectFromPackageJson(testDir);assert.strictEqual(result, null, 'Empty package.json should return null (content="" is falsy)');cleanupTestDir(testDir);- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 91: getCommandPattern with empty action string ──- console.log('\nRound 91: getCommandPattern (empty action):');+ console.log('+Round 91: getCommandPattern (empty action):');if (test('getCommandPattern with empty string returns valid regex pattern', () => {// package-manager.js line 401-409: Empty action falls to the else branch.@@ -1379,72 +1508,81 @@ function runTests() {// The pattern should match package manager commands with trailing spaceassert.ok(regex.test('npm run '), 'Should match "npm run " with trailing space');assert.ok(regex.test('yarn '), 'Should match "yarn " with trailing space');- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 91: detectFromPackageJson with whitespace-only packageManager ──- console.log('\nRound 91: detectFromPackageJson (whitespace-only packageManager):');+ console.log('+Round 91: detectFromPackageJson (whitespace-only packageManager):');if (test('detectFromPackageJson returns null for whitespace-only packageManager field', () => {- // package-manager.js line 114-119: " " is truthy, so enters the if block.- // " ".split('@')[0] = " " which doesn't match any PACKAGE_MANAGERS key.+ // package-manager.js line 114-119: \" \" is truthy, so enters the if block.+ // \" \".split('@')[0] = \" \" which doesn't match any PACKAGE_MANAGERS key.const testDir = createTestDir();fs.writeFileSync(path.join(testDir, 'package.json'),- JSON.stringify({ packageManager: ' ' }));+ JSON.stringify({ packageManager: ' ' })+ );const result = pm.detectFromPackageJson(testDir);assert.strictEqual(result, null, 'Whitespace-only packageManager should return null');cleanupTestDir(testDir);- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 92: detectFromPackageJson with empty string packageManager ──- console.log('\nRound 92: detectFromPackageJson (empty string packageManager):');+ console.log('+Round 92: detectFromPackageJson (empty string packageManager):');if (test('detectFromPackageJson returns null for empty string packageManager field', () => {- // package-manager.js line 114: if (pkg.packageManager) — empty string "" is falsy,+ // package-manager.js line 114: if (pkg.packageManager) — empty string \"\" is falsy,// so the if block is skipped entirely. Function returns null without attempting split.- // This is distinct from Round 91's whitespace test (" " is truthy and enters the if).+ // This is distinct from Round 91's whitespace test (\" \" is truthy and enters the if).const testDir = createTestDir();fs.writeFileSync(path.join(testDir, 'package.json'),- JSON.stringify({ name: 'test', packageManager: '' }));+ JSON.stringify({ name: 'test', packageManager: '' })+ );const result = pm.detectFromPackageJson(testDir);assert.strictEqual(result, null, 'Empty string packageManager should return null (falsy)');cleanupTestDir(testDir);- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 94: detectFromPackageJson with scoped package name ──- console.log('\nRound 94: detectFromPackageJson (scoped package name @scope/pkg@version):');+ console.log('+Round 94: detectFromPackageJson (scoped package name @scope/pkg@version):');if (test('detectFromPackageJson returns null for scoped package name (@scope/pkg@version)', () => {- // package-manager.js line 116: pmName = pkg.packageManager.split('@')[0]- // For "@pnpm/[email protected]", split('@') → ['', 'pnpm/exe', '8.0.0'], so [0] = ''- // PACKAGE_MANAGERS[''] is undefined → returns null.- // Scoped npm packages like @pnpm/exe are a real-world pattern but the- // packageManager field spec uses unscoped names (e.g., "pnpm@8"), so returning+ // package-manager.js line 116: pmName = pkg.packageManager.split('@')[0]\+ // For \\\"@pnpm/[email protected]\\\", split('@') -> ['', 'pnpm/exe', '8.0.0'], so [0] = ''\+ // PACKAGE_MANAGERS[''] is undefined -> returns null.\+ // Scoped npm packages like @pnpm/exe are a real-world pattern but the\+ // packageManager field spec uses unscoped names (e.g., \\\"pnpm@8\\\"), so returning\// null is the correct defensive behaviour for this edge case.const testDir = createTestDir();fs.writeFileSync(path.join(testDir, 'package.json'),- JSON.stringify({ name: 'test', packageManager: '@pnpm/[email protected]' }));+ JSON.stringify({ name: 'test', packageManager: '@pnpm/[email protected]' })+ );const result = pm.detectFromPackageJson(testDir);- assert.strictEqual(result, null,- 'Scoped package name should return null (split("@")[0] is empty string)');+ assert.strictEqual(result, null, 'Scoped package name should return null (split(\"@\")[0] is empty string)');cleanupTestDir(testDir);- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 94: getPackageManager with empty string CLAUDE_PACKAGE_MANAGER ──- console.log('\nRound 94: getPackageManager (empty string CLAUDE_PACKAGE_MANAGER env var):');+ console.log('+Round 94: getPackageManager (empty string CLAUDE_PACKAGE_MANAGER env var):');if (test('getPackageManager skips empty string CLAUDE_PACKAGE_MANAGER (falsy short-circuit)', () => {- // package-manager.js line 168: if (envPm && PACKAGE_MANAGERS[envPm])- // Empty string '' is falsy — the && short-circuits before checking PACKAGE_MANAGERS.+ // package-manager.js line 168: if (envPm && PACKAGE_MANAGERS[envPm])\+ // Empty string '' is falsy — the && short-circuits before checking PACKAGE_MANAGERS.\// This is distinct from the 'totally-fake-pm' test (truthy but unknown PM).const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;try {process.env.CLAUDE_PACKAGE_MANAGER = '';const result = pm.getPackageManager();- assert.notStrictEqual(result.source, 'environment',- 'Empty string env var should NOT be treated as environment source');+ assert.notStrictEqual(result.source, 'environment', 'Empty string env var should NOT be treated as environment source');assert.ok(result.name, 'Should still return a valid package manager name');} finally {if (originalEnv !== undefined) {@@ -1453,56 +1591,62 @@ function runTests() {delete process.env.CLAUDE_PACKAGE_MANAGER;}}- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 104: detectFromLockFile with null projectDir (no input validation) ──- console.log('\nRound 104: detectFromLockFile (null projectDir — throws TypeError):');+ console.log('+Round 104: detectFromLockFile (null projectDir — throws TypeError):');+if (test('detectFromLockFile(null) throws TypeError (path.join rejects null)', () => {- // package-manager.js line 95: `path.join(projectDir, pm.lockFile)` — there is no- // guard checking that projectDir is a string before passing it to path.join().- // When projectDir is null, path.join(null, 'package-lock.json') throws a TypeError+ // package-manager.js line 95: `path.join(projectDir, pm.lockFile)` — there is no\+ // guard checking that projectDir is a string before passing it to path.join().\+ // When projectDir is null, path.join(null, 'package-lock.json') throws a TypeError\// because path.join only accepts string arguments.assert.throws(() => pm.detectFromLockFile(null),{ name: 'TypeError' },'path.join(null, ...) should throw TypeError (no input validation in detectFromLockFile)');- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 105: getExecCommand with object args (bypasses SAFE_ARGS_REGEX, coerced to [object Object]) ──- console.log('\nRound 105: getExecCommand (object args — typeof bypass coerces to [object Object]):');-- if (test('getExecCommand with args={} bypasses SAFE_ARGS validation and coerces to "[object Object]"', () => {- // package-manager.js line 334: `if (args && typeof args === 'string' && !SAFE_ARGS_REGEX.test(args))`- // When args is an object: typeof {} === 'object' (not 'string'), so the- // SAFE_ARGS_REGEX check is entirely SKIPPED.- // Line 339: `args ? ' ' + args : ''` — object is truthy, so it reaches- // string concatenation which calls {}.toString() → "[object Object]"- // Final command: "npx prettier [object Object]" — brackets bypass validation.+ console.log('+Round 105: getExecCommand (object args — typeof bypass coerces to [object Object]):');++ if (test('getExecCommand with args={} bypasses SAFE_ARGS validation and coerces to \"[object Object]\"', () => {+ // package-manager.js line 334: `if (args && typeof args === 'string' && !SAFE_ARGS_REGEX.test(args))`\+ // When args is an object: typeof {} === 'object' (not 'string'), so the\+ // SAFE_ARGS_REGEX check is entirely SKIPPED.\+ // Line 339: `args ? ' ' + args : ''` — object is truthy, so it reaches\+ // string concatenation which calls {}.toString() -> \"[object Object]\"\+ // Final command: \"npx prettier [object Object]\" — brackets bypass validation.const cmd = pm.getExecCommand('prettier', {});- assert.ok(cmd.includes('[object Object]'),- 'Object args should be coerced to "[object Object]" via implicit toString()');+ assert.ok(cmd.includes('[object Object]'), 'Object args should be coerced to \"[object Object]\" via implicit toString()');// Verify the SAFE_ARGS regex WOULD reject this string if it were a string argassert.throws(() => pm.getExecCommand('prettier', '[object Object]'),/unsafe characters/,- 'Same string as explicit string arg is correctly rejected by SAFE_ARGS_REGEX');- })) passed++; else failed++;+ 'Same string as explicit string arg is correctly rejected by SAFE_ARGS_REGEX'+ );+ })) passed++;+ else failed++;// ── Round 109: getExecCommand with ../ path traversal in binary — SAFE_NAME_REGEX allows it ──- console.log('\nRound 109: getExecCommand (path traversal in binary — SAFE_NAME_REGEX permits ../ in binary name):');+ console.log('+Round 109: getExecCommand (path traversal in binary — SAFE_NAME_REGEX permits ../ in binary name):');+if (test('getExecCommand accepts ../../../etc/passwd as binary because SAFE_NAME_REGEX allows ../', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;try {process.env.CLAUDE_PACKAGE_MANAGER = 'npm';- // SAFE_NAME_REGEX = /^[@a-zA-Z0-9_.\/-]+$/ individually allows . and /+ // SAFE_NAME_REGEX = /^[@a-zA-Z0-9_.\\/-\\\\]+$/ individually allows . and /\const cmd = pm.getExecCommand('../../../etc/passwd');- assert.strictEqual(cmd, 'npx ../../../etc/passwd',- 'Path traversal in binary passes SAFE_NAME_REGEX because . and / are individually allowed');+ assert.strictEqual(cmd, 'npx ../../../etc/passwd', 'Path traversal in binary passes SAFE_NAME_REGEX because . and / are individually allowed');// Also verify scoped path traversalconst cmd2 = pm.getExecCommand('@scope/../../evil');- assert.strictEqual(cmd2, 'npx @scope/../../evil',- 'Scoped path traversal also passes the regex');+ assert.strictEqual(cmd2, 'npx @scope/../../evil', 'Scoped path traversal also passes the regex');} finally {if (originalEnv !== undefined) {process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;@@ -1510,23 +1654,24 @@ function runTests() {delete process.env.CLAUDE_PACKAGE_MANAGER;}}- })) passed++; else failed++;+ })) passed++;+ else failed++;// ── Round 108: getRunCommand with path traversal — SAFE_NAME_REGEX allows ../ sequences ──- console.log('\nRound 108: getRunCommand (path traversal — SAFE_NAME_REGEX permits ../ via allowed / and . chars):');+ console.log('+Round 108: getRunCommand (path traversal — SAFE_NAME_REGEX permits ../ via allowed / and . chars):');+if (test('getRunCommand accepts @scope/../../evil because SAFE_NAME_REGEX allows ../', () => {const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;try {process.env.CLAUDE_PACKAGE_MANAGER = 'npm';- // SAFE_NAME_REGEX = /^[@a-zA-Z0-9_.\/-]+$/ allows each char individually,+ // SAFE_NAME_REGEX = /^[@a-zA-Z0-9_.\\/-\\\\]+$/ allows each char individually,\// so '../' passes despite being a path traversal sequenceconst cmd = pm.getRunCommand('@scope/../../evil');- assert.strictEqual(cmd, 'npm run @scope/../../evil',- 'Path traversal passes SAFE_NAME_REGEX because / and . are individually allowed');+ assert.strictEqual(cmd, 'npm run @scope/../../evil', 'Path traversal passes SAFE_NAME_REGEX because / and . are individually allowed');// Also verify plain ../ passesconst cmd2 = pm.getRunCommand('../../../etc/passwd');- assert.strictEqual(cmd2, 'npm run ../../../etc/passwd',- 'Bare ../ traversal also passes the regex');+ assert.strictEqual(cmd2, 'npm run ../../../etc/passwd', 'Bare ../ traversal also passes the regex');} finally {if (originalEnv !== undefined) {process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;@@ -1534,40 +1679,52 @@ function runTests() {delete process.env.CLAUDE_PACKAGE_MANAGER;}}- })) passed++; else failed++;-- // ── Round 111: getExecCommand with newline in args — SAFE_ARGS_REGEX \s includes \n ──- console.log('\nRound 111: getExecCommand (newline in args — SAFE_ARGS_REGEX \\s matches \\n):');- if (test('getExecCommand accepts newline in args because SAFE_ARGS_REGEX \\s includes \\n', () => {- // SAFE_ARGS_REGEX = /^[@a-zA-Z0-9\s_.\/:=,'"*+-]+$/- // \s matches [\t\n\v\f\r ] — includes newline!- // This means "file.js\nmalicious" passes the regex.+ })) passed++;+ else failed++;++ // ── Round 111: getExecCommand with newline in args — SAFE_ARGS_REGEX \\s includes+ ──+ console.log('+Round 111: getExecCommand (newline in args — SAFE_ARGS_REGEX \\\\\\\\s matches \\\\\+):');++ if (test('getExecCommand accepts newline in args because SAFE_ARGS_REGEX \\\\\\\\s includes \\\\\+', () => {+ // SAFE_ARGS_REGEX = /^[@a-zA-Z0-9\\\\s_.\\\\/:=,'\\\"*+-\\\\]+$/\+ // \\\\\\\\s matches [\\\ \\\+\\\\v\\\\f\\\\r ] — includes newline!\+ // This means \\\"file.js\\\+malicious\\\" passes the regex.const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;try {process.env.CLAUDE_PACKAGE_MANAGER = 'npm';- // Newline in args should pass SAFE_ARGS_REGEX because \s matches \n- const cmd = pm.getExecCommand('prettier', 'file.js\necho injected');- assert.strictEqual(cmd, 'npx prettier file.js\necho injected',- 'Newline passes SAFE_ARGS_REGEX (\\s includes \\n) — potential command injection vector');+ // Newline in args should pass SAFE_ARGS_REGEX because \\\\\\\\s matches \\\\\+\+ const cmd = pm.getExecCommand('prettier', 'file.js\+echo injected');+ assert.strictEqual(cmd, 'npx prettier file.js\+echo injected', 'Newline passes SAFE_ARGS_REGEX (\\\\\\\\s includes \\\\\+) — potential command injection vector');// Tab also passes- const cmd2 = pm.getExecCommand('eslint', 'file.js\t--fix');- assert.strictEqual(cmd2, 'npx eslint file.js\t--fix',- 'Tab also passes SAFE_ARGS_REGEX via \\s');+ const cmd2 = pm.getExecCommand('eslint', 'file.js\ --fix');+ assert.strictEqual(cmd2, 'npx eslint file.js\ --fix', 'Tab also passes SAFE_ARGS_REGEX via \\\\\\\\s');// Carriage return also passes- const cmd3 = pm.getExecCommand('tsc', 'src\r--strict');- assert.strictEqual(cmd3, 'npx tsc src\r--strict',- 'Carriage return passes via \\s');+ const cmd3 = pm.getExecCommand('tsc', 'src\\r--strict');+ assert.strictEqual(cmd3, 'npx tsc src\\r--strict', 'Carriage return passes via \\\\\\\\s');} finally {if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;else delete process.env.CLAUDE_PACKAGE_MANAGER;}- })) passed++; else failed++;+ })) passed++;+ else failed++;// Summary- console.log('\n=== Test Results ===');+ console.log('+=== Test Results ===');console.log(`Passed: ${passed}`);console.log(`Failed: ${failed}`);- console.log(`Total: ${passed + failed}\n`);+ console.log(`Total: ${passed + failed}+`);process.exit(failed > 0 ? 1 : 0);}