Skip to content

armgit / ECC

Public Imported from GitHub
0

The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.

test(hooks): avoid repeated giant wrapper payloads (#2940)

haelyra11813f968cc0
diff --git a/tests/hooks/stop-hooks-stdout.test.js b/tests/hooks/stop-hooks-stdout.test.js
index 707f16c2f..1de6bb9c2 100644
--- a/tests/hooks/stop-hooks-stdout.test.js
+++ b/tests/hooks/stop-hooks-stdout.test.js
@@ -184,6 +184,21 @@ for (const entry of hooksConfig.hooks.Stop) {
const representativeStopEntry = hooksConfig.hooks.Stop.find(
entry => entry.id === 'stop:cost-tracker'
);
+const CALLBACK_FLUSH_WRAPPER = 'const finish=(out,err,code)=>{let pending=1;const done=()=>{pending-=1;if(pending===0)process.exit(code);};if(out){pending+=1;process.stdout.write(out,done);}if(err){pending+=1;process.stderr.write(err,done);}process.nextTick(done);};';
+
+if (
+ test('all registered Stop wrappers keep the large-output flush contract', () => {
+ for (const entry of hooksConfig.hooks.Stop) {
+ assert.match(entry.hooks[0].command, /maxBuffer:16\*1024\*1024/);
+ assert.ok(
+ entry.hooks[0].command.includes(CALLBACK_FLUSH_WRAPPER),
+ `${entry.id}: wrapper must wait for stdout and stderr callbacks before exiting`
+ );
+ }
+ })
+)
+ passed++;
+else failed++;
if (
test('registered Stop wrapper flushes a 100KB dry-run payload', () => {
@@ -209,25 +224,26 @@ const multibytePayload = stopPayload(400 * 1024, '한');
assert.ok(multibytePayload.length < MAX_STDIN, 'fixture must stay below the runner character cap');
assert.ok(Buffer.byteLength(multibytePayload) > MAX_STDIN, 'fixture must exceed the default byte buffer');
-for (const entry of hooksConfig.hooks.Stop) {
- if (
- test(`${entry.id} registered wrapper preserves a multibyte sub-cap payload`, () => {
- const result = runRegisteredStopHook(entry, multibytePayload);
- assert.strictEqual(
- result.status,
- 0,
- `${entry.id}: expected exit 0, got ${result.status}: ${result.stderr}`
- );
- assert.ok(
- result.stdout === multibytePayload,
- `${entry.id}: registered wrapper must echo ${Buffer.byteLength(multibytePayload)} bytes uncut (got ${Buffer.byteLength(result.stdout)})`
- );
- JSON.parse(result.stdout);
- })
- )
- passed++;
- else failed++;
-}
+// Every registered command uses the same generated wrapper, verified above.
+// Exercise the multi-megabyte byte-buffer edge once so the test does not
+// amplify hosted-runner load by serializing the identical payload seven times.
+if (
+ test('registered Stop wrapper preserves a multibyte sub-cap payload', () => {
+ const result = runRegisteredStopHook(representativeStopEntry, multibytePayload);
+ assert.strictEqual(
+ result.status,
+ 0,
+ `expected exit 0, got ${result.status}: ${result.stderr}`
+ );
+ assert.ok(
+ result.stdout === multibytePayload,
+ `registered wrapper must echo ${Buffer.byteLength(multibytePayload)} bytes uncut (got ${Buffer.byteLength(result.stdout)})`
+ );
+ JSON.parse(result.stdout);
+ })
+)
+ passed++;
+else failed++;
for (const [hookId, script] of STOP_HOOKS) {
if (
@@ -262,25 +278,19 @@ if (
passed++;
else failed++;
-for (const entry of hooksConfig.hooks.Stop) {
- if (
- test(`${entry.id} registered wrapper suppresses a >1MB Stop payload`, () => {
- const result = runRegisteredStopHook(entry, oversizedPayload);
- assert.strictEqual(
- result.status,
- 0,
- `${entry.id}: expected exit 0, got ${result.status}: ${result.stderr}`
- );
- assert.strictEqual(
- result.stdout.length,
- 0,
- `${entry.id}: wrapper must preserve oversized-input suppression (got ${result.stdout.length} characters)`
- );
- })
- )
- passed++;
- else failed++;
-}
+if (
+ test('registered Stop wrapper suppresses a >1MB Stop payload', () => {
+ const result = runRegisteredStopHook(representativeStopEntry, oversizedPayload);
+ assert.strictEqual(result.status, 0, `expected exit 0, got ${result.status}: ${result.stderr}`);
+ assert.strictEqual(
+ result.stdout.length,
+ 0,
+ `wrapper must preserve oversized-input suppression (got ${result.stdout.length} characters)`
+ );
+ })
+)
+ passed++;
+else failed++;
for (const [hookId, script] of [...STOP_HOOKS, ['stop:desktop-notify', 'scripts/hooks/desktop-notify.js']]) {
if (