The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.
test(gateguard): fail the allow-cases when the hook returns nothing
Nguyen Thanh Dat249b0ecf7fdd
diff --git a/tests/hooks/gateguard-fact-force.test.js b/tests/hooks/gateguard-fact-force.test.jsindex fcf6f400b..f83677b0d 100644--- a/tests/hooks/gateguard-fact-force.test.js+++ b/tests/hooks/gateguard-fact-force.test.js@@ -315,13 +315,22 @@ function runTests() {// be mistaken for a destructive denial.runBashHook({ tool_name: 'Bash', tool_input: { command: 'printf ready' } });const result = runBashHook({ tool_name: 'Bash', tool_input: { command } });+ // Assert the hook actually answered before reading the decision: a+ // crashed or silent hook makes parseOutput return null, and a bare+ // `if (output)` would let this case pass without testing anything.+ assert.strictEqual(result.code, 0, `hook should exit 0 for ${command}`);const output = parseOutput(result.stdout);- if (output && output.hookSpecificOutput) {- const reason = output.hookSpecificOutput.permissionDecisionReason || '';+ assert.ok(output, `hook should produce JSON output for ${command}`);+ const decision = output.hookSpecificOutput;+ if (decision) {+ const reason = decision.permissionDecisionReason || '';assert.ok(- output.hookSpecificOutput.permissionDecision !== 'deny' || !reason.includes('Destructive'),+ decision.permissionDecision !== 'deny' || !reason.includes('Destructive'),`${command} must not be gated as destructive`);+ } else {+ // Pass-through echoes the input back unchanged.+ assert.strictEqual(output.tool_name, 'Bash', 'pass-through should preserve input');}}))