The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.
test: cover evaluate-session/suggest-compact main().catch and validate-hooks JSON parse
Affaan Mustafa27ae5ea29966
diff --git a/tests/ci/validators.test.js b/tests/ci/validators.test.jsindex 2654235d9..fd35d5b7b 100644--- a/tests/ci/validators.test.js+++ b/tests/ci/validators.test.js@@ -1991,6 +1991,22 @@ function runTests() {fs.rmSync(skillsDir, { recursive: true, force: true });})) passed++; else failed++;+ // ── Round 76: validate-hooks.js invalid JSON in hooks.json ──+ console.log('\nRound 76: validate-hooks.js (invalid JSON in hooks.json):');++ if (test('reports error for invalid JSON in hooks.json', () => {+ const testDir = createTestDir();+ const hooksFile = path.join(testDir, 'hooks.json');+ fs.writeFileSync(hooksFile, '{not valid json!!!');++ const result = runValidatorWithDir('validate-hooks', 'HOOKS_FILE', hooksFile);+ assert.strictEqual(result.code, 1,+ `Expected exit 1 for invalid JSON, got ${result.code}`);+ assert.ok(result.stderr.includes('Invalid JSON'),+ `stderr should mention Invalid JSON, got: ${result.stderr}`);+ cleanupTestDir(testDir);+ })) passed++; else failed++;+// Summaryconsole.log(`\nResults: Passed: ${passed}, Failed: ${failed}`);process.exit(failed > 0 ? 1 : 0);diff --git a/tests/hooks/hooks.test.js b/tests/hooks/hooks.test.jsindex 193bb4801..cc4a9cd54 100644--- a/tests/hooks/hooks.test.js+++ b/tests/hooks/hooks.test.js@@ -3213,6 +3213,45 @@ async function runTests() {`stderr should contain [SessionEnd] Error:, got: ${result.stderr}`);})) passed++; else failed++;+ // ── Round 76: evaluate-session.js main().catch handler ──+ console.log('\nRound 76: evaluate-session.js (main catch — unrecoverable error):');++ if (await asyncTest('evaluate-session exits 0 with error message when HOME is non-directory', async () => {+ if (process.platform === 'win32') {+ console.log(' (skipped — /dev/null not available on Windows)');+ return;+ }+ // HOME=/dev/null makes ensureDir(learnedSkillsPath) throw ENOTDIR,+ // which propagates to main().catch — the top-level error boundary+ const result = await runScript(path.join(scriptsDir, 'evaluate-session.js'), '{}', {+ HOME: '/dev/null',+ USERPROFILE: '/dev/null'+ });+ assert.strictEqual(result.code, 0,+ `Should exit 0 (don't block on errors), got ${result.code}`);+ assert.ok(result.stderr.includes('[ContinuousLearning] Error:'),+ `stderr should contain [ContinuousLearning] Error:, got: ${result.stderr}`);+ })) passed++; else failed++;++ // ── Round 76: suggest-compact.js main().catch handler ──+ console.log('\nRound 76: suggest-compact.js (main catch — double-failure):');++ if (await asyncTest('suggest-compact exits 0 with error when TMPDIR is non-directory', async () => {+ if (process.platform === 'win32') {+ console.log(' (skipped — /dev/null not available on Windows)');+ return;+ }+ // TMPDIR=/dev/null causes openSync to fail (ENOTDIR), then the catch+ // fallback writeFile also fails, propagating to main().catch+ const result = await runScript(path.join(scriptsDir, 'suggest-compact.js'), '', {+ TMPDIR: '/dev/null'+ });+ assert.strictEqual(result.code, 0,+ `Should exit 0 (don't block on errors), got ${result.code}`);+ assert.ok(result.stderr.includes('[StrategicCompact] Error:'),+ `stderr should contain [StrategicCompact] Error:, got: ${result.stderr}`);+ })) passed++; else failed++;+// Summaryconsole.log('\n=== Test Results ===');console.log(`Passed: ${passed}`);