The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.
fix(hooks): scan full costs.jsonl when locating session row
Jamkris63c9788f502f
diff --git a/scripts/hooks/ecc-metrics-bridge.js b/scripts/hooks/ecc-metrics-bridge.jsindex f446dd24f..5b2c05e6d 100644--- a/scripts/hooks/ecc-metrics-bridge.js+++ b/scripts/hooks/ecc-metrics-bridge.js@@ -77,46 +77,44 @@ function extractFilePaths(toolName, toolInput) {}/**- * Read cumulative cost for a session from the tail of costs.jsonl.- * Reads last 8KB to avoid scanning entire file.+ * Read cumulative cost for a session from costs.jsonl.+ *+ * Scans the full file because each row is a cumulative session total+ * (see cost-tracker.js docblock) and the row we need is the last one+ * matching `sessionId`. The previous implementation read only the+ * trailing 8 KiB; any session whose latest cumulative row was pushed+ * past that window by newer rows from other sessions silently dropped+ * to zero — the opposite sign of the double-count bug fixed in the+ * previous commit.+ *+ * costs.jsonl is append-only and unbounded today (no rotation in+ * cost-tracker.js). At a typical ~150 bytes per row, even 100k rows+ * is ~15 MB and a single sync read on every PreToolUse hook is in+ * the low milliseconds. If rotation lands later, this scan becomes+ * even cheaper.*/function readSessionCost(sessionId) {try {const costsPath = path.join(getClaudeDir(), 'metrics', 'costs.jsonl');- const stat = fs.statSync(costsPath);- const readSize = Math.min(stat.size, 8192);- const fd = fs.openSync(costsPath, 'r');- try {- const buf = Buffer.alloc(readSize);- fs.readSync(fd, buf, 0, readSize, Math.max(0, stat.size - readSize));- const lines = buf.toString('utf8').split('\n').filter(Boolean);-- // Each row in costs.jsonl is *already* a cumulative session total — see- // scripts/hooks/cost-tracker.js: "Each row therefore represents the- // cumulative session total up to that point. To get per-session cost,- // take the last row per session_id." Summing every matching row- // therefore double-counts: for N rows of the same session it over-- // reports by roughly N(N+1)/2 / N = (N+1)/2 ×. Take the last matching- // row instead.- let totalCost = 0;- let totalIn = 0;- let totalOut = 0;- for (const line of lines) {- try {- const row = JSON.parse(line);- if (row.session_id === sessionId) {- totalCost = toNumber(row.estimated_cost_usd);- totalIn = toNumber(row.input_tokens);- totalOut = toNumber(row.output_tokens);- }- } catch {- /* skip malformed lines */+ const content = fs.readFileSync(costsPath, 'utf8');+ const lines = content.split('\n').filter(Boolean);++ let totalCost = 0;+ let totalIn = 0;+ let totalOut = 0;+ for (const line of lines) {+ try {+ const row = JSON.parse(line);+ if (row.session_id === sessionId) {+ totalCost = toNumber(row.estimated_cost_usd);+ totalIn = toNumber(row.input_tokens);+ totalOut = toNumber(row.output_tokens);}+ } catch {+ /* skip malformed lines */}- return { totalCost, totalIn, totalOut };- } finally {- fs.closeSync(fd);}+ return { totalCost, totalIn, totalOut };} catch {return { totalCost: 0, totalIn: 0, totalOut: 0 };}diff --git a/tests/hooks/ecc-metrics-bridge.test.js b/tests/hooks/ecc-metrics-bridge.test.jsindex bf1cc72cb..109e0b6c9 100644--- a/tests/hooks/ecc-metrics-bridge.test.js+++ b/tests/hooks/ecc-metrics-bridge.test.js@@ -184,6 +184,47 @@ function runTests() {passed++;else failed++;+ if (+ test('readSessionCost finds session row beyond the old 8 KiB tail boundary', () => {+ // The previous implementation read only the trailing 8 KiB of+ // costs.jsonl. A long-running deployment where the target session's+ // most recent cumulative row sat further back than that — e.g.+ // pushed past by many rows from OTHER sessions — silently saw+ // cost=0. This test wedges the S1 row at the file start, fills+ // ~16 KiB of OTHER-session noise after it, and asserts the S1 row+ // is still found.+ const tmpHome = makeTempHome();+ const originalHome = process.env.HOME;+ const originalUserProfile = process.env.USERPROFILE;+ try {+ process.env.HOME = tmpHome;+ process.env.USERPROFILE = tmpHome;+ const metricsDir = path.join(tmpHome, '.claude', 'metrics');+ fs.mkdirSync(metricsDir, { recursive: true });+ const otherRow = JSON.stringify({ session_id: 'OTHER', estimated_cost_usd: 1, input_tokens: 100, output_tokens: 50 });+ const s1Row = JSON.stringify({ session_id: 'S1', estimated_cost_usd: 0.5, input_tokens: 500, output_tokens: 250 });+ const rows = [s1Row, ...Array(200).fill(otherRow)];+ fs.writeFileSync(path.join(metricsDir, 'costs.jsonl'), rows.join('\n') + '\n', 'utf8');+ // Confirm we're actually past the old 8 KiB ceiling so the test+ // would have failed under the previous implementation.+ const size = fs.statSync(path.join(metricsDir, 'costs.jsonl')).size;+ assert.ok(size > 8192, `setup: expected costs.jsonl > 8 KiB, got ${size} bytes`);+ const result = readSessionCost('S1');+ assert.strictEqual(result.totalCost, 0.5);+ assert.strictEqual(result.totalIn, 500);+ assert.strictEqual(result.totalOut, 250);+ } finally {+ if (originalHome === undefined) delete process.env.HOME;+ else process.env.HOME = originalHome;+ if (originalUserProfile === undefined) delete process.env.USERPROFILE;+ else process.env.USERPROFILE = originalUserProfile;+ fs.rmSync(tmpHome, { recursive: true, force: true });+ }+ })+ )+ passed++;+ else failed++;+if (test('readSessionCost does not include unrelated default-session rows', () => {const tmpHome = makeTempHome();