Skip to content

armgit / ECC

Public Imported from GitHub
0

The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.

test(install): isolate dependency manifest variants immutably

Dante81ddae39df9e
diff --git a/tests/lib/install-manifests.test.js b/tests/lib/install-manifests.test.js
index e14f61225..70a7fed08 100644
--- a/tests/lib/install-manifests.test.js
+++ b/tests/lib/install-manifests.test.js
@@ -740,27 +740,37 @@ function runTests() {
assert.deepStrictEqual(requiredPlan.skippedModuleIds, ['parent', 'child']);
const modulesPath = path.join(repoRoot, 'manifests', 'install-modules.json');
- const manifest = JSON.parse(fs.readFileSync(modulesPath, 'utf8'));
- manifest.modules[0].optionalDependencies = ['child'];
- writeJson(modulesPath, manifest);
+ const baseManifest = JSON.parse(fs.readFileSync(modulesPath, 'utf8'));
+ const optionalModules = baseManifest.modules.map((module, index) => (
+ index === 0 ? { ...module, optionalDependencies: ['child'] } : { ...module }
+ ));
+ writeJson(modulesPath, { ...baseManifest, modules: optionalModules });
const optionalPlan = resolveInstallPlan({ repoRoot, profileId: 'core', target: 'claude' });
assert.deepStrictEqual(optionalPlan.selectedModuleIds, ['parent']);
assert.deepStrictEqual(optionalPlan.skippedModuleIds, ['child']);
- manifest.modules[1].targets = ['claude'];
- writeJson(modulesPath, manifest);
+ const supportedModules = optionalModules.map((module, index) => (
+ index === 1 ? { ...module, targets: ['claude'] } : { ...module }
+ ));
+ writeJson(modulesPath, { ...baseManifest, modules: supportedModules });
const supportedPlan = resolveInstallPlan({ repoRoot, profileId: 'core', target: 'claude' });
assert.deepStrictEqual(supportedPlan.selectedModuleIds, ['parent', 'child']);
- manifest.modules[1].dependencies = ['grandchild'];
- manifest.modules.push({ ...manifest.modules[1], id: 'grandchild', targets: ['cursor'], dependencies: [] });
- writeJson(modulesPath, manifest);
+ const transitiveModules = [
+ ...supportedModules.map((module, index) => (
+ index === 1 ? { ...module, dependencies: ['grandchild'] } : { ...module }
+ )),
+ { ...supportedModules[1], id: 'grandchild', targets: ['cursor'], dependencies: [] }
+ ];
+ writeJson(modulesPath, { ...baseManifest, modules: transitiveModules });
const transitivePlan = resolveInstallPlan({ repoRoot, profileId: 'core', target: 'claude' });
assert.deepStrictEqual(transitivePlan.selectedModuleIds, []);
assert.deepStrictEqual(transitivePlan.skippedModuleIds, ['parent', 'child', 'grandchild']);
- manifest.modules[0].optionalDependencies = ['missing'];
- writeJson(modulesPath, manifest);
+ const invalidModules = baseManifest.modules.map((module, index) => (
+ index === 0 ? { ...module, optionalDependencies: ['missing'] } : { ...module }
+ ));
+ writeJson(modulesPath, { ...baseManifest, modules: invalidModules });
assert.throws(
() => resolveInstallPlan({ repoRoot, profileId: 'core', target: 'claude' }),
/optionalDependencies must be an array of declared dependency ids/