The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.
fix: validate instinct confidence before status rendering
Eneko Ruiz8b755a66df32
diff --git a/skills/continuous-learning-v2/scripts/instinct-cli.py b/skills/continuous-learning-v2/scripts/instinct-cli.pyindex f7f35abbb..baf02e9d9 100755--- a/skills/continuous-learning-v2/scripts/instinct-cli.py+++ b/skills/continuous-learning-v2/scripts/instinct-cli.py@@ -551,7 +551,8 @@ def parse_instinct_file(content: str) -> list[dict]:value = value[1:-1].replace("''", "'")if key == 'confidence':try:- current[key] = float(value)+ confidence = float(value)+ current[key] = confidence if 0.0 <= confidence <= 1.0 else 0.5except ValueError:current[key] = 0.5 # default on malformed confidenceelse:diff --git a/skills/continuous-learning-v2/scripts/test_parse_instinct.py b/skills/continuous-learning-v2/scripts/test_parse_instinct.pyindex f58c58853..8b895727f 100644--- a/skills/continuous-learning-v2/scripts/test_parse_instinct.py+++ b/skills/continuous-learning-v2/scripts/test_parse_instinct.py@@ -252,6 +252,18 @@ Body.assert result[0]["confidence"] == pytest.approx(0.42)[email protected]("confidence", ["nan", "inf", "-inf", "1e309", "-0.1", "1.1", "invalid"])+def test_parse_invalid_confidence_uses_default(confidence):+ content = SAMPLE_INSTINCT_YAML.replace("confidence: 0.8", f"confidence: {confidence}")+ assert parse_instinct_file(content)[0]["confidence"] == 0.5++[email protected]("confidence", [0.0, 0.42, 1.0])+def test_parse_confidence_preserves_valid_range(confidence):+ content = SAMPLE_INSTINCT_YAML.replace("confidence: 0.8", f"confidence: {confidence}")+ assert parse_instinct_file(content)[0]["confidence"] == confidence++def test_parse_trigger_strips_quotes():content = """\---@@ -671,6 +683,17 @@ def test_cmd_status_with_instincts(patch_globals, monkeypatch, capsys):assert "GLOBAL" in out[email protected]("confidence", ["inf", "-inf", "nan"])+def test_cmd_status_handles_nonfinite_confidence(patch_globals, monkeypatch, capsys, confidence):+ project = _make_project(patch_globals)+ monkeypatch.setattr(_mod, "detect_project", lambda: project)+ content = SAMPLE_INSTINCT_YAML.replace("confidence: 0.8", f"confidence: {confidence}")+ (project["instincts_personal"] / "nonfinite.yaml").write_text(content, encoding="utf-8")++ assert cmd_status(SimpleNamespace()) == 0+ assert "50%" in capsys.readouterr().out++def test_confidence_bar_uses_unicode_when_supported():"""Confidence bars should retain block glyphs on UTF-8 streams."""stream = SimpleNamespace(encoding="utf-8")