Skip to content

armgit / ECC

Public Imported from GitHub
0

The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.

feat(agents): add typescript-reviewer agent (#647)

teee3290c3486e0354
diff --git a/AGENTS.md b/AGENTS.md
index bad37ea48..c417b3408 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -1,6 +1,6 @@
# Everything Claude Code (ECC) — Agent Instructions
-This is a **production-ready AI coding plugin** providing 25 specialized agents, 108 skills, 57 commands, and automated hook workflows for software development.
+This is a **production-ready AI coding plugin** providing 26 specialized agents, 108 skills, 57 commands, and automated hook workflows for software development.
## Core Principles
@@ -23,6 +23,9 @@ This is a **production-ready AI coding plugin** providing 25 specialized agents,
| e2e-runner | End-to-end Playwright testing | Critical user flows |
| refactor-cleaner | Dead code cleanup | Code maintenance |
| doc-updater | Documentation and codemaps | Updating docs |
+| docs-lookup | Documentation and API reference research | Library/API documentation questions |
+| cpp-reviewer | C++ code review | C++ projects |
+| cpp-build-resolver | C++ build errors | C++ build failures |
| go-reviewer | Go code review | Go projects |
| go-build-resolver | Go build errors | Go build failures |
| kotlin-reviewer | Kotlin code review | Kotlin/Android/KMP projects |
@@ -36,6 +39,7 @@ This is a **production-ready AI coding plugin** providing 25 specialized agents,
| harness-optimizer | Harness config tuning | Reliability, cost, throughput |
| rust-reviewer | Rust code review | Rust projects |
| rust-build-resolver | Rust build errors | Rust build failures |
+| typescript-reviewer | TypeScript/JavaScript code review | TypeScript/JavaScript projects |
## Agent Orchestration
@@ -134,8 +138,8 @@ Troubleshoot failures: check test isolation → verify mocks → fix implementat
## Project Structure
```
-agents/ — 25 specialized subagents
-skills/ — 102 workflow skills and domain knowledge
+agents/ — 26 specialized subagents
+skills/ — 108 workflow skills and domain knowledge
commands/ — 57 slash commands
hooks/ — Trigger-based automations
rules/ — Always-follow guidelines (common + per-language)
diff --git a/README.md b/README.md
index c5f23d902..818b7f1f4 100644
--- a/README.md
+++ b/README.md
@@ -191,7 +191,7 @@ For manual install instructions see the README in the `rules/` folder.
/plugin list everything-claude-code@everything-claude-code
```
-✨ **That's it!** You now have access to 25 agents, 108 skills, and 57 commands.
+✨ **That's it!** You now have access to 26 agents, 108 skills, and 57 commands.
---
@@ -262,10 +262,14 @@ everything-claude-code/
| |-- e2e-runner.md # Playwright E2E testing
| |-- refactor-cleaner.md # Dead code cleanup
| |-- doc-updater.md # Documentation sync
+| |-- docs-lookup.md # Documentation/API lookup
+| |-- cpp-reviewer.md # C++ code review
+| |-- cpp-build-resolver.md # C++ build error resolution
| |-- go-reviewer.md # Go code review
| |-- go-build-resolver.md # Go build error resolution
| |-- python-reviewer.md # Python code review (NEW)
| |-- database-reviewer.md # Database/Supabase review (NEW)
+| |-- typescript-reviewer.md # TypeScript/JavaScript code review (NEW)
|
|-- skills/ # Workflow definitions and domain knowledge
| |-- coding-standards/ # Language best practices
@@ -720,6 +724,7 @@ Not sure where to start? Use this quick reference:
| Update documentation | `/update-docs` | doc-updater |
| Review Go code | `/go-review` | go-reviewer |
| Review Python code | `/python-review` | python-reviewer |
+| Review TypeScript/JavaScript code | *(invoke `typescript-reviewer` directly)* | typescript-reviewer |
| Audit database queries | *(auto-delegated)* | database-reviewer |
### Common Workflows
@@ -1042,7 +1047,7 @@ The configuration is automatically detected from `.opencode/opencode.json`.
| Feature | Claude Code | OpenCode | Status |
|---------|-------------|----------|--------|
-| Agents | ✅ 25 agents | ✅ 12 agents | **Claude Code leads** |
+| Agents | ✅ 26 agents | ✅ 12 agents | **Claude Code leads** |
| Commands | ✅ 57 commands | ✅ 31 commands | **Claude Code leads** |
| Skills | ✅ 108 skills | ✅ 37 skills | **Claude Code leads** |
| Hooks | ✅ 8 event types | ✅ 11 events | **OpenCode has more!** |
diff --git a/agents/typescript-reviewer.md b/agents/typescript-reviewer.md
new file mode 100644
index 000000000..6cfd0e122
--- /dev/null
+++ b/agents/typescript-reviewer.md
@@ -0,0 +1,112 @@
+---
+name: typescript-reviewer
+description: Expert TypeScript/JavaScript code reviewer specializing in type safety, async correctness, Node/web security, and idiomatic patterns. Use for all TypeScript and JavaScript code changes. MUST BE USED for TypeScript/JavaScript projects.
+tools: ["Read", "Grep", "Glob", "Bash"]
+model: sonnet
+---
+
+You are a senior TypeScript engineer ensuring high standards of type-safe, idiomatic TypeScript and JavaScript.
+
+When invoked:
+1. Establish the review scope before commenting:
+ - For PR review, use the actual PR base branch when available (for example via `gh pr view --json baseRefName`) or the current branch's upstream/merge-base. Do not hard-code `main`.
+ - For local review, prefer `git diff --staged` and `git diff` first.
+ - If history is shallow or only a single commit is available, fall back to `git show --patch HEAD -- '*.ts' '*.tsx' '*.js' '*.jsx'` so you still inspect code-level changes.
+2. Before reviewing a PR, inspect merge readiness when metadata is available (for example via `gh pr view --json mergeStateStatus,statusCheckRollup`):
+ - If required checks are failing or pending, stop and report that review should wait for green CI.
+ - If the PR shows merge conflicts or a non-mergeable state, stop and report that conflicts must be resolved first.
+ - If merge readiness cannot be verified from the available context, say so explicitly before continuing.
+3. Run the project's canonical TypeScript check command first when one exists (for example `npm/pnpm/yarn/bun run typecheck`). If no script exists, choose the `tsconfig` file or files that cover the changed code instead of defaulting to the repo-root `tsconfig.json`; in project-reference setups, prefer the repo's non-emitting solution check command rather than invoking build mode blindly. Otherwise use `tsc --noEmit -p <relevant-config>`. Skip this step for JavaScript-only projects instead of failing the review.
+4. Run `eslint . --ext .ts,.tsx,.js,.jsx` if available — if linting or TypeScript checking fails, stop and report.
+5. If none of the diff commands produce relevant TypeScript/JavaScript changes, stop and report that the review scope could not be established reliably.
+6. Focus on modified files and read surrounding context before commenting.
+7. Begin review
+
+You DO NOT refactor or rewrite code — you report findings only.
+
+## Review Priorities
+
+### CRITICAL -- Security
+- **Injection via `eval` / `new Function`**: User-controlled input passed to dynamic execution — never execute untrusted strings
+- **XSS**: Unsanitised user input assigned to `innerHTML`, `dangerouslySetInnerHTML`, or `document.write`
+- **SQL/NoSQL injection**: String concatenation in queries — use parameterised queries or an ORM
+- **Path traversal**: User-controlled input in `fs.readFile`, `path.join` without `path.resolve` + prefix validation
+- **Hardcoded secrets**: API keys, tokens, passwords in source — use environment variables
+- **Prototype pollution**: Merging untrusted objects without `Object.create(null)` or schema validation
+- **`child_process` with user input**: Validate and allowlist before passing to `exec`/`spawn`
+
+### HIGH -- Type Safety
+- **`any` without justification**: Disables type checking — use `unknown` and narrow, or a precise type
+- **Non-null assertion abuse**: `value!` without a preceding guard — add a runtime check
+- **`as` casts that bypass checks**: Casting to unrelated types to silence errors — fix the type instead
+- **Relaxed compiler settings**: If `tsconfig.json` is touched and weakens strictness, call it out explicitly
+
+### HIGH -- Async Correctness
+- **Unhandled promise rejections**: `async` functions called without `await` or `.catch()`
+- **Sequential awaits for independent work**: `await` inside loops when operations could safely run in parallel — consider `Promise.all`
+- **Floating promises**: Fire-and-forget without error handling in event handlers or constructors
+- **`async` with `forEach`**: `array.forEach(async fn)` does not await — use `for...of` or `Promise.all`
+
+### HIGH -- Error Handling
+- **Swallowed errors**: Empty `catch` blocks or `catch (e) {}` with no action
+- **`JSON.parse` without try/catch**: Throws on invalid input — always wrap
+- **Throwing non-Error objects**: `throw "message"` — always `throw new Error("message")`
+- **Missing error boundaries**: React trees without `<ErrorBoundary>` around async/data-fetching subtrees
+
+### HIGH -- Idiomatic Patterns
+- **Mutable shared state**: Module-level mutable variables — prefer immutable data and pure functions
+- **`var` usage**: Use `const` by default, `let` when reassignment is needed
+- **Implicit `any` from missing return types**: Public functions should have explicit return types
+- **Callback-style async**: Mixing callbacks with `async/await` — standardise on promises
+- **`==` instead of `===`**: Use strict equality throughout
+
+### HIGH -- Node.js Specifics
+- **Synchronous fs in request handlers**: `fs.readFileSync` blocks the event loop — use async variants
+- **Missing input validation at boundaries**: No schema validation (zod, joi, yup) on external data
+- **Unvalidated `process.env` access**: Access without fallback or startup validation
+- **`require()` in ESM context**: Mixing module systems without clear intent
+
+### MEDIUM -- React / Next.js (when applicable)
+- **Missing dependency arrays**: `useEffect`/`useCallback`/`useMemo` with incomplete deps — use exhaustive-deps lint rule
+- **State mutation**: Mutating state directly instead of returning new objects
+- **Key prop using index**: `key={index}` in dynamic lists — use stable unique IDs
+- **`useEffect` for derived state**: Compute derived values during render, not in effects
+- **Server/client boundary leaks**: Importing server-only modules into client components in Next.js
+
+### MEDIUM -- Performance
+- **Object/array creation in render**: Inline objects as props cause unnecessary re-renders — hoist or memoize
+- **N+1 queries**: Database or API calls inside loops — batch or use `Promise.all`
+- **Missing `React.memo` / `useMemo`**: Expensive computations or components re-running on every render
+- **Large bundle imports**: `import _ from 'lodash'` — use named imports or tree-shakeable alternatives
+
+### MEDIUM -- Best Practices
+- **`console.log` left in production code**: Use a structured logger
+- **Magic numbers/strings**: Use named constants or enums
+- **Deep optional chaining without fallback**: `a?.b?.c?.d` with no default — add `?? fallback`
+- **Inconsistent naming**: camelCase for variables/functions, PascalCase for types/classes/components
+
+## Diagnostic Commands
+
+```bash
+npm run typecheck --if-present # Canonical TypeScript check when the project defines one
+tsc --noEmit -p <relevant-config> # Fallback type check for the tsconfig that owns the changed files
+eslint . --ext .ts,.tsx,.js,.jsx # Linting
+prettier --check . # Format check
+npm audit # Dependency vulnerabilities (or the equivalent yarn/pnpm/bun audit command)
+vitest run # Tests (Vitest)
+jest --ci # Tests (Jest)
+```
+
+## Approval Criteria
+
+- **Approve**: No CRITICAL or HIGH issues
+- **Warning**: MEDIUM issues only (can merge with caution)
+- **Block**: CRITICAL or HIGH issues found
+
+## Reference
+
+This repo does not yet ship a dedicated `typescript-patterns` skill. For detailed TypeScript and JavaScript patterns, use `coding-standards` plus `frontend-patterns` or `backend-patterns` based on the code being reviewed.
+
+---
+
+Review with the mindset: "Would this code pass review at a top TypeScript shop or well-maintained open-source project?"
diff --git a/docs/COMMAND-AGENT-MAP.md b/docs/COMMAND-AGENT-MAP.md
index d5e462de3..70bcacfc1 100644
--- a/docs/COMMAND-AGENT-MAP.md
+++ b/docs/COMMAND-AGENT-MAP.md
@@ -1,6 +1,6 @@
# Command → Agent / Skill Map
-This document lists each slash command and the primary agent(s) or skills it invokes. Use it to discover which commands use which agents and to keep refactoring consistent.
+This document lists each slash command and the primary agent(s) or skills it invokes, plus notable direct-invoke agents. Use it to discover which commands use which agents and to keep refactoring consistent.
| Command | Primary agent(s) | Notes |
|---------|------------------|--------|
@@ -46,6 +46,12 @@ This document lists each slash command and the primary agent(s) or skills it inv
| `/pm2` | — | PM2 service lifecycle |
| `/security-scan` | security-reviewer (skill) | AgentShield via security-scan skill |
+## Direct-Use Agents
+
+| Direct agent | Purpose | Scope | Notes |
+|--------------|---------|-------|-------|
+| `typescript-reviewer` | TypeScript/JavaScript code review | TypeScript/JavaScript projects | Invoke the agent directly when a review needs TS/JS-specific findings and there is no dedicated slash command yet. |
+
## Skills referenced by commands
- **continuous-learning**, **continuous-learning-v2**: `/learn`, `/learn-eval`, `/instinct-*`, `/evolve`, `/promote`, `/projects`