The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.
fix(ci): unescape node -e inline programs in one pass
Affaan Mustafa944ea9d0503a
diff --git a/scripts/ci/validate-hooks.js b/scripts/ci/validate-hooks.jsindex 1523e8653..338bfbb83 100644--- a/scripts/ci/validate-hooks.js+++ b/scripts/ci/validate-hooks.js@@ -87,6 +87,13 @@ function isStringRecord(value) {&& Object.values(value).every(item => typeof item === 'string');}+const INLINE_ESCAPES = { '\\': '\\', '"': '"', n: '\n', t: '\t' };++/** Unescape a shell double-quoted `node -e` body in one pass, so `\\n` stays a literal backslash and n. */+function unescapeInlineJs(source) {+ return source.replace(/\\(["\\nt])/g, (match, ch) => INLINE_ESCAPES[ch]);+}+/*** Compile the inline program of a `node -e "..."` command so a typo in* hooks.json fails validation instead of every hook invocation.@@ -96,7 +103,7 @@ function validateInlineJs(command, label) {const nodeEMatch = command.match(/^node -e "((?:[^"\\]|\\.)*)"(?:\s|$)/s);if (!nodeEMatch) return false;try {- new vm.Script(nodeEMatch[1].replace(/\\\\/g, '\\').replace(/\\"/g, '"').replace(/\\n/g, '\n').replace(/\\t/g, '\t'));+ new vm.Script(unescapeInlineJs(nodeEMatch[1]));return false;} catch (syntaxErr) {console.error(`ERROR: ${label} has invalid inline JS: ${syntaxErr.message}`);diff --git a/tests/ci/validators.test.js b/tests/ci/validators.test.jsindex ace7ccbdb..1eda199f9 100644--- a/tests/ci/validators.test.js+++ b/tests/ci/validators.test.js@@ -1039,6 +1039,21 @@ function runTests() {cleanupTestDir(testDir);})) passed++; else failed++;+ if (test('unescapes inline JS in one pass so an escaped backslash before n stays literal', () => {+ const testDir = createTestDir();+ const hooksFile = path.join(testDir, 'hooks.json');+ // Shell body `console.log('\\n')` is a valid program; a sequential unescape turned it into a raw newline.+ fs.writeFileSync(hooksFile, JSON.stringify({+ hooks: {+ PreToolUse: [{ id: 'test:escaped-backslash-inline-js', matcher: 'test', hooks: [{ type: 'command', command: 'node -e "console.log(\'\\\\n\')"' }] }]+ }+ }));++ const result = runValidatorWithDir('validate-hooks', 'HOOKS_FILE', hooksFile);+ assert.strictEqual(result.code, 0, `Should pass escaped-backslash inline JS, stderr: ${result.stderr}`);+ cleanupTestDir(testDir);+ })) passed++; else failed++;+if (test('validates array command format', () => {const testDir = createTestDir();const hooksFile = path.join(testDir, 'hooks.json');