Skip to content

armgit / ECC

Public Imported from GitHub
0

The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.

fix: normalize viewport evidence labels

Samuel Bushi980e637c3cf3
diff --git a/skills/frontend-design-direction/SKILL.md b/skills/frontend-design-direction/SKILL.md
index 6e850835c..e112bbf95 100644
--- a/skills/frontend-design-direction/SKILL.md
+++ b/skills/frontend-design-direction/SKILL.md
@@ -136,6 +136,10 @@ The record contains:
- `targetViewports`: a nonempty array of viewport strings from the contract,
such as `["390x844", "1440x900"]`. Each target requires a matching `viewport`
entry in `renderedEvidence`; one mobile capture cannot cover a desktop target.
+ Matching ignores case and whitespace and checks duplicate targets once.
+ Use consistent labels when writing the record: `375 px` matches `375px`,
+ but `mobile-375`, `375px` and `375x812` remain distinct. The checker does not
+ infer aliases, units or dimensions and does not rewrite the record.
- `accessibility` and `responsive`: objects with `status: "pass"` and a nonempty
`evidence` observation describing the checks performed.
- `contentStates`: one object for each of `loading`, `empty`, `error`, `partial`,
diff --git a/skills/frontend-design-direction/scripts/check-evidence.js b/skills/frontend-design-direction/scripts/check-evidence.js
index c15c963e8..a45d0f2b3 100644
--- a/skills/frontend-design-direction/scripts/check-evidence.js
+++ b/skills/frontend-design-direction/scripts/check-evidence.js
@@ -5,6 +5,7 @@ const fs = require('node:fs');
const path = require('node:path');
const text = value => typeof value === 'string' && value.trim().length > 0;
+const viewportKey = value => value.trim().toLowerCase().replace(/\s+/g, '');
const object = value => value !== null && typeof value === 'object' && !Array.isArray(value);
const states = ['loading', 'empty', 'error', 'partial', 'success', 'permission'];
@@ -18,10 +19,11 @@ function checkEvidence(report) {
};
const renders = Array.isArray(report.renderedEvidence) ? report.renderedEvidence : [];
const targets = Array.isArray(report.targetViewports) ? report.targetViewports : [];
+ const targetKeys = [...new Set(targets.filter(text).map(viewportKey))];
return [
...(text(report.contract) ? [] : ['contract is required']),
...(targets.length && targets.every(text) ? [] : ['targetViewports must contain nonempty viewport strings']),
- ...targets.filter(text).flatMap(viewport => renders.some(item => object(item) && item.viewport === viewport)
+ ...targetKeys.flatMap(viewport => renders.some(item => object(item) && text(item.viewport) && viewportKey(item.viewport) === viewport)
? [] : [`renderedEvidence is missing target viewport ${viewport}`]),
...check('accessibility', report.accessibility),
...check('responsive', report.responsive),
diff --git a/tests/skills/frontend-design-direction.test.js b/tests/skills/frontend-design-direction.test.js
index f9f3daffb..b316f7177 100644
--- a/tests/skills/frontend-design-direction.test.js
+++ b/tests/skills/frontend-design-direction.test.js
@@ -51,6 +51,44 @@ test('requires rendered evidence for every declared target viewport', () => {
}
});
+test('normalizes viewport case and whitespace, deduplicates missing coverage, and preserves input', () => {
+ const evidence = {
+ ...report(),
+ targetViewports: [' 390 X 844 PX ', '390x844px', '1440 X 900 PX'],
+ renderedEvidence: [
+ { viewport: '390x844PX', artifact: 'render.png', observation: 'Mobile layout fits.' },
+ { viewport: ' 1440x900px ', artifact: 'desktop.png', observation: 'Desktop layout fits.' },
+ ],
+ };
+ const before = JSON.parse(JSON.stringify(evidence));
+
+ assert.deepEqual(checkEvidence(evidence), []);
+ assert.deepEqual(evidence, before, 'viewport validation must not mutate the report');
+
+ const missing = {
+ ...evidence,
+ renderedEvidence: [],
+ };
+ const missingErrors = checkEvidence(missing).filter(error => error.includes('missing target viewport'));
+ assert.equal(missingErrors.length, 2, 'missing coverage should report one error per normalized target');
+ assert.deepEqual(evidence, before, 'coverage checks must not mutate the report');
+
+ for (const [targetViewport, renderedViewport] of [
+ ['mobile-375', '375px'],
+ ['375', '375px'],
+ ]) {
+ const aliases = {
+ ...report(),
+ targetViewports: [targetViewport],
+ renderedEvidence: [{ viewport: renderedViewport, artifact: 'render.png', observation: 'Checked.' }],
+ };
+ assert.ok(
+ checkEvidence(aliases).some(error => error.includes('missing target viewport')),
+ `${targetViewport} must not alias ${renderedViewport}`
+ );
+ }
+});
+
test('only content states may be not applicable with a reason', () => {
const evidence = report();
const contentStates = { ...evidence.contentStates, permission: { status: 'not-applicable', reason: 'Public view without restricted actions.' } };